unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 26987@debbugs.gnu.org
Subject: bug#26987: [PATCH 2/2] build: pull: Fix compilation list construction.
Date: Fri, 19 May 2017 15:55:31 +0200	[thread overview]
Message-ID: <86wp9d7xyk.fsf@gmail.com> (raw)
In-Reply-To: <87o9updmuv.fsf@gnu.org>


Hi Ludo,

It seems better but I can't get it to work neither :

>      (find (match-lambda
>              (('ssh _ ...) #t)
>              (_ #f))
> -        (source-module-closure file #:select? (const #t))))
> +          (source-module-closure module #:select? (const #t)))))

                                       ^
                                       we need a list here.
>  
>  (define (all-scheme-files directory)
>    "Return a sorted list of Scheme files found in DIRECTORY."
>
> WDYT?

So with

--8<---------------cut here---------------start------------->8---
(define (depends-on-guile-ssh? file)
  "Return true if FILE is a Scheme source file that depends, directly or
indirectly, on Guile-SSH."
  (let ((module (call-with-input-file file
                  (lambda (port)
                    (match (read port)
                      (('define-module name _ ...)
                       name))))))
    (find (match-lambda
            (('ssh _ ...) #t)
            (_ #f))
          (source-module-closure (list module) #:select? (const #t)))))
--8<---------------cut here---------------end--------------->8---

I get,

--8<---------------cut here---------------start------------->8---
((@@ (guix build pull) depends-on-guile-ssh?) "/home/mathieu/guix/guix/ssh.scm")

ERROR: In procedure open-file:
ERROR: Wrong type (expecting string): #f
--8<---------------cut here---------------end--------------->8---

I'm having a hard time tring to understand ,trace output.

Mathieu

  reply	other threads:[~2017-05-19 13:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18 19:53 bug#26987: guix pull without guile-ssh Mathieu Othacehe
2017-05-19  7:56 ` bug#26987: [PATCH 0/2] Fix compilation list construction Mathieu Othacehe
2017-05-19  7:56   ` bug#26987: [PATCH 1/2] guix: modules: Export module-name->file-name Mathieu Othacehe
2017-05-19  8:18     ` Ludovic Courtès
2017-05-19  7:56   ` bug#26987: [PATCH 2/2] build: pull: Fix compilation list construction Mathieu Othacehe
2017-05-19 12:58     ` Ludovic Courtès
2017-05-19 13:55       ` Mathieu Othacehe [this message]
2017-05-19 14:26         ` Mathieu Othacehe
2017-05-19 15:41           ` Ludovic Courtès
2017-05-25 12:33           ` Ludovic Courtès
2017-06-02  9:16             ` Mathieu Othacehe
2017-06-02 15:09               ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86wp9d7xyk.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=26987@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).