From: pukkamustard <pukkamustard@posteo.net>
To: Vivien Kraus <vivien@planete-kraus.eu>
Cc: 69682@debbugs.gnu.org, julien@lepiller.eu
Subject: bug#69682: [PATCH v2] gnu: ocaml-extlib: Convert to dune-build-system.
Date: Sun, 24 Mar 2024 07:12:19 +0000 [thread overview]
Message-ID: <86wmps5cfg.fsf@posteo.net> (raw)
In-Reply-To: <9f11376ea26f33e40bbf750f2c55a54b6ef9cd7f.1710022390.git.vivien@planete-kraus.eu>
Sorry for being late to the party. But the conversion to use
dune-build-system looks good to me!
I ran into the same issue when updating opam to 2.1.5 but never managed
to get to the bottom of it. Thanks for figuring this out!
-pukkamustard
Vivien Kraus <vivien@planete-kraus.eu> writes:
> * gnu/packages/ocaml.scm (ocaml-extlib) [build-system]: Convert to
> dune-build-system.
> [arguments]: Remove '#:phases' and add '#:package'.
>
> Change-Id: Ia50c05423f3062200704fbcbb0680f2b326a7ca4
> ---
> Opam still builds on gnome-team.
>
> gnu/packages/ocaml.scm | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
> index 0f4c351141..b70e925d51 100644
> --- a/gnu/packages/ocaml.scm
> +++ b/gnu/packages/ocaml.scm
> @@ -644,11 +644,9 @@ (define-public ocaml-extlib
> (sha256
> (base32
> "1jydzw2n84cfiz9y6lk4gih4wbr8jybanmiryfs01svd07g4vpjq"))))
> - (build-system ocaml-build-system)
> + (build-system dune-build-system)
> (arguments
> - `(#:phases
> - (modify-phases %standard-phases
> - (delete 'configure))))
> + (list #:package "extlib"))
> (native-inputs
> (list ocaml-cppo))
> (home-page "https://github.com/ygrek/ocaml-extlib")
>
> base-commit: 2f441fc738976175d438f7942211b1894e2eb416
next prev parent reply other threads:[~2024-03-24 7:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-09 19:45 bug#69682: Opam should be using a minimal version of extlib Vivien Kraus via Bug reports for GNU Guix
2024-03-09 21:03 ` bug#69682: [PATCH v2] gnu: ocaml-extlib: Convert to dune-build-system Vivien Kraus via Bug reports for GNU Guix
2024-03-24 7:12 ` pukkamustard [this message]
2024-03-09 21:19 ` bug#69682: [PATCH 0/1] ocaml-extlib: Build with minimal=1 Vivien Kraus via Bug reports for GNU Guix
2024-03-09 21:03 ` bug#69682: [PATCH 1/1] gnu: " Vivien Kraus via Bug reports for GNU Guix
2024-03-09 21:37 ` Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wmps5cfg.fsf@posteo.net \
--to=pukkamustard@posteo.net \
--cc=69682@debbugs.gnu.org \
--cc=julien@lepiller.eu \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).