From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id dVZtGcFyTmFRcwEAgWs5BA (envelope-from ) for ; Sat, 25 Sep 2021 02:52:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QDWoFMFyTmE7NwAA1q6Kng (envelope-from ) for ; Sat, 25 Sep 2021 00:52:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 050F6B4AA for ; Sat, 25 Sep 2021 02:52:17 +0200 (CEST) Received: from localhost ([::1]:35832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTvvM-0000fD-2S for larch@yhetil.org; Fri, 24 Sep 2021 20:52:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTvv9-0000bw-2i for bug-guix@gnu.org; Fri, 24 Sep 2021 20:52:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48071) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTvv8-00016X-Ra for bug-guix@gnu.org; Fri, 24 Sep 2021 20:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mTvv8-0000UV-Qp for bug-guix@gnu.org; Fri, 24 Sep 2021 20:52:02 -0400 Subject: bug#32167: Kernel 'build' directory in the store is a broken symbolic link Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Sat, 25 Sep 2021 00:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 32167 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Mail-Followup-To: 32167@debbugs.gnu.org, iskarian@mgsn.dev, pkill9@runbox.com Received: via spool by 32167-done@debbugs.gnu.org id=D32167.16325311051839 (code D ref 32167); Sat, 25 Sep 2021 00:52:02 +0000 Received: (at 32167-done) by debbugs.gnu.org; 25 Sep 2021 00:51:45 +0000 Received: from localhost ([127.0.0.1]:59614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTvuq-0000Tb-Un for submit@debbugs.gnu.org; Fri, 24 Sep 2021 20:51:45 -0400 Received: from out0.migadu.com ([94.23.1.103]:57628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTvuo-0000TR-SK for 32167-done@debbugs.gnu.org; Fri, 24 Sep 2021 20:51:44 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632531101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1uyt8GchtbnNYy8nuXQKGtimUXKYI09O69qKY4woEiU=; b=hmqNYJvDjm6QOkBfOW/RMdBDEdpnC98dKnPdZb1fnZtADML7GU0W2Z4dpas3Mzq3gvc4LC fJ6125AhN6Lzrj3aqWSLi1qf273nXpVPP5VVbxnUzmIyRNsCQLsAfKiux3ZnxEmGo8AbYa Sre+l1HXY4YFjej/xQrFssmxf7EnI+U= From: Sarah Morgensen References: <20180716201500.3d1f13ae@scratchpost.org> <87r2k2u9bl.fsf@netris.org> <87k1pmrtrq.fsf@gnu.org> Date: Fri, 24 Sep 2021 17:51:39 -0700 In-Reply-To: <87k1pmrtrq.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 23 Jul 2018 15:00:57 +0200 (3 years, 9 weeks, 17 hours ago)") Message-ID: <86v92pwk84.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 32167-done@debbugs.gnu.org, pkill9@runbox.com Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632531137; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=1uyt8GchtbnNYy8nuXQKGtimUXKYI09O69qKY4woEiU=; b=K4TINuCMG8weXgwFaoMUiG3tU2jcme1/YOUKAs4nvmxNNXQ4siSo8tPkPz/K3TfAvJ9w6V /abYvjXG5fAhjxExsEq+v8J3exqmhrUl8nW+5w+CL16wgNeobmuuG3AX7Ob+wYwz/+uNKN MpMs4axnvxk6XJeopscS1QVCg8Ndk5w2rj4J6nlxpbS1xE/M19Jwe6FF3yEvl3WphXVViu EalRVkRH1338OpqPX+SvD+j54ESS2YQzwUX5P10OUshiPbhd3v1wt7kwA51R5axMJDlWqf 71gYBA0p83jPGPfVaj9P4MmIF/tPGRHKP5BSKrob54s3X44v24xT9tx6fSi0ZA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632531137; a=rsa-sha256; cv=none; b=LXA15eNCpYp7pdAsSc7rqA/5hvpSCCbO5iwUSrcD3POb1uay+Gr7VlKZYYJJ+2rGP22rM7 3i4bbvaS+dt72eYfoHxBUxtbaIQ8u1HsQuhviKtAdIefnmFUzmSKqgjQP3NjzQVEh9x46l ZPzYtmVMmQyF4Jnmyj/iEO/co37+9KPgiqgBFpoNH3ZQ2sW636wdFj+EM+yh6/3s/g2kUZ qMRofiT1wZWw+61UFYA1hYuKUZ91ZSUy6VZvAZ6ZrF76Pp4ypGJrE6umpnbUSTLHhClln7 DQK+RObX7x3wtmcLXIm3r9RewkXP4yLgiIUe4iLpRJv+FNGGaLTDbYU2hi0D/g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=hmqNYJvD; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -0.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=hmqNYJvD; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 050F6B4AA X-Spam-Score: -0.29 X-Migadu-Scanner: scn1.migadu.com X-TUID: 1pvMMGZuA51x Hi all, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hi, > > Mark H Weaver skribis: > >> Danny Milosavljevic writes: >> >>> On Mon, 16 Jul 2018 18:55:11 +0100 (BST) >>> wrote: >>> >>>> It would be good to keep the build directory though, since it's >>>> expected to exist, and it's easier to just download a module's >>>> source and compile it and test it. >>> >>> I agree. >>> >>> /run/booted-system/kernel/lib/modules/4.17.3-gnu is in the store >>> anyway so it will be seen by the GC. >>> >>> The fix would be in linux-libre. >> >> If we were to preserve the kernel build directory as a store item, and >> keep a link from the modules directory to the build directory, that >> would greatly increase the size of the most minimal system that users >> could build. > > Yeah, we shouldn=E2=80=99t do that IMO. > >> If the intent here is to allow support for out-of-tree kernel modules, >> then fixing these symlinks would not solve the problem, and it's not >> clear to me that fixing them would be part of a proper solution on >> GuixSD. GuixSD is not a system where you can simply compile a kernel >> module manually and install it, because our module directory is >> immutable. If the goal is to support building out-of-tree kernel >> modules, that's a separate discussion that deserves its own "wishlist" >> bug report, I think. > > I agree. > > Ludo=E2=80=99. I am closing this old bug since the broken 'build' symlink no longer exists (nor do any other broken symlinks, as far as I can tell). As for building out-of-tree kernel modules, we now have linux-module-build-system, which uses `make-linux-module-builder', which builds the 'build' directory straight from the linux source with `make modules_prepare'. There are some improvements to be had there, for sure, but like mentioned above, that deserves its own wishlist item. -- Sarah