bug#67038: Inconsistent use of space before ellipsis

bug#67038: Inconsistent use of space before ellipsis

[Ricardo Wurmus]

When running “guix shell python python-numpy” we see output like this:

--8<---------------cut here---------------start------------->8---
applying 3 grafts for python-pytest-bootstrap-7.1.3 ...
applying 9 grafts for libxslt-1.1.37 ...
applying 6 grafts for python-lxml-4.9.1 ...
waiting for locks or build slots...
applying 4 grafts for python-xmlschema-1.2.5 ...
applying 7 grafts for python-pytest-7.1.3 ...
applying 11 grafts for python-numpy-1.23.2 ...
building CA certificate bundle...
listing Emacs sub-directories...
building fonts directory...
building directory of Info manuals...
building profile with 2 packages...
--8<---------------cut here---------------end--------------->8---

Note the inconsistency in whether we separate the ellipses from the
preceding text with a space or not.

-- 
Ricardo

bug#67038: Inconsistent use of space before ellipsis

[Simon Tournier]

[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]

Hi,

On Fri, 10 Nov 2023 at 10:12, Ricardo Wurmus <rekado@elephly.net> wrote:

> --8<---------------cut here---------------start------------->8---
> applying 3 grafts for python-pytest-bootstrap-7.1.3 ...
> applying 9 grafts for libxslt-1.1.37 ...
> applying 6 grafts for python-lxml-4.9.1 ...
> waiting for locks or build slots...
> applying 4 grafts for python-xmlschema-1.2.5 ...
> applying 7 grafts for python-pytest-7.1.3 ...
> applying 11 grafts for python-numpy-1.23.2 ...
> building CA certificate bundle...
> listing Emacs sub-directories...
> building fonts directory...
> building directory of Info manuals...
> building profile with 2 packages...
> --8<---------------cut here---------------end--------------->8---
>
> Note the inconsistency in whether we separate the ellipses from the
> preceding text with a space or not.

Well, to my knowledge, the typographical rule is not clear depending on
some style; without going to USA vs UK vs ….

For consistency, I suggest the rule: ’word...’ and not ’word ...’

Something like the patch attached.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: p.patch --]
[-- Type: text/x-diff, Size: 776 bytes --]

diff --git a/guix/status.scm b/guix/status.scm
index fd89ba9dd3..0ed6d3318a 100644
--- a/guix/status.scm
+++ b/guix/status.scm
@@ -494,8 +494,8 @@ (define* (print-build-event event old-status status
            (let ((count (match (assq-ref properties 'graft)
                           (#f  0)
                           (lst (or (assq-ref lst 'count) 0)))))
-             (format port (info (N_ "applying ~a graft for ~a ..."
-                                    "applying ~a grafts for ~a ..."
+             (format port (info (N_ "applying ~a graft for ~a..."
+                                    "applying ~a grafts for ~a..."
                                     count))
                      count
                      (string-drop-right (store-path-package-name drv)

[-- Attachment #3: Type: text/plain, Size: 22 bytes --]


WDYT?

Cheers,
simon

bug#67038: Inconsistent use of space before ellipsis

[pelzflorian (Florian Pelz)]

Simon Tournier <zimon.toutoune@gmail.com> writes:
> For consistency, I suggest the rule: ’word...’ and not ’word ...’
>
> Something like the patch attached.

+1

This is more consistent.  Looking at the translation files in po/guix,
only guix/status.scm:568 uses the space before ellipsis.  The message
"applying ~a graft" does not occur in the manual, so it does not need
changing.

(match event
  […]
  (('download-started item uri _ ...)
   (when print-urls?
     (erase-current-line*)
     (format port (info (G_ "downloading from ~a ...")) uri)
     (newline port)))

Should we keep this space?  Perhaps keep it; it is clearer where the
URI ends.

Regards,
Florian

bug#67038: Inconsistent use of space before ellipsis

[Ludovic Courtès]

Hi,

"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:

> Simon Tournier <zimon.toutoune@gmail.com> writes:
>> For consistency, I suggest the rule: ’word...’ and not ’word ...’
>>
>> Something like the patch attached.
>
> +1

+1!

> (match event
>   […]
>   (('download-started item uri _ ...)
>    (when print-urls?
>      (erase-current-line*)
>      (format port (info (G_ "downloading from ~a ...")) uri)
>      (newline port)))
>
> Should we keep this space?  Perhaps keep it; it is clearer where the
> URI ends.

Yes, we should keep this one: somebody added it on the grounds that it
allowed them to click on URLs in their terminal and get the correct URL,
without the period.

Ludo’.

bug#67038: [PATCH] guix: status: Fix ellipsis inconsistencies.

[Adriel Dumas--Jondeau via Bug reports for GNU Guix]

Fixes <https://issues.guix.gnu.org/67038>.
Reported by Ricardo Wurmus.

* guix/status.scm (print-build-event): Fix ellipsis inconsistencies.
---
 guix/status.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

We just made this patch after Capitole du Libre at Toulouse as an example for
my first patch \o/

diff --git a/guix/status.scm b/guix/status.scm
index fd89ba9dd3..0ed6d3318a 100644
--- a/guix/status.scm
+++ b/guix/status.scm
@@ -494,8 +494,8 @@ (define* (print-build-event event old-status status
            (let ((count (match (assq-ref properties 'graft)
                           (#f  0)
                           (lst (or (assq-ref lst 'count) 0)))))
-             (format port (info (N_ "applying ~a graft for ~a ..."
-                                    "applying ~a grafts for ~a ..."
+             (format port (info (N_ "applying ~a graft for ~a..."
+                                    "applying ~a grafts for ~a..."
                                     count))
                      count
                      (string-drop-right (store-path-package-name drv)

base-commit: 761810d32a0550912b5bb36a0c9f60141bcb7d20
-- 
2.41.0