From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uCFTN6RE3l/CWQAA0tVLHw (envelope-from ) for ; Sat, 19 Dec 2020 18:21:24 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eMUMM6RE3l+tJwAAbx9fmQ (envelope-from ) for ; Sat, 19 Dec 2020 18:21:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 46B6B940667 for ; Sat, 19 Dec 2020 18:21:24 +0000 (UTC) Received: from localhost ([::1]:33600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqgr4-0002Th-6k for larch@yhetil.org; Sat, 19 Dec 2020 13:21:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqgql-0002TN-Po for bug-guix@gnu.org; Sat, 19 Dec 2020 13:21:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59820) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kqgqk-0000b2-Lv for bug-guix@gnu.org; Sat, 19 Dec 2020 13:21:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kqgqk-0001CB-Hg for bug-guix@gnu.org; Sat, 19 Dec 2020 13:21:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#45193: Wrapper of Qt programs doesn't extend existing environment variable Resent-From: Zhu Zihao Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 19 Dec 2020 18:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45193 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Hartmut Goebel Received: via spool by 45193-submit@debbugs.gnu.org id=B45193.16084020374542 (code B ref 45193); Sat, 19 Dec 2020 18:21:02 +0000 Received: (at 45193) by debbugs.gnu.org; 19 Dec 2020 18:20:37 +0000 Received: from localhost ([127.0.0.1]:43133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqgqL-0001BC-A1 for submit@debbugs.gnu.org; Sat, 19 Dec 2020 13:20:37 -0500 Received: from mail-m973.mail.163.com ([123.126.97.3]:56440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqgq8-0001An-Q1 for 45193@debbugs.gnu.org; Sat, 19 Dec 2020 13:20:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=CS8Am GyqNYUEmGZ0iMDjylQMCh7P5I9sax4zXPLT42I=; b=HmKTSfyRJhPD5EuCyO3sy sXwCsSvW9PMG9qd9q4ZFwky4elZlJYYj5//zVSAcdc9OTCOA/g1zKi1etFU/0oxU 2zXD9apRqpzq0r3mHSpdmQ+wWMtbf/2l2V+xE5EJue0p/a52hlFbh/JL20/wiHlQ 1oQ/jjZcgiM+R78EvXl0DY= Received: from asus-laptop (unknown [112.93.141.169]) by smtp3 (Coremail) with SMTP id G9xpCgBnFttbRN5f3ggHQA--.42700S2; Sun, 20 Dec 2020 02:20:12 +0800 (CST) References: <1cc6eb46-813b-ba3c-f796-30d545f35941@crazy-compilers.com> User-agent: mu4e 1.4.13; emacs 27.1 From: Zhu Zihao In-reply-to: <1cc6eb46-813b-ba3c-f796-30d545f35941@crazy-compilers.com> Date: Sun, 20 Dec 2020 02:20:06 +0800 Message-ID: <86pn35wtd5.fsf@163.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-CM-TRANSID: G9xpCgBnFttbRN5f3ggHQA--.42700S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZFWkXrWfuF13WF47tr4DCFg_yoW8Gw15pF ZYkw1Yqr4qkryjyw1Iva4I9F10k3y8Cw1akrZ5Za1jkws0gr92vrySka1a93ZrCan3Xr1Y 9a1j9w48C345ZrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jbjjgUUUUU= X-Originating-IP: [112.93.141.169] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/1tbitBwAr1SIjxhjsAAAsf X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45193@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 0.68 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=163.com header.s=s110527 header.b=HmKTSfyR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=163.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 46B6B940667 X-Spam-Score: 0.68 X-Migadu-Scanner: scn0.migadu.com X-TUID: KzZyJzSioO1t --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hartmut Goebel writes: > I agree that leaking the environments variables from the build environmen= t to > the package is not a good idea. Also we might want to add some filters to= avoid > all imports (including cmake) are going into the wrapping variables - whi= ch is > much easier when dealing with inputs nor strings. I just check how Nixpkgs do Qt wrapping, it use same strategy like wrap-qt-= program. Since our environment variable only contains the path to inputs, capture the build-time environment can be forgiven (compare with patch-shebang). I think the main problem is include unwanted directory accidentally and increase the closure size. But it looks like an impossible job to do it automatically. My idea is provide a keyword argument #:qt-wrap-exclude-inputs to prevent qt-build-system to search unwanted inpu= ts. BTW, would you like to use prefix wrap for wrap-qt-program in qt-utils.scm? > If I understand the code correctly, line 103 of qt-build-system also han= dle the > output directories > > (append (list directory) > input-directories)))) > > and the qt-build-system should even handle different outputs (while qt-tu= ils > does not): > > (for-each handle-output outputs) > > (I may be wrong on this, please double check. Yes you're right, output was handled. I misunderstood the code before.=20 =2D-=20 Retrieve my PGP public key: gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F Zihao --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIsEARYIADMWIQTUepyLKuOQW1Y9kTW+QrNSqfaCHwUCX95EVhUcYWxsX2J1dF9s YXN0QDE2My5jb20ACgkQvkKzUqn2gh8a+wD9Gej5w9JFo3MrHCsR0ZxbZ+OfvrRd 3eJmofU4bXyeVsMA/RY9Rnz1pBHz33e2EYFGX7scnEdZWgVVYuoSccS22XsI =jqQ+ -----END PGP SIGNATURE----- --=-=-=--