From: Zhu Zihao <all_but_last@163.com>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 45193@debbugs.gnu.org
Subject: bug#45193: Wrapper of Qt programs doesn't extend existing environment variable
Date: Sun, 20 Dec 2020 02:20:06 +0800 [thread overview]
Message-ID: <86pn35wtd5.fsf@163.com> (raw)
In-Reply-To: <1cc6eb46-813b-ba3c-f796-30d545f35941@crazy-compilers.com>
[-- Attachment #1: Type: text/plain, Size: 1525 bytes --]
Hartmut Goebel writes:
> I agree that leaking the environments variables from the build environment to
> the package is not a good idea. Also we might want to add some filters to avoid
> all imports (including cmake) are going into the wrapping variables - which is
> much easier when dealing with inputs nor strings.
I just check how Nixpkgs do Qt wrapping, it use same strategy like wrap-qt-program.
Since our environment variable only contains the path to inputs, capture
the build-time environment can be forgiven (compare with patch-shebang).
I think the main problem is include unwanted directory accidentally and
increase the closure size. But it looks like an impossible job to do it
automatically. My idea is provide a keyword argument
#:qt-wrap-exclude-inputs to prevent qt-build-system to search unwanted inputs.
BTW, would you like to use prefix wrap for wrap-qt-program in qt-utils.scm?
> If I understand the code correctly, line 103 of qt-build-system also handle the
> output directories
>
> (append (list directory)
> input-directories))))
>
> and the qt-build-system should even handle different outputs (while qt-tuils
> does not):
>
> (for-each handle-output outputs)
>
> (I may be wrong on this, please double check.
Yes you're right, output was handled. I misunderstood the code before.
--
Retrieve my PGP public key:
gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F
Zihao
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 255 bytes --]
next prev parent reply other threads:[~2020-12-19 18:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-12 9:11 bug#45193: Wrapper of Qt programs doesn't extend existing environment variable Zhu Zihao
[not found] ` <handler.45193.B.160776432713396.ack@debbugs.gnu.org>
2020-12-12 9:19 ` bug#45193: Acknowledgement (Wrapper of Qt programs doesn't extend existing environment variable) Zhu Zihao
2020-12-14 20:45 ` bug#45193: Wrapper of Qt programs doesn't extend existing environment variable Mark H Weaver
2020-12-15 1:50 ` Zhu Zihao
2020-12-17 11:35 ` Zhu Zihao
2020-12-19 13:13 ` Hartmut Goebel
2020-12-19 18:20 ` Zhu Zihao [this message]
2020-12-19 19:12 ` Hartmut Goebel
2021-01-10 16:34 ` Zhu Zihao
2021-01-11 8:17 ` Hartmut Goebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pn35wtd5.fsf@163.com \
--to=all_but_last@163.com \
--cc=45193@debbugs.gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).