From: zimoun <zimon.toutoune@gmail.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 45645@debbugs.gnu.org
Subject: bug#45645: Please revoke this commit: 7dd1a2174a8376c521dcf271e3b76f64096074fe
Date: Fri, 26 Mar 2021 10:21:35 +0100 [thread overview]
Message-ID: <86o8f69so0.fsf@gmail.com> (raw)
In-Reply-To: <X/Mi3dBD8K5b0iVQ@3900XT> (Efraim Flashner's message of "Mon, 4 Jan 2021 16:14:53 +0200")
Hi,
On Mon, 04 Jan 2021 at 16:14, Efraim Flashner <efraim@flashner.co.il> wrote:
> On Mon, Jan 04, 2021 at 09:52:38AM +0800, luhux wrote:
>> ```
>> const gchar *stardict_data_dir = g_getenv("STARDICT_DATA_DIR");
>> std::string data_dir;
>> if (!opt_data_dir) {
>> if (!only_data_dir) {
>> if (stardict_data_dir)
>> data_dir = stardict_data_dir;
>> else
>> data_dir = "/usr/share/stardict/dic";
>> }
>> } else {
>> data_dir = get_impl(opt_data_dir);
>> }
>>
>> ```
>>
>> Please revoke the content of this commit.
I am not seeing a commit reverting
7dd1a2174a8376c521dcf271e3b76f64096074fe. Am I correct?
> Do you have an easy test case? Something like 'guix environment --ad-hoc
> sdvc stardict-en stardict-es -- sdvc'? I'd like to get it working. What
> is it looking for, just one directory?
Should 7dd1a2174a8376c521dcf271e3b76f64096074fe be reverted waiting a
proper fix or is it let as it is?
In order to close this. :-)
Cheers,
simon
next prev parent reply other threads:[~2021-03-26 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 1:52 bug#45645: Please revoke this commit: 7dd1a2174a8376c521dcf271e3b76f64096074fe luhux
2021-01-04 14:14 ` Efraim Flashner
2021-03-26 9:21 ` zimoun [this message]
2021-03-29 13:15 ` Efraim Flashner
2021-06-09 21:48 ` zimoun
2021-06-10 6:47 ` Leo Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o8f69so0.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=45645@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).