From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id tNL5E6ln/F99fAAA0tVLHw (envelope-from ) for ; Mon, 11 Jan 2021 14:58:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kFFQD6ln/F/MFAAAB5/wlQ (envelope-from ) for ; Mon, 11 Jan 2021 14:58:49 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C6BA49404D0 for ; Mon, 11 Jan 2021 14:58:48 +0000 (UTC) Received: from localhost ([::1]:40428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyyed-0007YZ-OL for larch@yhetil.org; Mon, 11 Jan 2021 09:58:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyya1-0004rp-Uj for bug-guix@gnu.org; Mon, 11 Jan 2021 09:54:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44749) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kyya1-0000KU-N5 for bug-guix@gnu.org; Mon, 11 Jan 2021 09:54:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kyya1-00041p-K9 for bug-guix@gnu.org; Mon, 11 Jan 2021 09:54:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#45615: SWH API break? Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 11 Jan 2021 14:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45615 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 45615-submit@debbugs.gnu.org id=B45615.161037683715474 (code B ref 45615); Mon, 11 Jan 2021 14:54:01 +0000 Received: (at 45615) by debbugs.gnu.org; 11 Jan 2021 14:53:57 +0000 Received: from localhost ([127.0.0.1]:56295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyyZw-00041V-Kh for submit@debbugs.gnu.org; Mon, 11 Jan 2021 09:53:56 -0500 Received: from mail-wr1-f48.google.com ([209.85.221.48]:33508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyyZv-00041F-73 for 45615@debbugs.gnu.org; Mon, 11 Jan 2021 09:53:55 -0500 Received: by mail-wr1-f48.google.com with SMTP id t30so102953wrb.0 for <45615@debbugs.gnu.org>; Mon, 11 Jan 2021 06:53:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=nRuZZ/8s9L0m+TA1gQ9BJMuf3FMPVlXYzb87wq+Evew=; b=uJHFqR0UZkdI5UzO7eZp7CVqQP/6B3X5UTSSmGPruLcZ6iLmgZRpLtg4CiPaqvNcso L625cgX+gxiv8PhbV5wRey/2WnLKCfKtPER2qt2MKxJkmQI93QK/QmsXUA11u9sZoeuF +xoc795ezX/63y5QlnBe24Na+ekXfpTvGLsVCSNgCQ03OLedTYVRKQdJq78NAY19yZnD 6RVc3U8e1u0l9uMmOB1PRupQOK8pDSQdPrBsHcHcAEQ/fIknpQiMeFZktbNErzkE0fnC VLQgI7bHiKkN+JuXkr4AwUxxoscMXkYmB+HslKZ44HB/ehnf+jR08mxA8inkmXcrY+Qv Jshw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=nRuZZ/8s9L0m+TA1gQ9BJMuf3FMPVlXYzb87wq+Evew=; b=skiguXrPMlGJCu5sJGAntljDOpET/BH2Of6/OJEgL9v1ItJuD6+EYtSwOBKpJNqZOO WLWKimtLOwhJAoLC6i12kNLo1I4CiN+7vSFpwIFlt6iXvNF6Cu6iC3VVU5eL2vDGZjXo GT4UqfHnOzgIisUMqYYeFXWlEGHSkpFrrvezQ7IMFsoi9Motd1+Mxg6NKEkW7dk5wc/v 1JEKq4S/DMgFUN+m9NJntyhglHR4LmybcVG504eDoLErY7LakSr+Ny5WkIfcg3PkeJMs isQGS6QwdP9FsgvZprF3XN0Juch9ROAvUdYoTe3m3oXM6GPF9V1u+JKIRId/3RmdHnbi A2jg== X-Gm-Message-State: AOAM530IxDg/DRoleAfXnRD7w2wZSJmHXrCuSu/4cikmp6OC/GMa0+4E VGj9Y6jysIAVjVjnaWRjLVxHLfVQtVY= X-Google-Smtp-Source: ABdhPJy0zbun9/qrRdWOQ6IVYXaRzMwe+sXptzjTfpHF6f9ipidTOcIDs5sT/CrmYlwsat7jywTh0w== X-Received: by 2002:a5d:4ccf:: with SMTP id c15mr16762820wrt.237.1610376829160; Mon, 11 Jan 2021 06:53:49 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id y6sm10985wmg.39.2021.01.11.06.53.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 06:53:48 -0800 (PST) From: zimoun In-Reply-To: <87a6tffwi9.fsf@gnu.org> References: <18602984-9fa4-5d72-f17a-306c7336d5ea@crazy-compilers.com> <87a6tffwi9.fsf@gnu.org> Date: Mon, 11 Jan 2021 15:45:55 +0100 Message-ID: <86lfczsfa4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45615@debbugs.gnu.org, Hartmut Goebel Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.25 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=uJHFqR0U; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: C6BA49404D0 X-Spam-Score: -0.25 X-Migadu-Scanner: scn1.migadu.com X-TUID: ysC1LrW0oYnr Hi Ludo, On Mon, 11 Jan 2021 at 14:12, Ludovic Court=C3=A8s wrote: >> (snapshot-url visit-snapshot-url "snapshot_url" string*) ;string | #f [...] >> and why it is not string or #f. > > As discussed on IRC the other day, the culprit seems to be the recent > guile-json upgrade (from 4.3.2 to 4.4.1, commit > f9e1baa8933ea2ed385d0272dbfbe4e22f192bde). > > Were you able to check the raw JSON and see where the value is getting > lost? Well, maybe I miss something. The JSON looks like: https://archive.softwareheritage.org/api/1/origin/https://github.com/Genivi= a/ugrep/get/ as we already discussed [1] the other day. From my understanding, when the field does not exist, before guile-json sets to #f and now it sets to #; I guess that it is related to the NEWS entry: --8<---------------cut here---------------start------------->8--- - Record-JSON mapping now allows using *unspecified* values to indicate a field record should not be serialized. (Fixes #61) --8<---------------cut here---------------end--------------->8--- and the behaviour change is described here: --8<---------------cut here---------------start------------->8--- Unspecified fields will now have the value *unspecified*. You mention that json->link-record would assign a #f but that's not actually correct, since a field could be a boolean in which case there would not be a way to identify it.=20 --8<---------------cut here---------------end--------------->8--- I am not familiar enough with Guile-JSON to see how to fix. Any tips? Cheers, simon 1: