unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: ng0 <ng0@n0.is>
Cc: 29485@debbugs.gnu.org
Subject: bug#29485: perl-geo-ip is broken since ever!
Date: Thu, 03 Dec 2020 01:34:23 +0100	[thread overview]
Message-ID: <86k0tzzq0g.fsf@gmail.com> (raw)
In-Reply-To: <20171128154158.p3k4jyn3izfimfu5@abyayala> (ng0@n0.is's message of "Tue, 28 Nov 2017 15:41:58 +0000")

Hi,

The old bug #29485 is about the hard coded database of the package
perl-geo-ip.

   <http://issues.guix.gnu.org/issue/29485>
   
On Tue, 28 Nov 2017 at 15:41, ng0 <ng0@n0.is> wrote:

> user@abyayala /gnu/store/5mhrli41qbcpns3gg0yf1vv07lvpg8hm-perl-geo-ip-1.51$ egrep -nr "/usr/" lib/perl5/site_perl/5.26.0/
> lib/perl5/site_perl/5.26.0/Geo/IP/Record.pod:9:  my $gi = Geo::IP->open("/usr/local/share/GeoIP/GeoIPCity.dat", GEOIP_STANDARD);
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:5075:# default path /usr/local/share/GeoIP
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:5159:    my $def_db_file = '/usr/local/share/GeoIP/GeoIP.dat';
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:5962:  my $gi = Geo::IP->open("/usr/local/share/GeoIP/GeoIPCity.dat", GEOIP_STANDARD);
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:5984:  my $g = Geo::IP->open('/usr/local/share/GeoIP/GeoIPv6.dat') or die;
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:6046:I<datadir>, typically I</usr/local/share/GeoIP/GeoIP.dat>.
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:6078:typically I</usr/local/share/GeoIP/GeoIPCity.dat>.
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:6226:  my $g = Geo::IP->open('/usr/local/share/GeoIP/GeoIPv6.dat') or die;

I am reproducing this with the Guix commit f4450e8.


> However this is not really a problem unless you are on GuixSD.
> As we do not package the DB of MaxDB (yet) you'll need for this, it's
> not a problem. I'm filing this bug to remind myself to fix Geo::IP once
> I have revisited the discussion we had about the DB a while back.

It is a problem and the package is broken.  I am assuming this package
is not used so I am proposing to simply remove it.  Otherwise, the
database should be also packaged, else it appears to me meaningless.


All the best,
simon




  parent reply	other threads:[~2020-12-03  0:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28 15:41 bug#29485: perl-geo-ip has /usr/share/ within the code ng0
2017-11-28 15:53 ` ng0
2020-12-03  0:34 ` zimoun [this message]
2020-12-03  6:08   ` bug#29485: perl-geo-ip is broken since ever! Leo Famulari
2020-12-22 17:00     ` zimoun
2020-12-22 19:24       ` Leo Famulari
2020-12-22 20:07         ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86k0tzzq0g.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=29485@debbugs.gnu.org \
    --cc=ng0@n0.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).