From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GBvfFfScXWAxZAAAgWs5BA (envelope-from ) for ; Fri, 26 Mar 2021 09:36:04 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WGG+D/ScXWC+CAAAB5/wlQ (envelope-from ) for ; Fri, 26 Mar 2021 08:36:04 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B6F62222CE for ; Fri, 26 Mar 2021 09:36:03 +0100 (CET) Received: from localhost ([::1]:33838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPhwn-0000Il-8C for larch@yhetil.org; Fri, 26 Mar 2021 04:36:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPhvq-000895-CN for bug-guix@gnu.org; Fri, 26 Mar 2021 04:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57015) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPhvq-00059E-3r for bug-guix@gnu.org; Fri, 26 Mar 2021 04:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lPhvq-0004uT-0M for bug-guix@gnu.org; Fri, 26 Mar 2021 04:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#47028: [PATCH 2/2] lint: Warn about single-character package names. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 26 Mar 2021 08:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47028 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Tobias Geerinckx-Rice Received: via spool by 47028-submit@debbugs.gnu.org id=B47028.161674764518805 (code B ref 47028); Fri, 26 Mar 2021 08:35:01 +0000 Received: (at 47028) by debbugs.gnu.org; 26 Mar 2021 08:34:05 +0000 Received: from localhost ([127.0.0.1]:40328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPhuv-0004tF-5L for submit@debbugs.gnu.org; Fri, 26 Mar 2021 04:34:05 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:50919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPhur-0004sj-EL for 47028@debbugs.gnu.org; Fri, 26 Mar 2021 04:34:03 -0400 Received: by mail-wm1-f41.google.com with SMTP id g25so2558943wmh.0 for <47028@debbugs.gnu.org>; Fri, 26 Mar 2021 01:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=p5afeC3AM8oYrKkoCpbsncXEJLL92MrrrX/zEA19sFo=; b=Byh28F2BH/KCwusZDijUhVDM7JMQMdjIbvDCTWv64JUSldK35sRVPtB6I3Tg/TR9xQ VDBZGoGtMlSsSKQydbXoXOWQWBYh6khg9NqLBeNNU05UH5uKgUAQo2K7NIPnm0DkEUdK AGFjUFdsdjEr00tYKnjXi0hFBGDuaIrXRS9B8yJc7hQyZPS1vCz+4Jcfur2f5S7i7YVW svNaeR/AnVA6/iSxSjYx6xzyH1cMOfQsQzjq4kUFvIXiyKEeaWDbUO8KG8pVR5fE29Ds BeKsWjoqq9uGWSmxv4ReQ2yS4AZPaj7XuexIwheM3kjAtH5vg+P4xFoiTxnflaOzZGbC 1a2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=p5afeC3AM8oYrKkoCpbsncXEJLL92MrrrX/zEA19sFo=; b=uVkeSA+tufzLnJKSJz5aJicjlLvZs2ic4GcEAtGiprKSdAhNwyXQKrTJQIO3zbpSZ7 jn5WP53tOgagaX4HAUC268FYaVwZYcCXJGFz2GcXlCt2ezSrU8SZosE3xkAL8o+QI2om neSi5p7ju2WbeOixqBFLIJNAFwftYJM+sG8vD7TT80DyfsvALSCPOkBByKMALiF9OpoX Wo2OqzrK9sZ90XrMm4YXtBWaE1nOmb3txf3cwqcXdjHoMZ2vBoqme8QL83hBbTGdHajh OYVqUP52uCc5b6harx40yJR/qMwF42IErNuraRRoFjNl+/nhkVB8GWS5vop1A3XwINUw 2XPg== X-Gm-Message-State: AOAM531HgKLz+7ElkWMRns4V3gFMoxRkCEgeaXFCsr9ZGeRbngpeNGgU CqOqTEWok84DI6Z3+S9w1fIL2pskII0= X-Google-Smtp-Source: ABdhPJzKZiJSxl0y2wbmnxDtr2s/ZAUIEX6i++adE4LeMLe7BxSUDPujpTsuTPLVUpR74jD8QpWKag== X-Received: by 2002:a1c:3954:: with SMTP id g81mr11824279wma.170.1616747635559; Fri, 26 Mar 2021 01:33:55 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id b65sm9820226wmh.4.2021.03.26.01.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 01:33:55 -0700 (PDT) From: zimoun References: <87eegom2gk.fsf@nckx> <20210309214158.31754-1-me@tobias.gr> <20210309214158.31754-2-me@tobias.gr> Date: Fri, 26 Mar 2021 09:26:03 +0100 In-Reply-To: <20210309214158.31754-2-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Tue, 9 Mar 2021 22:41:58 +0100") Message-ID: <86im5eb9t0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 47028@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616747763; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=p5afeC3AM8oYrKkoCpbsncXEJLL92MrrrX/zEA19sFo=; b=DmD3olMh4iikOhN2moMN/GMNPfPxBH6Ct5LkmQ4Cb6D3l8aUT3QsttSE5oBhHwn1LVBXN+ tBdKEn6bf+SzgEfJAXqvI09RowVtWYogpGFHGGn1SRPL2QhEfmAqs1g9wQYDy2Q2x64d+S pOvdNdCiX3dOMlsJq6TPD3YphmOp6qkT0ZhvWKneejy/OCu3cOYCE3Sal1rfGfht9YrelR p5eT3heZBSG85eSd8/gQ9wX0d7/mTa/Bbz9VE1NgcCH/3wBNxftcxA3BvgJF3vGz7YrOUl ARdu9FMHH0CSJJsjZhQw9gnVsoJj+qN4rkYbkmSnUW5Pkj7KShFgaT+1tDhlmw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616747763; a=rsa-sha256; cv=none; b=cZlFyiKk3TpPdKyeeTi5wnPTLe8LUHY39Y2lfte1YERS72Gn6xSf0+R3OsBYqCLHquPXdw 5cD4zRSOdYUqEpSNWoGnfWRO5tgdH98caSL1CZVM2NXNTFjMN1HFBjKM/0Y8RmXylMvWUT bo1dHYM4RqHJ/0JMlR2ted1ep8TFIzZseDbge/1Nt0yAEdaNmFX7fD/U9FMss0WQO/ZGCE UgSZ2h/LBHZbuMzriX+wDeQKOL2cgXmBP8hZI1aXLBKqdYQ6djUJhRHqv7bjGA4l/bvxQ7 cKhx35Oh/IOcNhVCBnSr5dRWQ5MPNkMfWsFsmPlqy1n0dYd7WbDofF5RbqcIHQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=Byh28F2B; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=Byh28F2B; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: B6F62222CE X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: J25q5Jb7iMkm Hi, On Tue, 09 Mar 2021 at 22:41, Tobias Geerinckx-Rice wrote: > +(define (check-name package) > + "Check whether PACKAGE's name matches our guidelines." > + ;; Currently checks only whether the name is too short. > + (if (<= (string-length (package-name package)) 1) Maybe the length can be negative or zero. ;-) Well, both patches are LGTM. Cheers, simon