unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 47028@debbugs.gnu.org
Subject: bug#47028: [PATCH 2/2] lint: Warn about single-character package names.
Date: Fri, 26 Mar 2021 09:26:03 +0100	[thread overview]
Message-ID: <86im5eb9t0.fsf@gmail.com> (raw)
In-Reply-To: <20210309214158.31754-2-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Tue, 9 Mar 2021 22:41:58 +0100")

Hi,

On Tue, 09 Mar 2021 at 22:41, Tobias Geerinckx-Rice <me@tobias.gr> wrote:

> +(define (check-name package)
> +  "Check whether PACKAGE's name matches our guidelines."
> +  ;; Currently checks only whether the name is too short.
> +  (if (<= (string-length (package-name package)) 1)

Maybe the length can be negative or zero. ;-)


Well, both patches are LGTM.


Cheers,
simon




  reply	other threads:[~2021-03-26  8:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87h7lkj3pt.fsf@netris.org>
2021-03-09 21:39 ` bug#47028: Discourage single-character package names Tobias Geerinckx-Rice via Bug reports for GNU Guix
2021-03-09 21:41   ` bug#47028: [PATCH 1/2] doc: Discourage ambiguous " Tobias Geerinckx-Rice via Bug reports for GNU Guix
2021-03-09 21:41     ` bug#47028: [PATCH 2/2] lint: Warn about single-character " Tobias Geerinckx-Rice via Bug reports for GNU Guix
2021-03-26  8:26       ` zimoun [this message]
2021-04-01  8:51         ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2021-04-01 20:41         ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2021-03-09 21:51     ` bug#47028: [PATCH 1/2] doc: Discourage ambiguous " Tobias Geerinckx-Rice via Bug reports for GNU Guix
2021-03-10  0:44   ` bug#47028: Discourage single-character " Mark H Weaver
2021-03-10 11:28     ` Ludovic Courtès
2021-03-10 13:04     ` zimoun
2021-04-01  8:57   ` Tobias Geerinckx-Rice via Bug reports for GNU Guix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86im5eb9t0.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=47028@debbugs.gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).