unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Simon Tournier <zimon.toutoune@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>, 61513@debbugs.gnu.org
Cc: Jelle Licht <jlicht@fsfe.org>
Subject: bug#61513: [PATCH 1/2] gnu: Add emacs-next-tree-sitter.
Date: Tue, 21 Feb 2023 13:38:01 +0100	[thread overview]
Message-ID: <86ilfv9ot2.fsf@gmail.com> (raw)
In-Reply-To: <d60b119458c4c75843f14ea4d984631c9c2dc3a9.camel@gmail.com>

Hi,

On Mon, 20 Feb 2023 at 20:21, Liliana Marie Prikler <liliana.prikler@gmail.com> wrote:

>> Naive question: why not squash the 2 patches?  Adding the new
>> variable and fix the version of emacs-next.
>
> Because the next patch "upgrades" emacs-next to the then HEAD of the
> emacs-29 branch, which wasn't hitherto packaged in Guix.
> Alternatively, one could reset it to an earlier version in the first
> commit, but we have a(n informal) policy that discourages downgrades.

Ah indeed, thanks for the explanations.

IIUC, the error seems Guix commit
6f0c9053244d6b4cfc4130c963a15dbf83cbcdac in the first place, introducing
Emacs commit ac7ec87a7a0db887e4ae7fe9005aea517958b778 which is not from
the Emacs 29 series but from the Emacs 30 series.

Well, I do not think if we can speak about downgrade here. :-)  Anyway.

It LGTM.


Cheers,
simon






  reply	other threads:[~2023-02-21 13:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 20:34 bug#61513: emacs-next@29.0.60 self-reports as version 30.0.50 Jelle Licht
2023-02-16 20:36 ` bug#61513: [PATCH 1/2] gnu: Add emacs-next-tree-sitter Liliana Marie Prikler
2023-02-20 10:33   ` Simon Tournier
2023-02-20 19:21     ` Liliana Marie Prikler
2023-02-21 12:38       ` Simon Tournier [this message]
2023-02-26  8:25         ` Liliana Marie Prikler
2023-02-16 20:45 ` bug#61513: [PATCH 2/2] gnu: emacs-next: Update to 29.0.60-1.f1f571e Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ilfv9ot2.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=61513@debbugs.gnu.org \
    --cc=jlicht@fsfe.org \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).