From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id CBcGEseLGmWPZwAAauVa8A:P1 (envelope-from ) for ; Mon, 02 Oct 2023 11:22:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id CBcGEseLGmWPZwAAauVa8A (envelope-from ) for ; Mon, 02 Oct 2023 11:22:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 177AB40CC2 for ; Mon, 2 Oct 2023 11:22:15 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=gewYlxeA; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696238535; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=x9FCYtfbJ2+U16ZKW8LQb0DAS1/6j9f2E0l9cczmbs0=; b=fP9qocbWxWu385wEWhvyGhS82w4om55OtOjrSmxGrnYJWHsLpHBrtUcMWuD/7adeb9CPlN et1dtJ9Tc3InnK7546qtIBj+XvPpbE/PtwZ13liE3nWAHsm3My5xX+6X2IugC2eKOrRkmJ T4N8OACXJYr3wwT5YoTbWEB7bQk7HQVE/1Uc3I5/2OD4AQ+9OTsHHdKxS4Xg5eo3Nshz/G HpuZQ7jVFX4oQIYWULTbsko/4nqVCGgaon/P9+0sQ5Giq61nS6On7gHXTNytbTHb74kPdU x0eVjnQZWnfPSO33JloriDG079Q8JVMtuWv0QP7uQ91QzqpGb5EbzOmm7LlRDQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=gewYlxeA; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696238535; a=rsa-sha256; cv=none; b=ILg4ynQUWVQcpDcNAd/zjlMoUxXdhO0TZ9+gadmkCGNkjUrO89DMeTofypavgEnxI/aH8t kOxL66+HZwrd/n1cN9TphYVDMzhJzatR+MmCeWq+h1QqmLPOSCLPqwmM3GzbhEQj3CWJ3I 1IKsYgtp6uuYVZKN3Hw89/ms9NJs45tX/28jYWX+otZDoAFxz5YFiSnbTSThyY11BNqLtK hXC0wTYju5TJoxfDqt2grDnExcAYKQQDLFmgDrvVyJb1VquBcYLNd31ZWPcRK8dnjgLp4R z+2h0d16HMkNmFwM9Rplqik/LjrZ7P6V3KAZWgoUSt5JnOpL2V1sC5aNIU1DFQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qnF7p-0005Tr-3U; Mon, 02 Oct 2023 05:22:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnF7b-0005EY-ER for bug-guix@gnu.org; Mon, 02 Oct 2023 05:21:48 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qnF7a-0007qD-Pt for bug-guix@gnu.org; Mon, 02 Oct 2023 05:21:47 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qnF7r-0007Sg-8N for bug-guix@gnu.org; Mon, 02 Oct 2023 05:22:03 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#66268: Guix makes invalid assumptions regarding guile-git guarantees leading to guix pull failing Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 02 Oct 2023 09:22:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66268 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: wolf , 66268@debbugs.gnu.org Received: via spool by 66268-submit@debbugs.gnu.org id=B66268.169623848328606 (code B ref 66268); Mon, 02 Oct 2023 09:22:03 +0000 Received: (at 66268) by debbugs.gnu.org; 2 Oct 2023 09:21:23 +0000 Received: from localhost ([127.0.0.1]:36039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnF79-0007Qz-12 for submit@debbugs.gnu.org; Mon, 02 Oct 2023 05:21:22 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:40407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnF71-0007Q5-IX for 66268@debbugs.gnu.org; Mon, 02 Oct 2023 05:21:15 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-32163c3ece5so1990525f8f.1 for <66268@debbugs.gnu.org>; Mon, 02 Oct 2023 02:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696238449; x=1696843249; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=x9FCYtfbJ2+U16ZKW8LQb0DAS1/6j9f2E0l9cczmbs0=; b=gewYlxeArhBTVbJZlNTtT2DprV8LBPx+uGBGcezjcioeHGhnf+aiBptVWumygaylSS Qf35wNwW8WPghb59GgrsSz05f9grxltiT0RkQwR2qf9DAV+ubdjdJczj8YUaHxIEi4wD a47a/9Q3ysJGJhfQ/Oxv6J9ozopkBSpclFGVWlnm9BzvE8IEZuhIrOKoyUMCT3S8ge1Q K7trknlvxylPUC9lIpcvhTtCDFL3Lo6ukidZDZsdGZweKjsaTY3ERkylANi32IpCiWAB OhyYsVgfLs/Z+NcFX8vZDUCRS0YLVrCafPKqMyWzJg7UHvOb+qIvh6gZRF9MvHqTCTrw Nb6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696238449; x=1696843249; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=x9FCYtfbJ2+U16ZKW8LQb0DAS1/6j9f2E0l9cczmbs0=; b=j2m1rkuOJYhyk/pNtttE49xkw/FVmuMXOEK3avS9lXc4XjrI8d+aShnhBs/qFn/DQC +QPk5mMvM9EC5PvN2sn4RwE1LNbxSmIC7WRLM0ZCLqwkYjDJc/PvVS0Mgka4GSQvmRJF GsYilNFokhu87vaZtdXBJbcmf13ag4X5jnAVrnZttAEkggU7wq8gacETVxug+aWAAMk5 ouFPrWkugDXomveruvqRivP/ZXP7bu2LfbxG2CWZjkS8VlMQ921RUUuGO/07nQyS25gJ iuo745HXp7gvBpyJfVgfD8TJJg3CLVURuQQ+oCzQ5fdzPn4MlvpNFIkOuylxen1TCNyr WYeQ== X-Gm-Message-State: AOJu0Yzlyie6GPn7Rx6aSYpvE/RFWW5qWTbkp3qlx6sj/A4PoJ9Y6q25 jDvsc6IrITcn9HfoZ4T1Fu1GIc84cls= X-Google-Smtp-Source: AGHT+IFgStVQGZgQUZ5jgCIwBmQM98xj5vb+9fYWjOqLUaGwlBvUwb/Y9u41Dduu513HSivOP2hVig== X-Received: by 2002:a5d:6909:0:b0:322:5251:d78b with SMTP id t9-20020a5d6909000000b003225251d78bmr8945769wru.6.1696238447809; Mon, 02 Oct 2023 02:20:47 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id p5-20020a5d4585000000b0031ad5470f89sm27581510wrq.18.2023.10.02.02.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 02:20:47 -0700 (PDT) From: Simon Tournier In-Reply-To: References: Date: Sat, 30 Sep 2023 17:48:55 +0200 Message-ID: <86fs2vek60.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.90 X-Migadu-Scanner: mx2.migadu.com X-Migadu-Queue-Id: 177AB40CC2 X-Spam-Score: 2.90 X-TUID: StTyODN9+S06 Hi, Hum, the updates seem: + libgit2 on Feb 17 2023, + guile-git on May 15 2022. (See 8d8e1438ae5a2e50005b500dacd0a26be540fe69 and b6bfe9ea6a1b19159455b34f1af4ac00ef9b94ab) And some commits with large body are around: + 7b45ead9ec40a5ea1ef8332d55c2bb4beff85eb5 from Jul 18 2023 + 1e6ddceb8318d413745ca1c9d91fde01b1e0364b from Feb 19 2023 + 5897d873d0c902f08d13c38500eff11098f2a634 from Aug 10 2022 And I have not investigated more about their commit object size. Just counting the number of characters per commit message. The one you provided is about 3030, if I am correct. Here, let filter with the criteria of 4500, why not. :-) --8<---------------cut here---------------start------------->8--- $ for ci in $(git log --format=3D%H --after=3D2022-05-13); do \ echo "$(git show -s $ci | wc -c) $ci" \ | awk '$1>4500{print $2 " " $1}' \ ;done=20 7b45ead9ec40a5ea1ef8332d55c2bb4beff85eb5 4997 1e6ddceb8318d413745ca1c9d91fde01b1e0364b 16120 575a03ab3997edee08d20867228e886043d5240f 5511 5897d873d0c902f08d13c38500eff11098f2a634 6258 --8<---------------cut here---------------end--------------->8--- Well, it is probably not a regression. Or I am missing some details. :-) I am probably overlooking something, from my understanding, the issue arises for some corner cases when the bound of the closure does not fit =E2=80=99eq?=E2=80=99. For these cases, instead of relying on =E2=80=99set= q=E2=80=99 using =E2=80=99eq?=E2=80=99, we could rely on =E2=80=99set=E2=80=99 using =E2=80=99equal?=E2=80=99. No? On Fri, 29 Sep 2023 at 18:52, wolf wrote: > ,---- > | scheme@(guile-user)> (use-modules (git) (guix git)) > | scheme@(guile-user)> (define %repo (repository-open "/tmp/my-fork")) > | scheme@(guile-user)> (define %hash "d51135e8477118dc63a7e5462355cd27e= 884f4fb") > | scheme@(guile-user)> (commit-relation > | (commit-lookup %repo (string->oid %hash)) > | (commit-lookup %repo (string->oid %hash))) > | $5 =3D unrelated > `---- [...] > ,---- > | $ git merge-base --is-ancestor 9b985229bcd 71f544c102a; echo $? > | 0 > `---- [...] > 2 Possible solutions > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Naive question. Why not rely on =E2=80=9Cgit merge-base --is-ancestor=E2= =80=9D for implementing =E2=80=9Ccommit-relation=E2=80=9D? Since f651a359691cbe4750f1fe8d14dd964f7971f91 from Sep 26 2023: build: Add dependency on Git. * configure.ac: Check for =E2=80=98git=E2=80=99 and substitute =E2=80= =98GIT=E2=80=99. * guix/config.scm.in (%git): New variable. * guix/self.scm (compiled-guix): Define =E2=80=98git=E2=80=99 and pass = it to =E2=80=98make-config.scm=E2=80=99. (make-config.scm): Add #:git; emit a =E2=80=98%git=E2=80=99 variable. * doc/guix.texi (Requirements): Add it. we can assume Git is available by the code that run =E2=80=9Ccommit-relatio= n=E2=80=9D, no? The implementation relying on =E2=80=9Cgit merge-base --is-ancestor=E2=80= =9D does not have the problem, right? And from [1], it is 35x faster. Win-win, no? Because the fix for =E2=80= =99eq?=E2=80=99 will introduce performance cost and =E2=80=99commit-relation=E2=80=99 will = be even slower, no? Well, I do not know. My words are probably irrelevant. Cheers, simon 1: comparing commit-relation using Scheme+libgit2 vs shellout plumbing Git Simon Tournier Tue, 12 Sep 2023 00:48:30 +0200 id:865y4gz5q9.fsf@gmail.com https://lists.gnu.org/archive/html/guix-devel/2023-09 https://yhetil.org/guix/865y4gz5q9.fsf@gmail.com