From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Othacehe <m.othacehe@gmail.com>
Subject: bug#27007: [PATCH 1/2] bootloader: Use menu-entry to define custom
	bootloader entries.
Date: Tue, 06 Jun 2017 10:14:24 +0200
Message-ID: <86bmq1jzxb.fsf@gmail.com>
References: <87shjvsquh.fsf@gnu.org>
	<20170531072328.16116-1-m.othacehe@gmail.com>
	<20170531072328.16116-2-m.othacehe@gmail.com> <87efuyenru.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50671)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dI9dp-0004I6-CT
	for bug-guix@gnu.org; Tue, 06 Jun 2017 04:15:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dI9dm-0002YL-7D
	for bug-guix@gnu.org; Tue, 06 Jun 2017 04:15:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:55776)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dI9dm-0002YE-3a
	for bug-guix@gnu.org; Tue, 06 Jun 2017 04:15:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dI9dl-00012P-Rh
	for bug-guix@gnu.org; Tue, 06 Jun 2017 04:15:01 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.27007.B27007.14967368653925@debbugs.gnu.org>
In-reply-to: <87efuyenru.fsf@gnu.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 27007@debbugs.gnu.org


Hi Ludo,

> Do we still need ‘device-mount-point’ now?  For the dual-boot use case,
> I don’t see how this would be used.

Nope, you're right it's not needed in <menu-entry>.

>> +   (initrd (menu-entry-initrd menu-entry))))
>
> It’s weird to set ‘store-device’ and ‘store-mount-point’ here since
> there’s no store (at least when defining a menu entry for another distro
> or OS).  Should we set them to #f?

Sound ok !

> BTW, this is unrelated to this patch series, but I think ‘boot-name’
> should be renamed to ‘bootloader-name’ since that’s what it is.

Ok.

> Thank you for working on this!

Thanks for reviewing :)

Mathieu