bug#31970: epiphany: Strange "XXXXXXXXXXXXX..." entries in library RPATHs

bug#31970: epiphany: Strange "XXXXXXXXXXXXX..." entries in library RPATHs

[Mark H Weaver]

Since the upgrade from epiphany-3.24.4 to 3.28.1 in commit
fc5c5b92cf7a1f6d65079f3840df502edcf58f50,

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=fc5c5b92cf7a1f6d65079f3840df502edcf58f50

which also changed the build-system from 'glib-or-gtk-build-system' to
'meson-build-system', warnings started appearing in the build logs for
epiphany complaining about "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"
appearing in the RPATH of the built libraries.

Here's the last build on Hydra of epiphany-2.24.4 on x86_64 master,
which does not include the warnings:

  https://hydra.gnu.org/build/2633780

Here's the first build on Hydra of epiphany-3.28.1 on x86_64 master,
which includes the warnings:

  https://hydra.gnu.org/build/2642004

See below for the relevant excerpt of the build log.  Note also the
RPATH entries preceeding "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
beginning with "$ORIGIN/".  I'm not sure if those are a problem or not.

      Mark

--8<---------------cut here---------------start------------->8---
starting phase `strip'
stripping binaries in "/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib" with "strip" and flags ("--strip-debug")
stripping binaries in "/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/libexec" with "strip" and flags ("--strip-debug")
stripping binaries in "/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/bin" with "strip" and flags ("--strip-debug")
phase `strip' succeeded after 0.0 seconds
starting phase `fix-runpath'
/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany/libephymain.so: changing RPATH from ("$ORIGIN/../lib" "$ORIGIN/../lib/sync" "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX" "/gnu/store/n6acaivs0jwiwpidjr551dhdni5kgpcr-glibc-2.26.105-g0890d5379c/lib" "/gnu/store/xfjba1kww8ngdc6nxldd8ly93nh13ayy-gcc-5.5.0-lib/lib" "/gnu/store/fs5f2mhnz2czgkcwd594f3i8yh0lyrfd-cairo-1.14.10/lib" "/gnu/store/xg4s4kkmgl0vrc8pkayisdgp4z52z51x-gdk-pixbuf+svg-2.36.11/lib" "/gnu/store/sm37m59gq3smxxz8gs4jikn50qg0g7xh-glib-2.54.2/lib" "/gnu/store/w3fln0k01r96grk6dalhslhqdgiirza5-gtk+-3.22.28/lib" "/gnu/store/pwbx5fhjrq9crr1c0d2x08ch0l6vr3cv-pango-1.40.14/lib" "/gnu/store/k4g19cqifm221m1ds0xsbalzf5l0a4al-json-glib-1.4.2/lib" "/gnu/store/1pc7nbv72rcsicn1w7bhasmszsrzrvqm-libsoup-2.62.1/lib" "/gnu/store/mv9m6bxdhijhlfvxpja3km6v599b4pv5-libxml2-2.9.7/lib" "/gnu/store/1p1rpw3r36a15frw20pppydddvzb7s8m-webkitgtk-2.20.1/lib" "/gnu/store/sh8x9wn7fia7d0d73h04lrcwj84sq3a1-gcr-3.20.0/lib" "/gnu/store/wchs0c6kxvdnpyfr609p77iwipk0l2p5-libnotify-0.7.7/lib") to ("/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany:/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany" "$ORIGIN/../lib" "$ORIGIN/../lib/sync" "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX" "/gnu/store/n6acaivs0jwiwpidjr551dhdni5kgpcr-glibc-2.26.105-g0890d5379c/lib" "/gnu/store/xfjba1kww8ngdc6nxldd8ly93nh13ayy-gcc-5.5.0-lib/lib" "/gnu/store/fs5f2mhnz2czgkcwd594f3i8yh0lyrfd-cairo-1.14.10/lib" "/gnu/store/xg4s4kkmgl0vrc8pkayisdgp4z52z51x-gdk-pixbuf+svg-2.36.11/lib" "/gnu/store/sm37m59gq3smxxz8gs4jikn50qg0g7xh-glib-2.54.2/lib" "/gnu/store/w3fln0k01r96grk6dalhslhqdgiirza5-gtk+-3.22.28/lib" "/gnu/store/pwbx5fhjrq9crr1c0d2x08ch0l6vr3cv-pango-1.40.14/lib" "/gnu/store/k4g19cqifm221m1ds0xsbalzf5l0a4al-json-glib-1.4.2/lib" "/gnu/store/1pc7nbv72rcsicn1w7bhasmszsrzrvqm-libsoup-2.62.1/lib" "/gnu/store/mv9m6bxdhijhlfvxpja3km6v599b4pv5-libxml2-2.9.7/lib" "/gnu/store/1p1rpw3r36a15frw20pppydddvzb7s8m-webkitgtk-2.20.1/lib" "/gnu/store/sh8x9wn7fia7d0d73h04lrcwj84sq3a1-gcr-3.20.0/lib" "/gnu/store/wchs0c6kxvdnpyfr609p77iwipk0l2p5-libnotify-0.7.7/lib")
/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany/libephysync.so: changing RPATH from ("$ORIGIN/.." "/gnu/store/n6acaivs0jwiwpidjr551dhdni5kgpcr-glibc-2.26.105-g0890d5379c/lib" "/gnu/store/xfjba1kww8ngdc6nxldd8ly93nh13ayy-gcc-5.5.0-lib/lib" "/gnu/store/sm37m59gq3smxxz8gs4jikn50qg0g7xh-glib-2.54.2/lib" "/gnu/store/k4g19cqifm221m1ds0xsbalzf5l0a4al-json-glib-1.4.2/lib" "/gnu/store/0mk25fngkr23yb59vdqia5j537ppij26-libsecret-0.18.6/lib" "/gnu/store/1pc7nbv72rcsicn1w7bhasmszsrzrvqm-libsoup-2.62.1/lib" "/gnu/store/pxflf9nzyy3mic176p4424f4czrz5v3f-gmp-6.1.2/lib" "/gnu/store/zgkx59mskhn6lcyf9v2z7frblhq139fq-nettle-3.4/lib") to ("/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany" "$ORIGIN/.." "/gnu/store/n6acaivs0jwiwpidjr551dhdni5kgpcr-glibc-2.26.105-g0890d5379c/lib" "/gnu/store/xfjba1kww8ngdc6nxldd8ly93nh13ayy-gcc-5.5.0-lib/lib" "/gnu/store/sm37m59gq3smxxz8gs4jikn50qg0g7xh-glib-2.54.2/lib" "/gnu/store/k4g19cqifm221m1ds0xsbalzf5l0a4al-json-glib-1.4.2/lib" "/gnu/store/0mk25fngkr23yb59vdqia5j537ppij26-libsecret-0.18.6/lib" "/gnu/store/1pc7nbv72rcsicn1w7bhasmszsrzrvqm-libsoup-2.62.1/lib" "/gnu/store/pxflf9nzyy3mic176p4424f4czrz5v3f-gmp-6.1.2/lib" "/gnu/store/zgkx59mskhn6lcyf9v2z7frblhq139fq-nettle-3.4/lib")
/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany/web-extensions/libephywebextension.so: changing RPATH from ("$ORIGIN/../../lib" "$ORIGIN/../../lib/sync" "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX" "/gnu/store/n6acaivs0jwiwpidjr551dhdni5kgpcr-glibc-2.26.105-g0890d5379c/lib" "/gnu/store/xfjba1kww8ngdc6nxldd8ly93nh13ayy-gcc-5.5.0-lib/lib" "/gnu/store/sm37m59gq3smxxz8gs4jikn50qg0g7xh-glib-2.54.2/lib" "/gnu/store/w3fln0k01r96grk6dalhslhqdgiirza5-gtk+-3.22.28/lib" "/gnu/store/1pc7nbv72rcsicn1w7bhasmszsrzrvqm-libsoup-2.62.1/lib" "/gnu/store/1p1rpw3r36a15frw20pppydddvzb7s8m-webkitgtk-2.20.1/lib") to ("/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany:/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany" "$ORIGIN/../../lib" "$ORIGIN/../../lib/sync" "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX" "/gnu/store/n6acaivs0jwiwpidjr551dhdni5kgpcr-glibc-2.26.105-g0890d5379c/lib" "/gnu/store/xfjba1kww8ngdc6nxldd8ly93nh13ayy-gcc-5.5.0-lib/lib" "/gnu/store/sm37m59gq3smxxz8gs4jikn50qg0g7xh-glib-2.54.2/lib" "/gnu/store/w3fln0k01r96grk6dalhslhqdgiirza5-gtk+-3.22.28/lib" "/gnu/store/1pc7nbv72rcsicn1w7bhasmszsrzrvqm-libsoup-2.62.1/lib" "/gnu/store/1p1rpw3r36a15frw20pppydddvzb7s8m-webkitgtk-2.20.1/lib")
/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/libexec/.epiphany-search-provider-real: changing RPATH from ("$ORIGIN/" "$ORIGIN/../lib" "$ORIGIN/../lib/sync" "XXXXXXXXXXXXXXXXXXXXXXXXXXXXX" "/gnu/store/n6acaivs0jwiwpidjr551dhdni5kgpcr-glibc-2.26.105-g0890d5379c/lib" "/gnu/store/xfjba1kww8ngdc6nxldd8ly93nh13ayy-gcc-5.5.0-lib/lib" "/gnu/store/sm37m59gq3smxxz8gs4jikn50qg0g7xh-glib-2.54.2/lib" "/gnu/store/w3fln0k01r96grk6dalhslhqdgiirza5-gtk+-3.22.28/lib" "/gnu/store/1pc7nbv72rcsicn1w7bhasmszsrzrvqm-libsoup-2.62.1/lib") to ("/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany:/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany" "$ORIGIN/" "$ORIGIN/../lib" "$ORIGIN/../lib/sync" "XXXXXXXXXXXXXXXXXXXXXXXXXXXXX" "/gnu/store/n6acaivs0jwiwpidjr551dhdni5kgpcr-glibc-2.26.105-g0890d5379c/lib" "/gnu/store/xfjba1kww8ngdc6nxldd8ly93nh13ayy-gcc-5.5.0-lib/lib" "/gnu/store/sm37m59gq3smxxz8gs4jikn50qg0g7xh-glib-2.54.2/lib" "/gnu/store/w3fln0k01r96grk6dalhslhqdgiirza5-gtk+-3.22.28/lib" "/gnu/store/1pc7nbv72rcsicn1w7bhasmszsrzrvqm-libsoup-2.62.1/lib")
/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/libexec/epiphany/.ephy-profile-migrator-real: changing RPATH from ("$ORIGIN/" "$ORIGIN/../lib" "$ORIGIN/../lib/sync" "XXXXXXXXXXXXXXXXXXXXXXXXXXXXX" "/gnu/store/n6acaivs0jwiwpidjr551dhdni5kgpcr-glibc-2.26.105-g0890d5379c/lib" "/gnu/store/xfjba1kww8ngdc6nxldd8ly93nh13ayy-gcc-5.5.0-lib/lib" "/gnu/store/sm37m59gq3smxxz8gs4jikn50qg0g7xh-glib-2.54.2/lib" "/gnu/store/k4g19cqifm221m1ds0xsbalzf5l0a4al-json-glib-1.4.2/lib" "/gnu/store/0mk25fngkr23yb59vdqia5j537ppij26-libsecret-0.18.6/lib" "/gnu/store/mv9m6bxdhijhlfvxpja3km6v599b4pv5-libxml2-2.9.7/lib" "/gnu/store/1p1rpw3r36a15frw20pppydddvzb7s8m-webkitgtk-2.20.1/lib") to ("/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany:/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany:/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany" "$ORIGIN/" "$ORIGIN/../lib" "$ORIGIN/../lib/sync" "XXXXXXXXXXXXXXXXXXXXXXXXXXXXX" "/gnu/store/n6acaivs0jwiwpidjr551dhdni5kgpcr-glibc-2.26.105-g0890d5379c/lib" "/gnu/store/xfjba1kww8ngdc6nxldd8ly93nh13ayy-gcc-5.5.0-lib/lib" "/gnu/store/sm37m59gq3smxxz8gs4jikn50qg0g7xh-glib-2.54.2/lib" "/gnu/store/k4g19cqifm221m1ds0xsbalzf5l0a4al-json-glib-1.4.2/lib" "/gnu/store/0mk25fngkr23yb59vdqia5j537ppij26-libsecret-0.18.6/lib" "/gnu/store/mv9m6bxdhijhlfvxpja3km6v599b4pv5-libxml2-2.9.7/lib" "/gnu/store/1p1rpw3r36a15frw20pppydddvzb7s8m-webkitgtk-2.20.1/lib")
/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/bin/.epiphany-real: changing RPATH from ("$ORIGIN/" "$ORIGIN/../lib" "$ORIGIN/../lib/sync" "XXXXXXXXXXXXXXXXXXXXXXXXXXXXX" "/gnu/store/n6acaivs0jwiwpidjr551dhdni5kgpcr-glibc-2.26.105-g0890d5379c/lib" "/gnu/store/xfjba1kww8ngdc6nxldd8ly93nh13ayy-gcc-5.5.0-lib/lib" "/gnu/store/sm37m59gq3smxxz8gs4jikn50qg0g7xh-glib-2.54.2/lib" "/gnu/store/w3fln0k01r96grk6dalhslhqdgiirza5-gtk+-3.22.28/lib" "/gnu/store/mv9m6bxdhijhlfvxpja3km6v599b4pv5-libxml2-2.9.7/lib" "/gnu/store/wchs0c6kxvdnpyfr609p77iwipk0l2p5-libnotify-0.7.7/lib") to ("/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany:/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany" "$ORIGIN/" "$ORIGIN/../lib" "$ORIGIN/../lib/sync" "XXXXXXXXXXXXXXXXXXXXXXXXXXXXX" "/gnu/store/n6acaivs0jwiwpidjr551dhdni5kgpcr-glibc-2.26.105-g0890d5379c/lib" "/gnu/store/xfjba1kww8ngdc6nxldd8ly93nh13ayy-gcc-5.5.0-lib/lib" "/gnu/store/sm37m59gq3smxxz8gs4jikn50qg0g7xh-glib-2.54.2/lib" "/gnu/store/w3fln0k01r96grk6dalhslhqdgiirza5-gtk+-3.22.28/lib" "/gnu/store/mv9m6bxdhijhlfvxpja3km6v599b4pv5-libxml2-2.9.7/lib" "/gnu/store/wchs0c6kxvdnpyfr609p77iwipk0l2p5-libnotify-0.7.7/lib")
phase `fix-runpath' succeeded after 2.0 seconds
starting phase `validate-runpath'
validating RUNPATH of 4 binaries in "/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib"...
/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany/libephymain.so: warning: RUNPATH contains bogus entries: ("XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX")
/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/lib/epiphany/web-extensions/libephywebextension.so: warning: RUNPATH contains bogus entries: ("XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX")
validating RUNPATH of 2 binaries in "/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/libexec"...
/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/libexec/.epiphany-search-provider-real: warning: RUNPATH contains bogus entries: ("XXXXXXXXXXXXXXXXXXXXXXXXXXXXX")
/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/libexec/epiphany/.ephy-profile-migrator-real: warning: RUNPATH contains bogus entries: ("XXXXXXXXXXXXXXXXXXXXXXXXXXXXX")
validating RUNPATH of 1 binaries in "/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/bin"...
/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/bin/.epiphany-real: warning: RUNPATH contains bogus entries: ("XXXXXXXXXXXXXXXXXXXXXXXXXXXXX")
phase `validate-runpath' succeeded after 0.0 seconds
starting phase `validate-documentation-location'
phase `validate-documentation-location' succeeded after 0.0 seconds
starting phase `delete-info-dir-file'
phase `delete-info-dir-file' succeeded after 0.0 seconds
starting phase `patch-dot-desktop-files'
adjusting 1 '.desktop' files in "/gnu/store/11brb84am3j1k4cxvpv4vwi1vhv80xcd-epiphany-3.28.1/share/applications"
phase `patch-dot-desktop-files' succeeded after 0.0 seconds
starting phase `install-license-files'
installing 0 license files
phase `install-license-files' succeeded after 0.0 seconds
starting phase `reset-gzip-timestamps'
phase `reset-gzip-timestamps' succeeded after 0.0 seconds
starting phase `compress-documentation'
phase `compress-documentation' succeeded after 0.0 seconds
@ build-succeeded /gnu/store/ayz6arvn9qa5wl9bh7wrbamxq6ddpvs7-epiphany-3.28.1.drv -
--8<---------------cut here---------------end--------------->8---

bug#31970: epiphany: Strange "XXXXXXXXXXXXX..." entries in library RPATHs

[Ludovic Courtès]

Hi Mark,

Mark H Weaver <mhw@netris.org> skribis:

> which also changed the build-system from 'glib-or-gtk-build-system' to
> 'meson-build-system', warnings started appearing in the build logs for
> epiphany complaining about "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"
> appearing in the RPATH of the built libraries.

I suspect the only way those XXX can end up here is if Meson adds them
through -Wl,-rpath.  And indeed, it does!  From compilers.py:

--8<---------------cut here---------------start------------->8---
    def build_unix_rpath_args(self, build_dir, from_dir, rpath_paths, build_rpath, install_rpath):
        if not rpath_paths and not install_rpath and not build_rpath:
            return []
        # The rpaths we write must be relative, because otherwise
        # they have different length depending on the build
        # directory. This breaks reproducible builds.
        rel_rpaths = []
        for p in rpath_paths:
            if p == from_dir:
                relative = '' # relpath errors out in this case
            else:
                relative = os.path.relpath(os.path.join(build_dir, p), os.path.join(build_dir, from_dir))
            rel_rpaths.append(relative)
        paths = ':'.join([os.path.join('$ORIGIN', p) for p in rel_rpaths])
        # Build_rpath is used as-is (it is usually absolute).
        if build_rpath != '':
            if paths != '':
                paths += ':'
            paths += build_rpath
        if len(paths) < len(install_rpath):
            padding = 'X' * (len(install_rpath) - len(paths))
            if not paths:
                paths = padding
            else:
                paths = paths + ':' + padding
--8<---------------cut here---------------end--------------->8---

So AIUI, those XXX are here precisely so we can overwrite the RUNPATH at
installation time with the final RUNPATH (this works around the fact
that Meson, unlike Libtool, doesn’t relink files upon install.)

We should take advantage of this in ‘meson-build-system’, or maybe we
don’t need to do anything?

> See below for the relevant excerpt of the build log.  Note also the
> RPATH entries preceeding "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
> beginning with "$ORIGIN/".  I'm not sure if those are a problem or not.

Use of $ORIGIN is fine.

Thanks,
Ludo’.

bug#31970: epiphany: Strange "XXXXXXXXXXXXX..." entries in library RPATHs

[Sarah Morgensen]

Hi,

Mark H Weaver <mhw@netris.org> writes:

> Since the upgrade from epiphany-3.24.4 to 3.28.1 in commit
> fc5c5b92cf7a1f6d65079f3840df502edcf58f50,
>
>   https://git.savannah.gnu.org/cgit/guix.git/commit/?id=fc5c5b92cf7a1f6d65079f3840df502edcf58f50
>
> which also changed the build-system from 'glib-or-gtk-build-system' to
> 'meson-build-system', warnings started appearing in the build logs for
> epiphany complaining about "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"
> appearing in the RPATH of the built libraries.

Closing this old issue.  (On current master, the build logs no longer
show that error, and `readelf -d' reports no such bogus entries.)

--
Sarah