* bug#43296: Gnome Builder doesn't install.
@ 2020-09-09 19:04 Marinus Savoritias
2020-09-10 16:58 ` bug#43296: bug#43269: " Leo Prikler
2020-09-10 18:26 ` bug#43296: [PATCH] " Leo Prikler
0 siblings, 2 replies; 7+ messages in thread
From: Marinus Savoritias @ 2020-09-09 19:04 UTC (permalink / raw)
To: 43296
Gnome builder fails to install with this message:
swzg5y9hnggp7aghz8q2l-gnome-builder-3.36.1.drv' failed with exit code 1
build of
/gnu/store/w2lzd0dc6qbswzg5y9hnggp7aghz8q2l-gnome-builder-3.36.1.drv failed
The message in the log is this:
ld:
/gnu/store/sh764z2hm5qcr4cqx4amcipcbkvg76i2-libselinux-3.0/lib/libselinux.a(setrans_client.o):
relocation R_X86_64_32 against `.rodata.str1.8' can not be used when
making a PIE object; recompile with -fPIE
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
command "ninja" "-j" "4" failed with status 1
Marinus Savoritias
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#43296: bug#43269: Gnome Builder doesn't install.
2020-09-09 19:04 bug#43296: Gnome Builder doesn't install Marinus Savoritias
@ 2020-09-10 16:58 ` Leo Prikler
2020-09-10 16:58 ` bug#43296: [PATCH 1/1] gnu: Fix gnome-builder build Leo Prikler
2020-09-10 18:26 ` bug#43296: [PATCH] " Leo Prikler
1 sibling, 1 reply; 7+ messages in thread
From: Leo Prikler @ 2020-09-10 16:58 UTC (permalink / raw)
To: 43296
Hi Marinus,
I've noticed your report and quickly found a rather crude way of fixing it.
I'm not sure, why meson tries to link gnome-builder statically against selinux
in the first place, but it should do the job.
Regards,
Leo
Leo Prikler (1):
gnu: Fix gnome-builder build.
gnu/packages/gnome.scm | 6 ++++++
1 file changed, 6 insertions(+)
--
2.28.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#43296: [PATCH 1/1] gnu: Fix gnome-builder build.
2020-09-10 16:58 ` bug#43296: bug#43269: " Leo Prikler
@ 2020-09-10 16:58 ` Leo Prikler
2020-09-10 18:08 ` Mark H Weaver
2020-09-10 18:23 ` Ricardo Wurmus
0 siblings, 2 replies; 7+ messages in thread
From: Leo Prikler @ 2020-09-10 16:58 UTC (permalink / raw)
To: 43296
As reported in #43296, gnome-builder tries to be linked against the static
version of libselinux (propagated through glib/gio), failing to do so, as it
also wants to be a PIE. To keep the PIE, link it against the dynamic library.
* gnu/packages/gnome.scm (gnome-builder)[#:phases]: Add 'fix-ninja.
---
gnu/packages/gnome.scm | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 31c5b0319c..ff4cb8a383 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -11336,6 +11336,12 @@ libraries. Applications do not need to be recompiled--or even restarted.")
(string-append (assoc-ref inputs "python-pygobject")
"/lib")))
#t))
+ (add-after 'configure 'fix-ninja
+ (lambda _
+ ;; #43296: meson(?) incorrectly assumes we want to link
+ ;; this PIE against a static libselinux.
+ (substitute* "build.ninja"
+ (("libselinux\\.a") "libselinux.so"))))
(add-before 'check 'pre-check
(lambda _
(system "Xvfb :1 &")
--
2.28.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* bug#43296: [PATCH 1/1] gnu: Fix gnome-builder build.
2020-09-10 16:58 ` bug#43296: [PATCH 1/1] gnu: Fix gnome-builder build Leo Prikler
@ 2020-09-10 18:08 ` Mark H Weaver
2020-09-10 18:23 ` Ricardo Wurmus
1 sibling, 0 replies; 7+ messages in thread
From: Mark H Weaver @ 2020-09-10 18:08 UTC (permalink / raw)
To: Leo Prikler, 43296
Hi,
Leo Prikler <leo.prikler@student.tugraz.at> writes:
> As reported in #43296, gnome-builder tries to be linked against the static
> version of libselinux (propagated through glib/gio), failing to do so, as it
> also wants to be a PIE. To keep the PIE, link it against the dynamic library.
> * gnu/packages/gnome.scm (gnome-builder)[#:phases]: Add 'fix-ninja.
> ---
> gnu/packages/gnome.scm | 6 ++++++
> 1 file changed, 6 insertions(+)
Thanks for this! One comment, though:
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 31c5b0319c..ff4cb8a383 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -11336,6 +11336,12 @@ libraries. Applications do not need to be recompiled--or even restarted.")
> (string-append (assoc-ref inputs "python-pygobject")
> "/lib")))
> #t))
> + (add-after 'configure 'fix-ninja
> + (lambda _
> + ;; #43296: meson(?) incorrectly assumes we want to link
> + ;; this PIE against a static libselinux.
> + (substitute* "build.ninja"
> + (("libselinux\\.a") "libselinux.so"))))
> (add-before 'check 'pre-check
> (lambda _
> (system "Xvfb :1 &")
This new phase should end by returning #t.
Thanks,
Mark
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#43296: [PATCH 1/1] gnu: Fix gnome-builder build.
2020-09-10 16:58 ` bug#43296: [PATCH 1/1] gnu: Fix gnome-builder build Leo Prikler
2020-09-10 18:08 ` Mark H Weaver
@ 2020-09-10 18:23 ` Ricardo Wurmus
1 sibling, 0 replies; 7+ messages in thread
From: Ricardo Wurmus @ 2020-09-10 18:23 UTC (permalink / raw)
To: Leo Prikler; +Cc: 43296
Leo Prikler <leo.prikler@student.tugraz.at> writes:
> As reported in #43296, gnome-builder tries to be linked against the static
> version of libselinux (propagated through glib/gio), failing to do so, as it
> also wants to be a PIE. To keep the PIE, link it against the dynamic library.
> * gnu/packages/gnome.scm (gnome-builder)[#:phases]: Add 'fix-ninja.
> ---
> gnu/packages/gnome.scm | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 31c5b0319c..ff4cb8a383 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -11336,6 +11336,12 @@ libraries. Applications do not need to be recompiled--or even restarted.")
> (string-append (assoc-ref inputs "python-pygobject")
> "/lib")))
> #t))
> + (add-after 'configure 'fix-ninja
> + (lambda _
> + ;; #43296: meson(?) incorrectly assumes we want to link
> + ;; this PIE against a static libselinux.
> + (substitute* "build.ninja"
> + (("libselinux\\.a") "libselinux.so"))))
Please end the phase on #t, because “substitute*” has no specified
return value.
Other than that it looks good to me, thanks!
--
Ricardo
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#43296: [PATCH] gnu: Fix gnome-builder build.
2020-09-09 19:04 bug#43296: Gnome Builder doesn't install Marinus Savoritias
2020-09-10 16:58 ` bug#43296: bug#43269: " Leo Prikler
@ 2020-09-10 18:26 ` Leo Prikler
2020-10-31 16:56 ` Leo Famulari
1 sibling, 1 reply; 7+ messages in thread
From: Leo Prikler @ 2020-09-10 18:26 UTC (permalink / raw)
To: 43296
As reported in #43296, gnome-builder tries to be linked against the static
version of libselinux (propagated through glib/gio), failing to do so, as it
also wants to be a PIE. To keep the PIE, link it against the dynamic library.
* gnu/packages/gnome.scm (gnome-builder)[#:phases]: Add 'fix-ninja.
---
gnu/packages/gnome.scm | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 31c5b0319c..bc8e28becf 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -11336,6 +11336,13 @@ libraries. Applications do not need to be recompiled--or even restarted.")
(string-append (assoc-ref inputs "python-pygobject")
"/lib")))
#t))
+ (add-after 'configure 'fix-ninja
+ (lambda _
+ ;; #43296: meson(?) incorrectly assumes we want to link
+ ;; this PIE against a static libselinux.
+ (substitute* "build.ninja"
+ (("libselinux\\.a") "libselinux.so"))
+ #t))
(add-before 'check 'pre-check
(lambda _
(system "Xvfb :1 &")
--
2.28.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* bug#43296: [PATCH] gnu: Fix gnome-builder build.
2020-09-10 18:26 ` bug#43296: [PATCH] " Leo Prikler
@ 2020-10-31 16:56 ` Leo Famulari
0 siblings, 0 replies; 7+ messages in thread
From: Leo Famulari @ 2020-10-31 16:56 UTC (permalink / raw)
To: Leo Prikler; +Cc: 43296-done
On Thu, Sep 10, 2020 at 08:26:10PM +0200, Leo Prikler wrote:
> As reported in #43296, gnome-builder tries to be linked against the static
> version of libselinux (propagated through glib/gio), failing to do so, as it
> also wants to be a PIE. To keep the PIE, link it against the dynamic library.
> * gnu/packages/gnome.scm (gnome-builder)[#:phases]: Add 'fix-ninja.
Thanks! I tweaked the commit message and pushed as
9c69fec08e286f7486e64c2aa3110fa34974d15d
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-31 16:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-09 19:04 bug#43296: Gnome Builder doesn't install Marinus Savoritias
2020-09-10 16:58 ` bug#43296: bug#43269: " Leo Prikler
2020-09-10 16:58 ` bug#43296: [PATCH 1/1] gnu: Fix gnome-builder build Leo Prikler
2020-09-10 18:08 ` Mark H Weaver
2020-09-10 18:23 ` Ricardo Wurmus
2020-09-10 18:26 ` bug#43296: [PATCH] " Leo Prikler
2020-10-31 16:56 ` Leo Famulari
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).