From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WJp8DpNpG2EzWQEAgWs5BA (envelope-from ) for ; Tue, 17 Aug 2021 09:47:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 6Iw/CpNpG2FFHAAA1q6Kng (envelope-from ) for ; Tue, 17 Aug 2021 07:47:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B0387241B7 for ; Tue, 17 Aug 2021 09:47:30 +0200 (CEST) Received: from localhost ([::1]:53574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFton-0000AF-NV for larch@yhetil.org; Tue, 17 Aug 2021 03:47:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFtoM-000084-EX for bug-guix@gnu.org; Tue, 17 Aug 2021 03:47:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40040) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFtoM-0004qB-5y for bug-guix@gnu.org; Tue, 17 Aug 2021 03:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mFtoM-0006IF-24 for bug-guix@gnu.org; Tue, 17 Aug 2021 03:47:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#49827: Error message for missing synopsis in opam importer Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 17 Aug 2021 07:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49827 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Alice BRENON , Sarah Morgensen Received: via spool by 49827-submit@debbugs.gnu.org id=B49827.162918640824171 (code B ref 49827); Tue, 17 Aug 2021 07:47:02 +0000 Received: (at 49827) by debbugs.gnu.org; 17 Aug 2021 07:46:48 +0000 Received: from localhost ([127.0.0.1]:51586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFto4-0006Hi-2B for submit@debbugs.gnu.org; Tue, 17 Aug 2021 03:46:48 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:45984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFtny-0006HR-EZ for 49827@debbugs.gnu.org; Tue, 17 Aug 2021 03:46:42 -0400 Received: by mail-wr1-f43.google.com with SMTP id v4so20050045wro.12 for <49827@debbugs.gnu.org>; Tue, 17 Aug 2021 00:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=6xT043pVTdJQunNKnLXoW+Gs/YGKATvQd2dIe2aYbFo=; b=MedEW2As2wajRXDJMmaBfLOcv7F+phuHlzZd7VhsA5t3d98g4RFay+s7MShe2mCth3 ns6CQYRi/UDnoolQ537rX8Z4dOoKNnfyYXwv4tJ968qWEWmTev6zXlrNTMTB2/PX33Uw 5NNbLXjqVKvfCcYQLnesRbFfYPsLN6WG1hBjhc8gHZtD6PYZS7VBQ09UsRlsuXMa/Yid ncY5lTwmAaSMgqx0oApEmdclGILri9xQZfyCKwFQKS/WUfGYy81Zo4aibHGNYPMDXT9k LzCf3MEDCiRNrQZjQKi8v5gfsDkZxduDcXu9kgOLd2kxTfp5AIpA0PUm14xzTSmmYGrb tKoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=6xT043pVTdJQunNKnLXoW+Gs/YGKATvQd2dIe2aYbFo=; b=pDAVhIKayxGkamcvSGIusxSPa/PVtLeTgmcHd7Lhx887PAOkD8JwaJsA7yYqLSZ+jB yirJli2Vn5xVd5aHLk2h3mrNsaZI8IBLqr8/y0kjE/agJAI6Ru/BZzn28zSdXYVtd5vV ohofp2RmMjBWu0bO4YXdRz3CxH2YpCAKu5J03RVrxGgvZKfp45U5a7AuPtBZ3m/d6wxN 3Lis10W9qXafQt+xSmQLEFg6qF0rRd5z+RUl0XCG9HG2/N2UT0KEmBw9BtjIpaPLHyzo ltgxznV/Y9b7L4vTFx1NBs8xjwkMvUnpcsoupTg6L1JOQw9uz1Gr+uJZAFBgiDLcZyyy J7Sw== X-Gm-Message-State: AOAM531ve/w+yii/wnz96KnMluxZYUU5cQt/zYj6zJoIxyY2kJKMTetp hGhvsjNlVzPTRCzaEPCZIZyD98NpsA/nnw== X-Google-Smtp-Source: ABdhPJzLX9FrcVbd4BeSh1m3ASD+9OJ80R/zP7nNr9usf09oVQ7YZpzdfJN4gZmHaxbTKCidiEY/yQ== X-Received: by 2002:a5d:4b49:: with SMTP id w9mr2370871wrs.242.1629186392460; Tue, 17 Aug 2021 00:46:32 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id p3sm1456792wrr.21.2021.08.17.00.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Aug 2021 00:46:32 -0700 (PDT) From: zimoun In-Reply-To: <20210811151520.61c85eaa@ens-lyon.fr> References: <20210802170115.696ac103@ens-lyon.fr> <86r1fb4pez.fsf@mgsn.dev> <20210811151520.61c85eaa@ens-lyon.fr> Date: Tue, 17 Aug 2021 09:43:10 +0200 Message-ID: <868s10pldd.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 49827@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1629186450; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=6xT043pVTdJQunNKnLXoW+Gs/YGKATvQd2dIe2aYbFo=; b=PEP62nNclQ8nst9NrXj4pRKvJyuRritFmB3hZB0RvayxexojO/Q5SOFlOyjTmyAogFRWFq 8LQKHejvB6PApEu0RCVRiWxm7Bw8+micUV7dY8MoaM5DY5qzSCDjyxHnHjDXY7+KH5TkrR VexRzQGzKhJmFW1MYU6PWU81XpnwAZzo/X7lVKPw9Ro1ASwrytCeXja09pXEH2beCygNJ3 hUdXubJwNLDpO6uq7tCl8QSHi+TjGlA6IVGFTmqaVf1by6fn3xIL4qddS3XDAt2oSswLkS OWFnQBsuLaP417HCzZcN9FuQXacckdPuWyAN2naMzlZFKrgTa0YBxFRdD58qyQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1629186450; a=rsa-sha256; cv=none; b=ARgadNgQ7XzhfGIYDTi3vadozeljlyNLtR9HxK5H2XZsnGnwBzF2ZASAokPh1dQxUBPrmC 9ylAlHQ3XG8WmmuFxt+Os9rygJIfktpPnN2iIKCpm8q4WGmwDlCqVqamz4v1R26eXQ/651 AtFJN3vEBpfc7GRfhFI5m0i+zdjGDLjjzCfU5NkUjBfLzwgXFeeGRXPJLe72qzwEAWju0I qZcTEAXfPAP7+5DXWUSPxsUobKHBQmkYGLzndEQgipBQEoVVecaMvqvG23P7o7EcOlugX8 2mPC5q8CmTjUW5hw0XGRmwlnU1K/3dctxcd5oE/+hHMpVt+8V7f6uqzEs9rrmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=MedEW2As; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=MedEW2As; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: B0387241B7 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: XX/4TE6AenPO Hi, I am back from holidays. :-) On Wed, 11 Aug 2021 at 15:15, Alice BRENON wrote: > Thanks for your answer Sarah. Simon, I don't know if you have been able > to make any progress but I wanted to make sure you had seen the patch > proposal I sent to let the opam importer work from more repositories > than the few initially defined (opam's official and three for coq): > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D49958 I have seen but not read in details. I will do. >> > The package iter is missing a "synopsis" field as can be seen on >> > https://opam.ocaml.org/packages/iter/ , which when I tried >> > >> > guix import opam iter >> > >> > yielded the following backtrace: >> > >> > Backtrace: >> > 8 (primitive-load >> > "/home/alice/.config/guix/current/bin/g=E2=80=A6") In guix/ui.scm: >> > 2185:7 7 (run-guix . _) >> > 2148:10 6 (run-guix-command _ . _) >> > In guix/scripts/import.scm: >> > 120:11 5 (guix-import . _) >> > In guix/scripts/import/opam.scm: >> > 104:23 4 (guix-import-opam . _) >> > In guix/utils.scm: >> > 752:8 3 (call-with-temporary-output-file _) >> > In guix/import/opam.scm: >> > 337:34 2 (_ _ _) >> > In srfi/srfi-1.scm: >> > 460:18 1 (fold #> > guix/import/opam.scm=E2=80=A6> =E2=80=A6) In guix/import/opam.scm: >> > 193:15 0 (_ _ _) >> > >> > guix/import/opam.scm:193:15: Throw to key `match-error' with args >> > `("match" "no matching pattern" string-pat)'. >> > >> > >> > the final error is raised l.193 of guix/import/opam.scm because >> > metadata-ref supports various types for a metadata field, but not >> > the lack of it. As discussed with Maxime Devos on the IRC channel, >> > it would be helpful to either allow the import of a package with a >> > missing field (possibly filling it in the output scheme code for >> > the imported package with some bad value requiring the user to fill >> > it and causing any build to crash until replaced properly) or at >> > least to handle that missing field with a more explicit error >> > message than the above backtrace (something like "Can't import that >> > package because it's missing such or such field").=20=20 >From my understanding, there is 2 issues: - gentle handler for error - warn for incomplete metadata With J=C3=A9r=C3=A9my (jeko), we have started to work time to time using experimental pair-programming to fix the former. Currently, each importer uses its own error mechanism and obviously incoherence between them happens; especially when =E2=80=99--recursive=E2=80=99. We are trying= to unify that. Thanks for the report of this use case. :-) Cheers, simon