From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Vong Subject: bug#37150: Erroneous uses of regex in the invokation of FIND-FILES Date: Fri, 23 Aug 2019 10:50:02 +0800 Message-ID: <861rxcioit.fsf@gmail.com> References: <864l29iki4.fsf@gmail.com> <87mug1ylg3.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:59050) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0zfM-0007rm-1C for bug-guix@gnu.org; Thu, 22 Aug 2019 22:51:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0zfK-00025W-Pw for bug-guix@gnu.org; Thu, 22 Aug 2019 22:51:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58086) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0zfK-00025O-NS for bug-guix@gnu.org; Thu, 22 Aug 2019 22:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i0zfK-0007yF-Ij for bug-guix@gnu.org; Thu, 22 Aug 2019 22:51:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:58968) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0zel-0007rY-6I for bug-guix@gnu.org; Thu, 22 Aug 2019 22:50:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0zej-0001n2-Tv for bug-guix@gnu.org; Thu, 22 Aug 2019 22:50:26 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]:45312) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0zej-0001ma-M3 for bug-guix@gnu.org; Thu, 22 Aug 2019 22:50:25 -0400 Received: by mail-pg1-x52e.google.com with SMTP id o13so4863999pgp.12 for ; Thu, 22 Aug 2019 19:50:25 -0700 (PDT) Received: from debian (42-98-181-003.static.netvigator.com. [42.98.181.3]) by smtp.gmail.com with ESMTPSA id e9sm817520pfh.155.2019.08.22.19.50.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2019 19:50:23 -0700 (PDT) List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: 37150@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello guix, Currently, there are a lot of erroneous uses of regex in the invokation of FIND-FILES. Please see the conversations below (taken from https://lists.gnu.org/archive/html/guix-devel/2019-08/msg00149.html). Mark H Weaver writes: > Hi Alex, > > Alex Vong writes: > >> I find out that there are a lof of erroneous uses of regex in the >> invokation of FIND-FILES. The correct usage should be: >> >> (find-files "." "\\.c$") >> >> Instead people write: >> >> (find-files "." ".*\\.c") >> >> which match unwanted files. >> >> For examples, in the procedure CUSTOM-GCC, the correct regex should be: >> >> "(c\\+\\+|cpp|g\\+\\+|gcov|gcc|gcc-.*)$" >> >> instead of: >> >> ".*(c\\+\\+|cpp|g\\+\\+|gcov|gcc|gcc-.*)" >> >> Please correct me if I am wrong. > > You're right. It would be good to fix these problems incrementally, as > long as the changes don't cause too many rebuilds. > > Changes to core packages will need to wait for now, since 'core-updates' > is frozen, and 'core-updates-next' should also be considered frozen, > since it will become 'core-updates' as soon as Berlin has built it out a > bit more. (The only change in 'core-updates-next' relative to > 'core-updates' is that the new bootstrap tarballs have been fixed to be > deterministic.) > > For some of these fixes, it might be best to apply them to 'staging'. > >> Right now, the erroneous use of regex in CUSTOM-GCC casues the 'bin/' >> directory of the output of gccgo, gcc-objc and gcc-objc++ to be empty. > > I'm uncertain how many rebuilds it would trigger to change 'custom-gcc', > and I don't have confidence that "guix refresh -l" is capable of giving > us a reliable answer. In the meantime, would you like to file a bug > report for this, so it's not forgotten? > > Thanks for looking into it. > > Best, > Mark =2D-=20 Stand with Hong Kong! #Eye4HK Alex https://twitter.com/freedomhkg https://twitter.com/stand_with_hk --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQQwb8uPLAHCXSnTBVZh71Au9gJS8gUCXV9UWgAKCRBh71Au9gJS 8kCUAQCllDPx3sygAoAI2qJv74Dz6fKvF9FNh+j+WfJ+p/T9UAEA9CU9RJSp/0DA SxHDGeHMcetMoj9nkgQq8AZPTrjaAgc= =fvZ/ -----END PGP SIGNATURE----- --=-=-=--