From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 4IHDNPKGO2UhbAAAG6o9tA:P1 (envelope-from ) for ; Fri, 27 Oct 2023 11:46:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 4IHDNPKGO2UhbAAAG6o9tA (envelope-from ) for ; Fri, 27 Oct 2023 11:46:27 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A14BF66A16 for ; Fri, 27 Oct 2023 11:46:26 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Ru1gUcJO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698399986; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=zFY1OJopo11OnLLRG+K0oUSaLOrpZevFoeEF/vQ/FRY=; b=cMhL733IsoiaXkQN/9jyHIUAh0vaUIU/zTW1CrpuNOqslTvlwZPsRcGxspFrElwN2ta8pJ Oy5Xgub3ngpIw2gxuMkR8bMSrNLWbKcGv4HzhFjE0ZfwD8ReBtSkYb6JGz4wD3W9VnKQa3 E3dgc0JJK3O93ovoKQi9LDbr1d8JpXPiMhRiYLiafzheK3G+pbKpt2nM9KkoVT6IVpfmze /8xOu+eJNcJZMuKlWi9U/yVw4KHTjKUT7XTVr/44jLaHgT4IvUdSan2sdrc321g511zheG LaQrpjViGiuAN/4jGJeEpVe2QhOa5m9XIN12fZrQ5BbRuBY7PlkaIc6mzDTczA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Ru1gUcJO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698399986; a=rsa-sha256; cv=none; b=G2SWgHJy8gL1KPjEnpZ5H8tTGzLasXrINkO770TvmJTRFx17NtAi4ZXg5CEjPVBYEgOkZk 11kKX0OI1LMmw6+OflUeKSgYfmOlI6NM3THjKiLxBOq34mw7usr0db5644XtwDJRORKLL4 QoXnAvz9GLA1ToDk2EtxvnFoD6klJZW1I6NY70zJj1LDNdqszvSuFYdhlDlie87ltJd2Yd q+QDl5P6JYnoT7rys0LzfcUIwHTTkqMUN6c/m8v3it2OlfKLqZ2w/W5tOYc7uyFcS+/KLd aDh/FQWSmfD80uCAbeD7C9PB4uK5zZG1panJ2JbK3yDwQwGlhZ92IP6NOL8lDA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qwJPq-0003OC-8e; Fri, 27 Oct 2023 05:46:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwJPH-0003Bb-TL for bug-guix@gnu.org; Fri, 27 Oct 2023 05:45:38 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qwJPH-0004cj-Jz for bug-guix@gnu.org; Fri, 27 Oct 2023 05:45:31 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qwJPm-00010N-SM for bug-guix@gnu.org; Fri, 27 Oct 2023 05:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#66762: emacs-ess test fails Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 27 Oct 2023 09:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66762 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Kyle Andrews , 66762@debbugs.gnu.org Received: via spool by 66762-submit@debbugs.gnu.org id=B66762.16983999363808 (code B ref 66762); Fri, 27 Oct 2023 09:46:02 +0000 Received: (at 66762) by debbugs.gnu.org; 27 Oct 2023 09:45:36 +0000 Received: from localhost ([127.0.0.1]:35107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwJPJ-0000zE-4t for submit@debbugs.gnu.org; Fri, 27 Oct 2023 05:45:36 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:39249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwJPC-0000yM-JX for 66762@debbugs.gnu.org; Fri, 27 Oct 2023 05:45:30 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40837396b1eso1588355e9.1 for <66762@debbugs.gnu.org>; Fri, 27 Oct 2023 02:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698399889; x=1699004689; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=zFY1OJopo11OnLLRG+K0oUSaLOrpZevFoeEF/vQ/FRY=; b=Ru1gUcJOu8QudctdRhuzMtyqotd5+YYAq8/BGibFv2UKHAWNcC3vhqyFZlfKTGh/ky HIM4op3T4TddjBq9pVMk8sDKktknH85M8MueGMha4MvSeJorWR8TzMjcOR/RZqmXE0c2 2qUwUVW6QyNe6+baZOslEOz6GvzifiwIH4AMAJRBET7TjRPg4JiDHWWlzB5ZCAo4ICSN 7PXcHeP0+bTvPyQX/JzzfwOO2CHmISg0WGtuWoYSbqtOMZ4YJs5xz5q2XpUjYt6s2LlA kKLSxZX2yYyXU0pLh10uVRHPhYJmzCwPxPDv/u2GZPuJaq00yAzJOQE83uT5L0YNqQBJ QScg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698399889; x=1699004689; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zFY1OJopo11OnLLRG+K0oUSaLOrpZevFoeEF/vQ/FRY=; b=EDlJc0W3RhpFDmW/ZQ31gD9yX4w6aXTmr5mw1+9kl5DF81fD0GrOxAS9VUbHrgiqAN yTYUeU41XZ79pLmbTHPPACYLtbuMowFQE8K1q4u67AJrnjmPb4C1Yho03VKaOgm8dI38 hg2T6QlYdog+WP68HuO5HL+04j4XztrTDv7uotAKCDwcN8HUWMETTog1h9+hF1QsuKCE hSuDAaRQN59lB4Uu4SlDGZIMnjGYaNIeJcL99rcYgQTNI9Ob08xbVsT3+tIWbEcCQAkD ay0Moh8/b2DZtukwQaGCCrlDvjAXauFqGONP40XeJ9stiyB273bUXJlRjv13cQ3P320J gYKg== X-Gm-Message-State: AOJu0YywNhiZAFyiUEucLNMICbbhHveLig0j+eCPS4AKWukAAgbNtfnL osIGco6Q4xaUIcDLOJ+N0RX1orXMuYA= X-Google-Smtp-Source: AGHT+IFVo3cQD4vRklMLE5ryGzVecdLXslVoTljyuRvT6V8INvV4LUsSnh37kxdjMHwJcFdKBB13Kw== X-Received: by 2002:a05:600c:418a:b0:3fe:d637:7b25 with SMTP id p10-20020a05600c418a00b003fed6377b25mr1782940wmh.0.1698399889124; Fri, 27 Oct 2023 02:44:49 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id h9-20020a05600c314900b0040849ce7116sm4667505wmo.43.2023.10.27.02.44.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 02:44:47 -0700 (PDT) From: Simon Tournier In-Reply-To: <87r0lhcsbf.fsf@posteo.net> References: <87r0lhcsbf.fsf@posteo.net> Date: Fri, 27 Oct 2023 11:22:53 +0200 Message-ID: <861qdga07m.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.90 X-Spam-Score: 2.90 X-Migadu-Queue-Id: A14BF66A16 X-Migadu-Scanner: mx10.migadu.com X-TUID: 1BT0n6e7p/2M --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, On Thu, 26 Oct 2023 at 15:17, Kyle Andrews wrote: > The emacs-ess package no longer install as of guix revision > 33f5b74. It's dependency emacs-julia-mode fails to build. > > $ guix shell --keep-failed --pure emacs emacs-julia-mode > > According to the build log, the test julia--test-end-of-defun-nested-2 > fails. Reported upstream: https://github.com/JuliaEditorSupport/julia-emacs/issues/199 It comes from a discrepancy introduced by Emacs 29; also reported: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66763 Well, I fixed the build of emacs-julia-mode. See attached. But emacs-ess is not passing. I have updated ESS to the most recent revision, added phases for skipping the tests requiring network but it still fails: --8<---------------cut here---------------start------------->8--- Ran 187 tests, 176 results as expected, 6 unexpected, 5 skipped (2023-10-27 01:12:40+0000, 17.661319 sec) 2 expected failures 6 unexpected results: FAILED ess-eval-line-test FAILED ess-eval-region-test FAILED ess-mock-remote-process FAILED ess-r-load-ESSR-github-fetch-no FAILED ess-set-working-directory-test FAILED ess-test-r-startup-directory --8<---------------cut here---------------end--------------->8--- To be continued=E2=80=A6 Cheers, simon --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-emacs-julia-mode-Exclude-failing-test-introduced.patch Content-Transfer-Encoding: quoted-printable Content-Description: p1.patch >From 5bd2f8c9b6a8065890b4ae38ec78657bcb7ef9a7 Mon Sep 17 00:00:00 2001 Message-ID: <5bd2f8c9b6a8065890b4ae38ec78657bcb7ef9a7.1698398428.git.zimon.= toutoune@gmail.com> From: Simon Tournier Date: Fri, 27 Oct 2023 01:41:26 +0200 Subject: [PATCH 1/2] gnu: emacs-julia-mode: Exclude failing test introduced= by Emacs 29. * gnu/packages/emacs-xyz.scm (emacs-julia-mode)[arguments]: Add phases befo= re check that marks the test as expected failed. Change-Id: I1da1077a7e7e077392458243b2d3cd44592ebd45 --- gnu/packages/emacs-xyz.scm | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 0bf3096216..7511a2de21 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -95,7 +95,7 @@ ;;; Copyright =C2=A9 2021 Alexey Abramov ;;; Copyright =C2=A9 2021 Xinglu Chen ;;; Copyright =C2=A9 2021, 2022 Stefan Reich=C3=B6r -;;; Copyright =C2=A9 2021, 2022 Simon Tournier +;;; Copyright =C2=A9 2021, 2022, 2023 Simon Tournier ;;; Copyright =C2=A9 2021 Eugene Klimov ;;; Copyright =C2=A9 2021 Zheng Junjie <873216071@qq.com> ;;; Copyright =C2=A9 2021 David Dashyan @@ -13550,7 +13550,17 @@ (define-public emacs-julia-mode `(#:tests? #t #:test-command '("emacs" "--batch" "-l" "julia-mode-tests.el" - "-f" "ert-run-tests-batch-and-exit"))) + "-f" "ert-run-tests-batch-and-exit") + #:phases + (modify-phases %standard-phases + (add-before 'check 'fix-test + (lambda _ + (substitute* "julia-mode-tests.el" + ;; The test started failing with Emacs 29; see + ;; + ;; and discrepancy reported . + (("julia--test-end-of-defun-nested-2.*" all) + (string-append all " :expected-result :failed\n")))))))) (home-page "https://github.com/JuliaEditorSupport/julia-emacs") (synopsis "Major mode for Julia") (description "This Emacs package provides a mode for the Julia base-commit: 6d7e181ba18d11c92409a93936025fb46b9c8171 prerequisite-patch-id: b9d5f8d81be6974fb52062c781924fb5387d4602 prerequisite-patch-id: bee3c38a1dbcf56e8c3d58891dc317d8a5901be8 prerequisite-patch-id: 08e88430d6fdc51aa4afa2891fddae9865a64a7c prerequisite-patch-id: f276d7bebe3fdcda36e27fd027fd75d1c2e6369c prerequisite-patch-id: ef6db31909314fd83b53b6e610547064a14d9551 prerequisite-patch-id: 4311408226f9b085a893bc9c32cce00611ba8401 --=20 2.41.0 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0002-gnu-emacs-julia-mode-Update-to-0.4-0.7a8c868.patch Content-Description: p2.patch >From 9b8715d29fc1543b9d624f26e8946c5a919b4946 Mon Sep 17 00:00:00 2001 Message-ID: <9b8715d29fc1543b9d624f26e8946c5a919b4946.1698398428.git.zimon.toutoune@gmail.com> In-Reply-To: <5bd2f8c9b6a8065890b4ae38ec78657bcb7ef9a7.1698398428.git.zimon.toutoune@gmail.com> References: <5bd2f8c9b6a8065890b4ae38ec78657bcb7ef9a7.1698398428.git.zimon.toutoune@gmail.com> From: Simon Tournier Date: Fri, 27 Oct 2023 01:51:18 +0200 Subject: [PATCH 2/2] gnu: emacs-julia-mode: Update to 0.4-0.7a8c868. * gnu/packages/emacs-xyz.scm (emacs-julia-mode): Update to 0.4-0.7a8c868. [arguments]: Use G-exp. Change-Id: I3d06dbe824ce989400d801118e8bca496ae4b3e2 --- gnu/packages/emacs-xyz.scm | 40 +++++++++++++++++++++----------------- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 7511a2de21..471d938910 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -13532,40 +13532,44 @@ (define-public emacs-eprime (license license:gpl3+)))) (define-public emacs-julia-mode + ;; Last release was in March 2020. + (let ((commit "7a8c868e0d3e51ba4a2c621ee22ca9599e0e4bbb") + (revision "0")) (package (name "emacs-julia-mode") - (version "0.4") + (version (git-version "0.4" revision commit)) (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/JuliaEditorSupport/julia-emacs") - (commit version))) + (commit commit))) (file-name (git-file-name name version)) (sha256 (base32 - "1w131jb9mhvyjxa0p93iwfhzidgbcs6b8i6jg79yisqb9wchik99")))) + "0xwd4kq69ray6bk8hwjxnqf7myc3mn36chc2l9jn7a0x1f8x6k10")))) (build-system emacs-build-system) (arguments - `(#:tests? #t - #:test-command '("emacs" "--batch" - "-l" "julia-mode-tests.el" - "-f" "ert-run-tests-batch-and-exit") - #:phases - (modify-phases %standard-phases - (add-before 'check 'fix-test - (lambda _ - (substitute* "julia-mode-tests.el" - ;; The test started failing with Emacs 29; see - ;; - ;; and discrepancy reported . - (("julia--test-end-of-defun-nested-2.*" all) - (string-append all " :expected-result :failed\n")))))))) + (list + #:tests? #t + #:test-command #~(list "emacs" "--batch" + "-l" "julia-mode-tests.el" + "-f" "ert-run-tests-batch-and-exit") + #:phases + #~(modify-phases %standard-phases + (add-before 'check 'fix-test + (lambda _ + (substitute* "julia-mode-tests.el" + ;; The test started failing with Emacs 29; see + ;; + ;; and discrepancy reported . + (("julia--test-end-of-defun-nested-2.*" all) + (string-append all " :expected-result :failed\n")))))))) (home-page "https://github.com/JuliaEditorSupport/julia-emacs") (synopsis "Major mode for Julia") (description "This Emacs package provides a mode for the Julia programming language.") - (license license:expat))) + (license license:expat)))) (define-public emacs-julia-repl (package -- 2.41.0 --=-=-=--