From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id Y0VrGRZ9QmDSAwAA0tVLHw (envelope-from ) for ; Fri, 05 Mar 2021 18:48:54 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YGTCFBZ9QmCYJQAAbx9fmQ (envelope-from ) for ; Fri, 05 Mar 2021 18:48:54 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 86C651ED3D for ; Fri, 5 Mar 2021 19:48:53 +0100 (CET) Received: from localhost ([::1]:42704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIFVM-0002QK-Ln for larch@yhetil.org; Fri, 05 Mar 2021 13:48:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIFMo-0006Z9-FX for bug-guix@gnu.org; Fri, 05 Mar 2021 13:40:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:52081) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIFMo-0006uJ-7k for bug-guix@gnu.org; Fri, 05 Mar 2021 13:40:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lIFMo-0000c5-4D for bug-guix@gnu.org; Fri, 05 Mar 2021 13:40:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#46580: vim-full fails to build Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 05 Mar 2021 18:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46580 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Alex Received: via spool by 46580-submit@debbugs.gnu.org id=B46580.16149695742318 (code B ref 46580); Fri, 05 Mar 2021 18:40:02 +0000 Received: (at 46580) by debbugs.gnu.org; 5 Mar 2021 18:39:34 +0000 Received: from localhost ([127.0.0.1]:35394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIFMI-0000bH-Ly for submit@debbugs.gnu.org; Fri, 05 Mar 2021 13:39:34 -0500 Received: from mail-wm1-f46.google.com ([209.85.128.46]:34547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIFMH-0000b4-1g for 46580@debbugs.gnu.org; Fri, 05 Mar 2021 13:39:29 -0500 Received: by mail-wm1-f46.google.com with SMTP id n11-20020a05600c4f8bb029010e5cf86347so1207891wmq.1 for <46580@debbugs.gnu.org>; Fri, 05 Mar 2021 10:39:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jp2ChFRJQf8u/rpbyWpB8aOuZlBz8BV52cRrxtzCyHA=; b=TCSlyZ7w9yarkwF8+Q5RkT+gs4YfJEtKD12o8RKWEcm9NFLre4837o0dL8kOqiuVbv B3agQb7nQaERYtTTFA5GD5zcx+iUou4PLBT55cPw/lmEekV5MJxMUnjQsesmjdUn1MVe oYjFIlrqebcAK6+ci6QvD3D7UMfJrYU1e/yNyyoDvVL2dDK0V8GTbAVfcjwgG3A9MHra Ks/cD78XsXW8qW3uV6fBkXhopwsspE3fUesGujcAgZkeylpPtDCazk1pqRgAvBbHaU4f WND1Dhyt8ulnicOMUTOUtwi61gccEAdh55ChV7xmw5wcHZOxTenYD5Z2oKNE5eHGc83V Ka0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jp2ChFRJQf8u/rpbyWpB8aOuZlBz8BV52cRrxtzCyHA=; b=Hh1Ma3moGfz0E6C6stZCnwwNn3t0jDtEty7tAVLTic7U8KNV5sccp2mCFAMXMEYAsU bwBN1d8VxGjaZ8RdmZmxPAnp3nRb4VMsArSy5zz/X7xklDlkYZaoIgzAjiSXxgtAfyfb WWh2Ez4W2E018cE3SBY9bqfhgF5ILQglo2e/rol2QIfrtybNLwog+bP/3zcek7lPaPsU BWgDWmGH6i91tHmlkUzKSOln4aNK172IdvmJ108WMFSSZ3aNPN0OBF6Cz3TaJJJ8Fx9c u2+kt5BqgHdrMc1KDw3LnzKpU/lXNuvNSkQ/aL2D3DcClPwEzG5CxUf3trbfakpvHq8y ZAqA== X-Gm-Message-State: AOAM532vRou62N58xf4j/REZsmzAoZnhg3RA+c0Ui/JFSRvhqurOn8Nt UKa3Py9VPCpHgiNQ24GnR5fW5xSAWqg= X-Google-Smtp-Source: ABdhPJwAbywWxPP6sOKD+OlKbg7WGoFoOLTDu0iVAxVxnxjiqy5+l0+W2wi/RJB6CC954soO/VkLyQ== X-Received: by 2002:a1c:7406:: with SMTP id p6mr10098736wmc.103.1614969128445; Fri, 05 Mar 2021 10:32:08 -0800 (PST) Received: from bioinfomeary01-Precision-7820-Tower ([193.48.40.110]) by smtp.gmail.com with ESMTPSA id n66sm5457879wmn.25.2021.03.05.10.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 10:32:07 -0800 (PST) From: zimoun References: Date: Fri, 05 Mar 2021 19:30:46 +0100 In-Reply-To: (Alex's message of "Tue, 16 Feb 2021 23:49:33 +0000") Message-ID: <85ft19sbah.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Softwafe Engineer , iyzsong@member.fsf.org, 46580@debbugs.gnu.org, John Soo , Alexandru-Sergiu Marton Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.26 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=TCSlyZ7w; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 86C651ED3D X-Spam-Score: -1.26 X-Migadu-Scanner: scn1.migadu.com X-TUID: FLo8M7EPkvZ+ --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, On mar., 16 f=C3=A9vr. 2021 at 23:49, Alex wrote: > I encountered issue recently with upgrading and (later) clean install of = vim-full. Indeed, the package is broken. The commit 988ac06ce8cf9b1760094e0e2ff23960355d07eb introduces the fix: ;; Fix test_signals.vim. https://github.com/vim/vim/issues/7402 #:make-flags (list "CFLAGS=3D-D_REENTRANT") which breaks =E2=80=9C#:make-flags '("LDFLAGS=3D-lexpat")=E2=80=9D in vim-f= ull. More specifically, the package vim-full contains duplicate #:make-flags in its argument. For instance, --8<---------------cut here---------------start------------->8--- $ guix repl GNU Guile 3.0.5 Copyright (C) 1995-2021 Free Software Foundation, Inc. Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'. This program is free software, and you are welcome to redistribute it under certain conditions; type `,show c' for details. Enter `,help' for help. scheme@(guix-user)> ,use(gnu packages vim) scheme@(guix-user)> ,pp (package-arguments vim-full) $1 =3D (#:configure-flags (list (string-append "--with-lua-prefix=3D" (assoc-ref %build-inputs "lua")) "--with-features=3Dhuge" "--enable-python3interp=3Dyes" "--enable-perlinterp=3Dyes" "--enable-rubyinterp=3Dyes" "--enable-tclinterp=3Dyes" "--enable-luainterp=3Dyes" "--enable-cscope" "--enable-sniff" "--enable-multibyte" "--enable-xim" "--disable-selinux" "--enable-gui") #:make-flags '("LDFLAGS=3D-lexpat") #:test-target "test" #:parallel-tests? #f #:make-flags (list "CFLAGS=3D-D_REENTRANT") #:phases (modify-phases (modify-phases [...] --8<---------------cut here---------------end--------------->8--- Attached a fix. Well, at least the package vim-full now builds. Since I am not a Vim user, could you confirm that with patch, the vim-full package is functional? If yes, I will submit the patch to guix-patches. However, I am not sure to understand how all the machinery works. For instance, I do not understand why: ((#:make-flags flags) `("LDFLAGS=3D-lexpat")) raises the backtrace: --8<---------------cut here---------------start------------->8--- Backtrace: In ice-9/eval.scm: 191:35 19 (_ #f) 214:21 18 (_ #f) 217:50 17 (lp (# ?)) 217:50 16 (lp (# ?)) 217:50 15 (lp (# ?)) 217:50 14 (lp (# ?)) 217:50 13 (lp (# ?)) 217:50 12 (lp (# ?)) 217:50 11 (lp (# ?)) 217:50 10 (lp (# ?)) 217:50 9 (lp (# ?)) 217:50 8 (lp (# ?)) 217:50 7 (lp (# ?)) 217:50 6 (lp (# ?)) 217:50 5 (lp (# ?)) 217:50 4 (lp (# ?)) 217:50 3 (lp (# ?)) 217:50 2 (lp (# ?)) 217:33 1 (lp (# ?)) Exception thrown while printing backtrace: In procedure frame-local-ref: Argument 2 out of range: 1 ice-9/eval.scm:217:33: In procedure lp: Wrong type to apply: "LDFLAGS=3D-lexpat" --8<---------------cut here---------------end--------------->8--- Explanations welcome. :-) Cheers, simon --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename=vim-full.patch Content-Transfer-Encoding: quoted-printable Content-Description: vim-full.patch diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm index 372d470e09..a638f05908 100644 --- a/gnu/packages/vim.scm +++ b/gnu/packages/vim.scm @@ -9,6 +9,7 @@ ;;; Copyright =C2=A9 2019 Julien Lepiller ;;; Copyright =C2=A9 2019, 2020 Jakub K=C4=85dzio=C5=82ka ;;; Copyright =C2=A9 2020 Jack Hill +;;; Copyright =C2=A9 2021 Simon Tournier ;;; ;;; This file is part of GNU Guix. ;;; @@ -216,11 +217,14 @@ with the editor vim."))) "--enable-xim" "--disable-selinux" "--enable-gui") - ;; This flag fixes the following error: - ;; .../libpython3.7m.a(pyexpat.o): undefined reference to symbol 'X= ML_FreeContentModel' - ;; .../libexpat.so.1: error adding symbols: DSO missing from comman= d line - #:make-flags '("LDFLAGS=3D-lexpat") ,@(substitute-keyword-arguments (package-arguments vim) + ;; This flag fixes the following error: + ;; .../libpython3.7m.a(pyexpat.o): undefined reference to symbo= l 'XML_FreeContentModel' + ;; .../libexpat.so.1: error adding symbols: DSO missing from co= mmand line + ((#:make-flags flags) + `(append + '("LDFLAGS=3D-lexpat") + (delete "CFLAGS=3D-D_REENTRANT" ,flags))) ; Fix . ((#:phases phases) `(modify-phases ,phases (add-before 'check 'start-xserver --=-=-=--