unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Philip Munksgaard" <philip@munksgaard.me>
To: 54760@debbugs.gnu.org
Subject: bug#54760: import: hackage: Internal libraries are not filtered out of dependency list
Date: Thu, 07 Apr 2022 10:18:15 +0200	[thread overview]
Message-ID: <842828ff-b80b-4488-aa5b-5e6189e0a607@www.fastmail.com> (raw)

The attoparsec package on hackage defines multiple internal libraries inside one package, named "attoparsec" and "attoparsec-internal", with the first depending on the latter. Importing attoparsec using `guix import hackage attoparsec` therefore yields the following erroneous package definition:

(define-public ghc-attoparsec
  (package
    (name "ghc-attoparsec")
    (version "0.14.4")
    (source
      (origin
        (method url-fetch)
        (uri (hackage-uri "attoparsec" version))
        (sha256
          (base32 "0v4yjz4qi8bwhbyavqxlhsfb1iv07v10gxi64khmsmi4hvjpycrz"))))
    (build-system haskell-build-system)
    (inputs (list ghc-scientific ghc-attoparsec-internal))
    (native-inputs
      (list ghc-quickcheck
            ghc-quickcheck-unicode
            ghc-tasty
            ghc-tasty-quickcheck
            ghc-vector))
    (arguments
      `(#:cabal-revision
        ("1" "149ihklmwnl13mmixq6iq5gzggkgqwsqrjlg2fshqwwbvbd4nn3r")))
    (home-page "https://github.com/bgamari/attoparsec")
    (synopsis "Fast combinator parsing for bytestrings and text")
    (description
      "This package provides a fast parser combinator library, aimed particularly at
dealing efficiently with network protocols and complicated text/binary file
formats.")
    (license license:bsd-3)))

Note that `ghc-attoparsec-internal` is listed as a dependency of `ghc-attoparsec`. I believe that is incorrect, and that we should filter out the internal dependencies from `inputs`, just like we filter out `ghc-attoparsec` from the list of `native-inputs`.




             reply	other threads:[~2022-04-07  8:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07  8:18 Philip Munksgaard [this message]
2022-05-22  9:37 ` bug#54760: import: hackage: Internal libraries are not filtered out of dependency list Lars-Dominik Braun
2022-06-02  9:53   ` Philip Munksgaard
2022-06-02  9:59     ` Philip Munksgaard
2022-06-02 11:31       ` Philip Munksgaard
2022-06-02 11:57         ` Lars-Dominik Braun
2022-06-02 12:47           ` Philip Munksgaard
2022-06-05  9:43             ` Lars-Dominik Braun
2022-06-06 11:30   ` Lars-Dominik Braun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=842828ff-b80b-4488-aa5b-5e6189e0a607@www.fastmail.com \
    --to=philip@munksgaard.me \
    --cc=54760@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).