From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hartmut Goebel Subject: bug#37523: Print hint if build fails due to invalid character in package source base name Date: Thu, 26 Sep 2019 18:01:40 +0200 Message-ID: <80714a9a-b70d-8810-0f1b-606b8a6b8743@crazy-compilers.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:34302) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDWDW-0003y3-Em for bug-guix@gnu.org; Thu, 26 Sep 2019 12:02:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDWDU-0003Fx-Hc for bug-guix@gnu.org; Thu, 26 Sep 2019 12:02:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35633) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iDWDS-0003DJ-MV for bug-guix@gnu.org; Thu, 26 Sep 2019 12:02:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iDWDS-0000ou-Gn for bug-guix@gnu.org; Thu, 26 Sep 2019 12:02:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:34255) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDWDF-0003uk-5u for bug-guix@gnu.org; Thu, 26 Sep 2019 12:01:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDWDD-000302-4Q for bug-guix@gnu.org; Thu, 26 Sep 2019 12:01:48 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:53985) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iDWDC-0002ss-VL for bug-guix@gnu.org; Thu, 26 Sep 2019 12:01:47 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 46fKRp0nSHz1rKJp for ; Thu, 26 Sep 2019 18:01:42 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 46fKRp0gKPz1qqkL for ; Thu, 26 Sep 2019 18:01:42 +0200 (CEST) Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id ObEvKQvkU26F for ; Thu, 26 Sep 2019 18:01:41 +0200 (CEST) Received: from hermia.goebel-consult.de (ppp-188-174-55-104.dynamic.mnet-online.de [188.174.55.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for ; Thu, 26 Sep 2019 18:01:41 +0200 (CEST) Received: from thisbe.goebel-consult.de (hermia.goebel-consult.de [192.168.110.7]) by hermia.goebel-consult.de (Postfix) with ESMTP id 6A81E60084 for ; Thu, 26 Sep 2019 18:04:24 +0200 (CEST) Content-Language: en-US List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: 37523@debbugs.gnu.org Followup to : guix shall print a hint if building fails due to the package source base name containing a character invalid in a store filename (e.g. "@" or "%")= . Currently, when building such a package, one gets an error message like: guix build: error: invalid character `@' in name `kde-l10n-ca@valencia-14.11.80.tar.xz.drv' guix build should catch this error and print a hint like: You may add a =E2=80=98file-name=E2=80=99 field to the package source to = work around this. Ludovic Court=C3=A8s wrote on Sun Sep 08 22:07:10+0200 2019 > Unfortunately it cannot really be caught. I mean, you could catch > =E2=80=98&store-protocol-error=E2=80=99 error conditions, but then the = error message is > just a string, there=E2=80=99s no error code you can compare against. Example package raising this error: (use-modules (guix packages) (guix download) (guix build-system gnu)) (package =C2=A0 (name "kde-l10n-ca-valencia") =C2=A0 (version "14.11.80") =C2=A0 (source =C2=A0=C2=A0 (origin =C2=A0=C2=A0=C2=A0=C2=A0 (method url-fetch) =C2=A0=C2=A0=C2=A0=C2=A0 (uri (string-append "mirror://kde//Attic/applica= tions/" =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ver= sion "/src/kde-l10n/" =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "kd= e-l10n-ca@valencia-" version ".tar.xz")) =C2=A0=C2=A0=C2=A0=C2=A0 (sha256 (base32 "1mqadassxcm0m9r1l02m5vr4bbandn48xz8gifvxmb4wiz8i8d0w")))) =C2=A0 (build-system gnu-build-system) =C2=A0 (synopsis "") (description "") (license "") (home-page "")) --=20 Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |