From mboxrd@z Thu Jan 1 00:00:00 1970 From: brettg@posteo.net Subject: bug#38261: Recent changes to emacs build system Date: Mon, 18 Nov 2019 22:34:21 +0100 Message-ID: <805ec3dde9328f427bc34126c36735d3@posteo.net> References: <848bb376e0d6e171347afe53ce79bd96@posteo.net> <421db4d1a206488fa1883e40666846c5@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:38514) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWofp-0008OG-SR for bug-guix@gnu.org; Mon, 18 Nov 2019 16:35:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWofn-0001Rh-OC for bug-guix@gnu.org; Mon, 18 Nov 2019 16:35:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37530) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWofm-0001Qa-LD for bug-guix@gnu.org; Mon, 18 Nov 2019 16:35:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iWofm-0004qL-EB for bug-guix@gnu.org; Mon, 18 Nov 2019 16:35:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:38414) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWofH-0008Np-3H for Bug-guix@gnu.org; Mon, 18 Nov 2019 16:34:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWofD-0000m6-Id for Bug-guix@gnu.org; Mon, 18 Nov 2019 16:34:31 -0500 Received: from mout01.posteo.de ([185.67.36.65]:53679) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iWofB-0000ip-RX for Bug-guix@gnu.org; Mon, 18 Nov 2019 16:34:27 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 285BF16005E for ; Mon, 18 Nov 2019 22:34:23 +0100 (CET) In-Reply-To: <421db4d1a206488fa1883e40666846c5@posteo.net> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Bug guix , Ricardo Wurmus Cc: bug-Guix On 18.11.2019 21:33, brettg@posteo.net wrote: > On 18.11.2019 21:28, brettg@posteo.net wrote: >> On 18.11.2019 20:01, brettg@posteo.net wrote: >>> Hey all, the recent changes to the emacs build system result in a few >>> broken packages like emacs-pdf-tools, or basically anything that uses >>> a phase for emacs-set-emacs-load-path. >>>=20 >>> For example, I borrowed the technique used by emacs-pdf-tools to >>> package emacs-telega, resulting in both packages failing to build: >>>=20 >>> Here is the code for emacs-telega: >>>=20 >>> https://git.sr.ht/~brettgilio/cfg/tree/master/channel/non-gnu/packages/= emacs-xyz.scm#L99 >>>=20 >>> The issue is in this phase for both emacs-pdf-tools and my channel=20 >>> package: >>>=20 >>> (add-after 'compress-documentation 'emacs-set-emacs-load-path >>> (assoc-ref emacs:%standard-phases 'set-emacs-load-path)) >>>=20 >>> Resulting in: >>>=20 >>> starting phase `emacs-set-emacs-load-path' >>> Backtrace: >>> 5 (primitive-load=20 >>> "/gnu/store/5b1p1gsvfyi4fbx4s42rhab2dns=E2=80=A6") >>> In ice-9/eval.scm: >>> 191:35 4 (_ _) >>> In ice-9/boot-9.scm: >>> 829:9 3 (catch _ _ #=20 >>> =E2=80=A6) >>> In srfi/srfi-1.scm: >>> 863:16 2 (every1 #=20 >>> =E2=80=A6) >>> In >>> /gnu/store/zmkgrvvhmrix2b1z7id6zrg9bb7qxzdl-module-import/guix/build/gn= u-build-system.scm: >>> 839:30 1 (_ _) >>> In unknown file: >>> 0 (_ #:source "/gnu/store/qw8xbmk6ryl9a2jrp0gip3yffmsdix=E2= =80=A6"=20 >>> =E2=80=A6) >>>=20 >>> ERROR: Wrong type to apply: #f >>>=20 >>> If we suspect that changes are going to be non-backwards compatible >>> could we use the news system to pass along that message? Much >>> appreciated. Thanks. >>>=20 >>> Brett Gilio >>=20 >> I applied a hotfix to the package by replacing 'set-emacs-load-path >> with 'add-source-to-load-path. I believe this fix would work for all >> other affected packages. >=20 > https://git.sr.ht/~brettgilio/cfg/commit/c24a6db9d25151c487e9db675bd74e4b= b3912173 Ricardo, just wanted to make you aware that this emacs-build-system=20 change does break your guile-studio. I discovered this because I adopted=20 some of your ideas of autoloading in the generated emacs lisp from=20 guile-studio when creating my own emacs configuration dependent on guix,=20 which resulted in progn: Wrong number of arguments: (lambda nil "Autoload Emacs packages=20 found in EMACSLOADPATH. 'Autoload' means to load the 'autoloads' files matching `guix-emacs-autoloads-regexp'." (interactive) (let* ((emacs-load-path=20 (getenv "EMACSLOADPATH")) (emacs-non-core-load-path-directories=20 (seq-filter (function (lambda (dir) (string-match-p=20 "/share/emacs/site-lisp" dir))) (split-string emacs-load-path ":")))=20 (autoloads (mapcan (function guix-emacs-find-autoloads)=20 emacs-non-core-load-path-directories))) (mapc (function (lambda (f)=20 (load f (quote noerror)))) autoloads))), 78 I'll let you know if I can find any fix for this when I get some time.=20 But just wanted to pass the message along. Brett