From: Leo Prikler <leo.prikler@student.tugraz.at>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 49168@debbugs.gnu.org
Subject: bug#49168: ‘guix import pypi’ misses package dependencies
Date: Wed, 23 Jun 2021 16:17:11 +0200 [thread overview]
Message-ID: <7da007493c9bcea075a76dc01d6e85b457c5d4e3.camel@student.tugraz.at> (raw)
In-Reply-To: <87mtrgyaxe.fsf@gnu.org>
Am Mittwoch, den 23.06.2021, 15:20 +0200 schrieb Ludovic Courtès:
> Hi,
>
> Leo Prikler <leo.prikler@student.tugraz.at> skribis:
>
> > Am Dienstag, den 22.06.2021, 14:33 +0200 schrieb Ludovic Courtès:
>
> [...]
>
> > > Actually
> > > <
> > > https://files.pythonhosted.org/packages/fe/9d/4e15b2e74044ee051b6939c1b3ff716b0106e8f72d78eab8e08212eab44c/tablib-3.0.0.tar.gz
> > > does not have a ‘requirements.txt’ file, and
> > > <
> > > https://files.pythonhosted.org/packages/16/85/078fc037b15aa1120d6a0287ec9d092d93d632ab01a0e7a3e69b4733da5e/tablib-3.0.0-py3-none-any.whl
> > > doesn’t have much metadata, so I don’t even get where were get
> > > that
> > > info.
> > It does, but it's well hidden in the src tree. I peeked into the
> > guix
> > import code to find it.
>
> Indeed. The tarball above has ‘tests/requirements.txt’:
>
> --8<---------------cut here---------------start------------->8---
> pytest
> pytest-cov
> MarkupPy
> odfpy
> openpyxl>=2.6.0
> pandas
> pyyaml
> tabulate
> xlrd
> xlwt
> --8<---------------cut here---------------end--------------->8---
>
> There are no optional dependencies in that file, though. Or were you
> looking at something else?
The importer and I are looking at something else:
--8<---------------cut here---------------start------------->8---
$ tar xfv tablib-3.0.0.tar.gz tablib-3.0.0/src/tablib.egg-
info/requires.txt | xargs cat
[all]
markuppy
odfpy
openpyxl>=2.6.0
pandas
pyyaml
tabulate
xlrd
xlwt
[cli]
tabulate
[html]
markuppy
[ods]
odfpy
[pandas]
pandas
[xls]
xlrd
xlwt
[xlsx]
openpyxl>=2.6.0
[yaml]
pyyaml
--8<---------------cut here---------------end--------------->8---
> > > As for emitting comments, the (not-so-) pretty printer written
> > > for
> > > ‘guix
> > > style’¹ could come in handy for importers and more generally in
> > > any
> > > place where we need to emit comments.
> > Indeed, I wasn't thinking about that when I wrote this reply, but I
> > see
> > what you mean. Should we strive to have such a pretty-printer in
> > Guile
> > as well or do we keep it to ourselves for now? :)
>
> Let’s nurture it in Guix and move it to Guile when it looks better.
> Likewise, we should have support for comments directly in (ice-9
> read).
Sounds good to me.
next prev parent reply other threads:[~2021-06-23 14:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 7:20 bug#49168: ‘guix import pypi’ misses package dependencies Ludovic Courtès
2021-06-22 8:34 ` Leo Prikler
2021-06-22 12:33 ` Ludovic Courtès
2021-06-22 12:37 ` Leo Prikler
2021-06-22 19:01 ` Maxim Cournoyer
2021-06-23 13:20 ` Ludovic Courtès
2021-06-23 14:17 ` Leo Prikler [this message]
2021-06-24 9:57 ` Ludovic Courtès
2021-06-24 19:04 ` Maxim Cournoyer
2021-06-25 14:51 ` Ludovic Courtès
2021-06-25 15:25 ` Leo Prikler
2021-06-25 16:39 ` Maxim Cournoyer
2021-06-28 9:39 ` Ludovic Courtès
2022-03-08 9:28 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7da007493c9bcea075a76dc01d6e85b457c5d4e3.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=49168@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).