From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EAuYHx+7vGEvOgAAgWs5BA (envelope-from ) for ; Fri, 17 Dec 2021 17:30:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id +AFKGx+7vGEwHwAA1q6Kng (envelope-from ) for ; Fri, 17 Dec 2021 16:30:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 462FB82C6 for ; Fri, 17 Dec 2021 17:30:23 +0100 (CET) Received: from localhost ([::1]:33298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myG7i-0002mR-0K for larch@yhetil.org; Fri, 17 Dec 2021 11:30:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myG7P-0002lp-Mv for bug-guix@gnu.org; Fri, 17 Dec 2021 11:30:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57195) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myG7P-00014G-Eh for bug-guix@gnu.org; Fri, 17 Dec 2021 11:30:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myG7P-00034x-6k for bug-guix@gnu.org; Fri, 17 Dec 2021 11:30:03 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#52577: =?UTF-8?Q?=E2=80=98guix_?= =?UTF-8?Q?lint=E2=80=99?= throws an ugly backtrace if the GitHub updater receives =?UTF-8?Q?=E2=80=9Crate?= limit =?UTF-8?Q?exceeded=E2=80=9D?= error Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 17 Dec 2021 16:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52577 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Xinglu Chen , 52577@debbugs.gnu.org Received: via spool by 52577-submit@debbugs.gnu.org id=B52577.163975858311766 (code B ref 52577); Fri, 17 Dec 2021 16:30:03 +0000 Received: (at 52577) by debbugs.gnu.org; 17 Dec 2021 16:29:43 +0000 Received: from localhost ([127.0.0.1]:40506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myG74-00033i-Li for submit@debbugs.gnu.org; Fri, 17 Dec 2021 11:29:42 -0500 Received: from albert.telenet-ops.be ([195.130.137.90]:37838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myG72-00033Z-87 for 52577@debbugs.gnu.org; Fri, 17 Dec 2021 11:29:41 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by albert.telenet-ops.be with bizsmtp id XUVe260144UW6Th06UVepq; Fri, 17 Dec 2021 17:29:38 +0100 Message-ID: <746d29cab94d0a8686283a896cd2f639523e9d5d.camel@telenet.be> From: Maxime Devos Date: Fri, 17 Dec 2021 16:29:35 +0000 In-Reply-To: <87bl1fjpl3.fsf@disroot.org> References: <87bl1fjpl3.fsf@disroot.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1639758578; bh=MkkN5wy2cH5uL0xmb5ApYmLoCcHhN1cflRn+C7byaxE=; h=Subject:From:To:Date:In-Reply-To:References; b=DM4drYrjmHB72Ibyxc2vbPJ5pLoXEI9x90kL/u3qAtkXl83dUTA1SHPvI7Dq3kfYS ZLAOikzTqmU1Z5mMeDiZoRimTFVaCKfeUTSv+sclpsNmBvB7RyUfxOMwF9J8Kw5Jp5 8UZKP62mk8NjdMvQDWVF2lwYexVQHKhbTOqYyo/kwBVbaFvR10jboRc1DpVmlejPUp EbEWBH8SQEkZrKrXT36d+iRgVqtHCc3L+vQu3q91Zlfj4GDah+tGuMOjsL8Ruc3tcM 8rWL0G+Z2+fNxDLbAcIJFBxwKl1kmk0cA3XId01L1XinZ5nQDX+g9SQbQRMuJDft0u h5vqsyx2bkaLw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639758623; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=MkkN5wy2cH5uL0xmb5ApYmLoCcHhN1cflRn+C7byaxE=; b=mHKbEs/MMV/1RNoM9w1959IlRbjEuGElHlRc9iVTTVhQ0HTQsFfEYKTOYL5zNIpQVjnEUu neEQtcFCC5KMDJSAu2wNs02NSTaW8FVAxSMtQZcP88m+SMYr78YIiTUt2C0aGpmc8ODMmI q1BvzYRZaWRw5w5QHAJWdLuIS0cd3DcAGXuLtqND09vaJKdLzsRcjD+pIEAvXP9xF3KMiA CLV+DL9oAsAEQ3umJZsdQthUcFolQiRf8xhIGuEAnXRMtXEoKAU8OA1G4b4nQkI/RQvb3D 9Dx/C6zAOcKA12Uj/wo23dMhqGTI9GiXgYBKW8Dw4zu6p2f53J1zvGda8eei6Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639758623; a=rsa-sha256; cv=none; b=SEYRIBSDmkkZrqiJ0XSRIKRvWMvkNYmd9Di/jz2ItnIQIQVXk7CziwVlQrubHWrz9hJJ9D 8gvI+QHtAihBhgu7er3M5dV7M95zFbsY9Rwr3VYVYg879TSMhc6nC1GV0bCRzVT2w4+gjE edUlG3Kn0gOnTa+edsnMyXeWKmdIj05Zq3Jq/fkQ6ogK/flooj81yS+xhP4eKxsj2ZCY3l HUulWUJEP42W1Qcoax1PYVm1oxlAw8MlHTvypAcsVEOT6aIOctvujkaLY0u5Z4AYW4wXrz MBTQF9D69mI5blA4Hn5cAg/C/LKTriEmvpM9120mkgPSHJogWw7iQFwKRHTxXQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=DM4drYrj; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.40 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=DM4drYrj; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 462FB82C6 X-Spam-Score: -2.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6THNHG1bHWfw Xinglu Chen schreef op vr 17-12-2021 om 15:03 [+0100]: > (guard (c ((and (http-get-error? c) >                 (string=? "rate limit exceeded" >                           (http-get-error-reason c))) >            (warning (G_ "GitHub rate limit exceeded")) >            #f)) >   (with-networking-fail-safe ...)) Shouldn't this be wrapped the other way around? Or maybe even move the http-get-error?+string=?+warning inside call-with-networking-fail-safe? If you do the latter, you'll have to check the 'uri' field of the &http-get-error to determine if it's GitHub, and not, say, SWH or the CVE database or something. Greetings, Maxime.