From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WDrUArECjGGiKwEAgWs5BA (envelope-from ) for ; Wed, 10 Nov 2021 18:34:41 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id IOgrOrACjGEZHAAAB5/wlQ (envelope-from ) for ; Wed, 10 Nov 2021 17:34:40 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1262B6091 for ; Wed, 10 Nov 2021 18:34:40 +0100 (CET) Received: from localhost ([::1]:45564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkrUc-0005K2-LU for larch@yhetil.org; Wed, 10 Nov 2021 12:34:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkrT4-0003l2-Vx for bug-guix@gnu.org; Wed, 10 Nov 2021 12:33:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mkrT4-00062u-Ny for bug-guix@gnu.org; Wed, 10 Nov 2021 12:33:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mkrT4-0002VD-CM for bug-guix@gnu.org; Wed, 10 Nov 2021 12:33:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#51731: [PATCH] gnome-tweaks fails to start on core-updates-frozen Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 10 Nov 2021 17:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51731 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Vivien Kraus , 51731@debbugs.gnu.org Received: via spool by 51731-submit@debbugs.gnu.org id=B51731.16365655659596 (code B ref 51731); Wed, 10 Nov 2021 17:33:02 +0000 Received: (at 51731) by debbugs.gnu.org; 10 Nov 2021 17:32:45 +0000 Received: from localhost ([127.0.0.1]:39111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkrSn-0002Ui-0a for submit@debbugs.gnu.org; Wed, 10 Nov 2021 12:32:45 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:38694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkrSl-0002UV-OP for 51731@debbugs.gnu.org; Wed, 10 Nov 2021 12:32:44 -0500 Received: by mail-wr1-f67.google.com with SMTP id u18so5358049wrg.5 for <51731@debbugs.gnu.org>; Wed, 10 Nov 2021 09:32:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=3SsksaCUa0oRUZ5/H9ZIFeS/eoerEarM1r2D0inoLr4=; b=hvxHxlK9yPdlhbAjlYkO5I3tfpoXTQ+tCfj6Z6Lfu/kRulAWL7W2ykyJiDwJsB636O wIgnBPoIhqCVgtZFgiZbd2mixGxwyunmLLfrIa8meWEe3YcriNHzEANDCJ4dnGFWmCLp X+sAEb4olGJfEjk1Qyi9lfIRqR+8cpSPPXGl75KQGU0eSyWDoxrg0v2KJb9iEaN0hyML 59+b3ho55xnWSjjmKKQhBPqi/FkfQk3RzVesOKcNRMb8bWSnLQS0N1mthcOfj7J3p8ft 7B0sUJcAyZJ/5IxHNU64LKElTBybfsov5KvtqlrojLds2dm0GL0q/3YPkQfFe7MWwcZB AnKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=3SsksaCUa0oRUZ5/H9ZIFeS/eoerEarM1r2D0inoLr4=; b=Q5dyPEbdBQUy1adjp0i79atvoOhaEEB+2XceLw12diWEXwpR7mDN+3y+/b5F4uU38L cAywJ02qvKGiWiLD8sccTUHjWghYYz70fUNMDdbZSiQoK7jL1SCxMW1tFZbhWljXWBCK AcKqHpJyN8JTr0cBJviqaPilkG3pTQOEJUOOlorgIj7zxagC04y0SkFQIAda1eWL6Rte je1YcQ5Zk9jNWQgYyj1kJ4dwlMIudGhJPCtNoNKvEcyycibBRdrTu/hLOnhZ8hJcYba6 ZxwVHxoqnxBfpRuA/UBtrdLbtsrQ2c1WHY7lyZB9lKL1r0wgm5COVLbYXhlUrF/5aCPE zRiA== X-Gm-Message-State: AOAM532bPJSNLXUw6RuPqZZRKaRDZq0tsV1y244S+fzs+Apqga/0JHkB FwnhuCehfQAY7e0hyxeQkuY= X-Google-Smtp-Source: ABdhPJwYVAetdlUFqLbrpSOO6jhFPS8BR5Wx6VnAToHyd1vCcw7Mmtj6T9muaS37JFAUdlkmlLkGSQ== X-Received: by 2002:a5d:6785:: with SMTP id v5mr893498wru.380.1636565557526; Wed, 10 Nov 2021 09:32:37 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id p13sm6723227wmi.0.2021.11.10.09.32.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Nov 2021 09:32:37 -0800 (PST) Message-ID: <73796631dd1dd39a638c948ca3273f5cd3423b88.camel@gmail.com> From: Liliana Marie Prikler Date: Wed, 10 Nov 2021 18:32:35 +0100 In-Reply-To: <87pmr9x6vu.fsf@planete-kraus.eu> References: <87pmr9x6vu.fsf@planete-kraus.eu> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636565680; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3SsksaCUa0oRUZ5/H9ZIFeS/eoerEarM1r2D0inoLr4=; b=IsXtHsLlrLOYTyCKUgjwcJcKBkiBie1E0VaJJU4IISFXkLwOX/z/T9E+x8jk1nivLn2YpN 3orFGPuvYgbB4P6BvuaJIE3Ke+qBGvyHcvbD02X8qLI5TQfE1SPh+YA3miLtx81MAJODl5 5b2Y5cjIFR7mPma5DPMFUzBYB274gFVo4VCI6utmA/EtENgHea7f127hN6k/p3BCXcPilh qiYm4suAU7tw0SKZ0mszjo4Hs9s56LpTUjY0qSXnh52H+ZCr32vWMQ0p9NHijZBpCVXMjh bfsgqfJJmFQHi2kSCiBN0lWvzUOoWg5aY6DZ3JULsB9GbvfC/M9J3/KQRkqlFg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636565680; a=rsa-sha256; cv=none; b=pmdxz1Y7Pqf0kSvror2FPWvYp5ztFttJKPD6gP6CDW+8/PLReLf+qZUWOarCpd6SmRKxyz ERbz895g2nPnwXVanGQMYFr9t4bSmj3xUqcbrwFtH1HBlV0OtqBUZjIh9jbABM0BK0zpuZ HVuoKgswKHw+qm81/0fe5hvpAG8PFnJMZ2NM0PbbNRo5g0II+KuDxfGyOlYmokOZyplpvb 7huaLFa8OziRi0hh8tAEw5NpnwzaXPVCK04dpAJPXqsgk2BGUIYfG+E8KXsOxCiSATMGjY 6mqhCtH6wysxqh5tNExZUh8t0LZULxr2TpzZSh9KDeZYpaYVx+y+cGk8zAdWJQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=hvxHxlK9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.72 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=hvxHxlK9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 1262B6091 X-Spam-Score: -1.72 X-Migadu-Scanner: scn1.migadu.com X-TUID: fER0s1NK0LIP Hi, Am Dienstag, den 09.11.2021, 23:10 +0000 schrieb Vivien Kraus: > I fixed a couple of linter errors, and applied guix style to > it. However, now the linter complains that we have the "bin" output > of glib in something that would be called "glib" and not "glib:bin"… > Should we still keep the styled output? IIUC that's an issue with the linter or perhaps the implementation of short input lists in general. I've CC'd Ludo as he is the one who allowed us to write inputs (list bash sed ...) in the first place, perhaps he knows what to do here. We probably ought to convert this to short-style inputs anyway. > Subject: [PATCH 1/5] gnu: gnome-tweaks: Use libhandy 1. Note, libhandy 0.0 only exists on master (and therefore core-updates), because there are packages still using it. If there's no more users post updating gnome-tweaks, it is to be removed! > Subject: [PATCH 2/5] gnu: gnome-tweaks: Set the python path. Nice catch, I think this was previously done by a different phase. However... > gnu/packages/gnome.scm (gnome-tweaks)[phases]: Also wrap with > GUIX_PYTHONPATH. Please note the phase and perhaps change its name to reflect what it does. > Subject: [PATCH 3/5] gnu: gnome-tweaks: gobject-introspection should > be a native input. I'm not sure this is the correct move here. Python uses GI at runtime, not natively during build. If gnome-tweaks requires GI at build time, it's to be added as both inputs. > Subject: [PATCH 4/5] gnu: gnome-tweaks: Add bash-minimal as an input > to wrap the program. Split the long line. Also perhaps add a comment in the file itself as to why this is needed if it's not already obvious from best practises in core-updates-frozen. > Subject: [PATCH 5/5] gnu: gnome-tweaks: Style it. This should probably done first, particularly if it helps avoid the linter complaints you encounter. In my personal opinion, 1, 3, 4 and 5 could also be done in a single commit, though YMMV. Also, I'm not active on core-updates-frozen, so take everything I said as lexical analysis at best and with sufficient amounts of salt. Cheers, Liliana