From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cEcZOfT2NmLGTAEAgWs5BA (envelope-from ) for ; Sun, 20 Mar 2022 10:42:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id OJuCMfT2NmJjRwEAG6o9tA (envelope-from ) for ; Sun, 20 Mar 2022 10:42:12 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 70EF716EA5 for ; Sun, 20 Mar 2022 10:42:12 +0100 (CET) Received: from localhost ([::1]:59724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVs4h-00041C-JN for larch@yhetil.org; Sun, 20 Mar 2022 05:42:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVs4Y-000413-OP for bug-guix@gnu.org; Sun, 20 Mar 2022 05:42:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38938) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVs4Y-0007we-G0 for bug-guix@gnu.org; Sun, 20 Mar 2022 05:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVs4Y-0007ok-8n for bug-guix@gnu.org; Sun, 20 Mar 2022 05:42:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 20 Mar 2022 09:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50329 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Roman Scherer Received: via spool by 50329-submit@debbugs.gnu.org id=B50329.164776928630001 (code B ref 50329); Sun, 20 Mar 2022 09:42:02 +0000 Received: (at 50329) by debbugs.gnu.org; 20 Mar 2022 09:41:26 +0000 Received: from localhost ([127.0.0.1]:32835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVs3x-0007np-Rs for submit@debbugs.gnu.org; Sun, 20 Mar 2022 05:41:26 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:44500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVs3v-0007nf-EG for 50329@debbugs.gnu.org; Sun, 20 Mar 2022 05:41:24 -0400 Received: from [192.168.100.254] ([188.189.51.251]) by albert.telenet-ops.be with bizsmtp id 8ZhL2700K5RBSi406ZhM3h; Sun, 20 Mar 2022 10:41:21 +0100 Message-ID: <7333ababd7753976b6165d1ce8d538586089015c.camel@telenet.be> From: Maxime Devos Date: Sun, 20 Mar 2022 10:41:11 +0100 In-Reply-To: <87wngp6l7n.fsf@burningswell.com> References: <87fsnevtxi.fsf@burningswell.com> <8c532497fcfb965b7c60e93b3bbd8082b3acddf4.camel@telenet.be> <87wngp6l7n.fsf@burningswell.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-7WLmZvicCJSBOy9rR4yF" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647769281; bh=z+v1V69u3DlUeUnxzruU6s3oDTAw/iW1p7xtFJCG5K0=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=mPxArpAKZkXyLmeUOpNgtCuOhnH8cRfTCPmrik+Mu5rgjiVqLTu0sZyEGD77gsSXQ w0eTzaOtLag6og54jg7ql4QZlYIZ+dmy+FGbIjDqYTnuMjLVrsBj61VUY0NgRzyZ+W KeP3p66Rzz5LWdObOQpltDSIHgnkO/Wd9FMYEL6nrBXcGsmfSF54oy1A0qgY66kV1P qHbvVp3lP4/zBDxLyPgaLbCRuuPI/NoD+x3VExzhbHW/6Q4FIpC/5C4QFlVEfPs8Gm TLFdybN+9gCz7w2apL6RjQqNb+oQOzR5HXgUB70BoyZmvlft4vteLnH02q9M+qssxJ OqpUZRiPyqN3g== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 50329@debbugs.gnu.org, Nicolas Goaziou Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647769332; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=z+v1V69u3DlUeUnxzruU6s3oDTAw/iW1p7xtFJCG5K0=; b=CObLgmR6zbFXokCyrPBJuvl1xstMgJWi2dtjb5klYhLtG0wg2jp9ODK+jU94kEQbx9TKiX LBPFRhIQdDBsferSBxe9s2f+IoHJF5qKgHh450nxDqYxUYHSQU8lr6dW0LLzxRaThc4jdP qNfb179vWXYMjfuJoIqeOwOzXD87AqkRT3R6e+J7gvzbuXr002/MRMrvUrFNWBmOo+n5lj rwDUQ6j8grK+55Jdb46IsSY8TkVIA/Hz/yyIabgajDFBGpiMMrH0z3WiSz5b5Uno8oVy6G Rk+kNT2gfWwwAVh9vMDELm/W8Ztjakiax5b8hd9i2OYWM1btc5tEORfYaq2M/w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647769332; a=rsa-sha256; cv=none; b=qYaOoFtZQ0W5AmQdnom7DlAYJKyi1FCVgIYFVzNhTM125fdH6ma7sKFNC84k5aetwyHio+ 9ADJERMqK6Y+xov9Phcn3P+c8JIYUSo7Z4t3LIhHy3ArixlKgxx8OPxoQT3lR0SX/KUtA6 44NfyQjU4ew4Mz9qOxxfZUIb3wxoT5hS9LhcHFq6y7TpDy2PC+9c/rC8TSGv1FcQpjxO/r 6kF1BeDy/lcKXJbP2QTfjempveijTpA+aEHFdO/tAPFRK9WmgvDLoz2m6PYRXCPAlrFE3p 9+iuPO0fJqCFTYmJKJ20jnFnBSlQYUbkWDgbWkIY4EzD2vZ7kfJq9KrxOgYMtA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=mPxArpAK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=mPxArpAK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 70EF716EA5 X-Spam-Score: 3.17 X-Migadu-Scanner: scn0.migadu.com X-TUID: P+r6NstKpZEA --=-7WLmZvicCJSBOy9rR4yF Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Roman Scherer schreef op zo 20-03-2022 om 09:59 [+0100]: > Since the icons are not installed on a Guix system right now, I think > we can leave the Guix emacs-lsp-treemacs packages as it is for now. >=20 > Once upstream has added the licenses for the icons, we could take > another look and maybe only install the ones that we are allowed to > include. >=20 > What do you think? Even though they are not currently installed, I would still remove them from the 'source', as per (guix)Software Freedom: > Some otherwise free upstream package sources contain a small and > optional subset that violates the above guidelines, for instance > because this subset is itself non-free code. When that happens, > the offending items are removed with appropriate patches or code > snippets in the =E2=80=98origin=E2=80=99 form of the package (*note Defin= ing > Packages::). This way, =E2=80=98guix build --source=E2=80=99 returns the= =E2=80=9Cfreed=E2=80=9D > source rather than the unmodified upstream source. That's about code, not icons, but the same principles apply I'd think. (Though for some reason, the FSDG makes an exception for things like images in the section =E2=80=98Non-functional Data=E2=80=99?) (In this case, the idea icons are likely to be non-free, the netbeans=20 and eclipse icons are presumabl non-free.) Even if the =E2=80=98Non-Functional Data=E2=80=99 exception is followed, I = think the source should still remove things that do not seem to follow the licensing requirements (*) (and hence, might be illegal to redistribute), to avoid nasty surprises for users doing "guix build -- sources=3Dtransitive foo bar ...". (*) TBC, I am not accusing emacs-lsp-treemacs of violating license terms. Rather, it is not clear to me that it does _not_ violate licensing terms, and I'd like any potential licensing concerns to be investigated (and corrected, if necessary) before including the icons in Guix. Greetings, Maxime. --=-7WLmZvicCJSBOy9rR4yF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjb2txccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7qSHAQC61MvlbdQhvdlWBcZm0RYxTH55 Z47hibYVkMqRcKLMxwD+LvplV1WakArFw3qC4VIFapWUi0bP+R3F+JyWUyRsNQs= =Wrae -----END PGP SIGNATURE----- --=-7WLmZvicCJSBOy9rR4yF--