From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +P/rBzJOhmGg9wAAgWs5BA (envelope-from ) for ; Sat, 06 Nov 2021 10:43:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id CGemAzJOhmFvXgAA1q6Kng (envelope-from ) for ; Sat, 06 Nov 2021 09:43:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D5DC62C3BD for ; Sat, 6 Nov 2021 10:43:13 +0100 (CET) Received: from localhost ([::1]:33738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjIEC-0001si-NR for larch@yhetil.org; Sat, 06 Nov 2021 05:43:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjIE2-0001sK-Rt for bug-guix@gnu.org; Sat, 06 Nov 2021 05:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36890) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjIE2-0000lE-It for bug-guix@gnu.org; Sat, 06 Nov 2021 05:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjIE2-0004pt-CK for bug-guix@gnu.org; Sat, 06 Nov 2021 05:43:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#51559: [PATCH v2] gnu: webkit: Disable SSE2 when not on x86_64. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 06 Nov 2021 09:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51559 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver , 51559@debbugs.gnu.org Received: via spool by 51559-submit@debbugs.gnu.org id=B51559.163619175518552 (code B ref 51559); Sat, 06 Nov 2021 09:43:02 +0000 Received: (at 51559) by debbugs.gnu.org; 6 Nov 2021 09:42:35 +0000 Received: from localhost ([127.0.0.1]:48436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjIDb-0004pA-35 for submit@debbugs.gnu.org; Sat, 06 Nov 2021 05:42:35 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:37554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjIDY-0004ou-U9 for 51559@debbugs.gnu.org; Sat, 06 Nov 2021 05:42:33 -0400 Received: by mail-wm1-f68.google.com with SMTP id y84-20020a1c7d57000000b00330cb84834fso11291825wmc.2 for <51559@debbugs.gnu.org>; Sat, 06 Nov 2021 02:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=zZGJgmX9sU4n1na3JOAVNklQ70E6PZ2T4LxBKXwoDA8=; b=QBtSkGDVb6QijKRXSOyYU68zkdc8BZxn2ehwEW2yp9UcCzFeQBQ3rRTuEXuHZsu+xC oCLNEQZUQLSZbxfFPazAK2IOFjLQFO/GV6IljVYAYjBDYmaYY1EFmsTueDCrXKjGlEV5 GGdNlWD8ouwljo6d3zEYYhjpO1ckqeZysI8TNERj6pKa3UEvlbGsmU9w0TOz2tkG4xFz GwWNaKhwg0IU8BSMslgw+d/TDTTHVJrCWuSKO7mxUVQNWW1q3Nk/HKuWR1oz+4DN9+VT 42IQ3CbDQNqpbo5QHXBYu84ReEzCRfmCsTtaZ65eG6iqs6MWyQrCgK9VrAu8bFoXs9wC BXqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=zZGJgmX9sU4n1na3JOAVNklQ70E6PZ2T4LxBKXwoDA8=; b=mjPHnlWImMTgE6p7IiACpF0RkxAA1QIS3ak7xo6KwEqF4knL6IDKs0uxr5rBjxfY3E SCXpR9RfX0kG+PRTXhvMBXH5E/J6879x1qYn38iQqC8Ic91x2of6Et8Q9Sfdeh7zLvL4 rTeOupUHEkbXLuOKlI5lhYJj286KSCPKT76319Wlpyys219vz0qdKkA9Mgzzg3EUxxAu jdmTcLspYwNkCi+nj3DeAIz1suRk88/k9RKh0P4F7WFNyiMAC82l5Vhbi+mvavviBr8+ chuGQlNsoH0OrnRxh6F+FSxYFDAmFUk6nZJ7+Fbi6Ld13QLb9pBcjhwI4ElVk6J7z+oR dSNA== X-Gm-Message-State: AOAM530Yg+/f3kDvFSokNX9Ro4U/EugBuRmzUQjdn8EVRM4L79wxQ7nU oSgpGXki1++tfUGD1ipVzok= X-Google-Smtp-Source: ABdhPJwhaDkwSV1wJfwVNLdkxR1YAjiAb5t4ElL+vgruaA2PNGOHZo6ztcdM0l4bqcXsK5tddC8pBw== X-Received: by 2002:a7b:cd90:: with SMTP id y16mr37576256wmj.84.1636191747081; Sat, 06 Nov 2021 02:42:27 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id g2sm9903696wrq.62.2021.11.06.02.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Nov 2021 02:42:26 -0700 (PDT) Message-ID: <724a90ec38c498f0110b1fc810dd3da3cd9d1e8f.camel@gmail.com> From: Liliana Marie Prikler Date: Sat, 06 Nov 2021 10:42:25 +0100 In-Reply-To: <877ddlu0gs.fsf@netris.org> References: <5a2e4473e11fef78539f75a86f4cda9c105c44be.camel@gmail.com> <877ddlu0gs.fsf@netris.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: maxim.cournoyer@gmail.com Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636191793; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=zZGJgmX9sU4n1na3JOAVNklQ70E6PZ2T4LxBKXwoDA8=; b=YzYa9zcgvTl01fx4yol3M5OSqskfiDA83kwiE0X6PKnhbXZJLpJlq43aMlznffA55TR2ZV 9rvEKk/FgprIR7I1MfK7cz1KN8VxQz7DjTySL+GLJMaj0YZIxXJcnQgNxae+Ht1Ualiihb yaOZCtMizGEsILMiOh0v1U4qg6npYcfzPw54A9GBUA0sFpBzFsyXErAZq9TkOCl/WjjBt3 0EGz/x+/ORFghLaCSx9l09xDvIb9q8Ql5JCPn99BbQLbE3Y7zwtULJP49nLSA3iGqFfl7r Ho0ZFZ5uRlBqQRbtnu9f2hJIrxe9yvPVcDuZb4w6gaJL8ExSxw1Oa5sWrotsmw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636191793; a=rsa-sha256; cv=none; b=BnP3drCZis+uhwQLXJf0BSMkgLXaAYSfeELGH4lNXP3Yd2iSBB7nsY7slsQc5IgPNq4cOq GYQpXsW3+wHCpy4zBPazI9BLtVVBia0K+bvaykC6VpQkfRlwIpfT6eilwUZOlQ1UqvwsWX G7olJFcd8ZqJN4BqYqeMCj2jtWXNVm155E1KnnkItF1U9qUDa510yTzc+m1/UELjUTWSLH sR6KV91JTAOGDCLWO1C921z7JJXOY9yPYt/2BVBEuotzys4ubdAOP1AwPtFigUnLgXDhnA P71mlIMdPpeaOiP0+BGbj3NNV+mTPXsVKy07I1VeuwEHoM4EQa8j6u3xBdbFQA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=QBtSkGDV; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=QBtSkGDV; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: D5DC62C3BD X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: F5q8hgbZgFGU Hi, Am Samstag, den 06.11.2021, 04:55 -0400 schrieb Mark H Weaver: > Hi Liliana, > > I have one more comment: > > Liliana Marie Prikler writes: > > @@ -241,7 +241,7 @@ (define-public webkitgtk > > (build-system cmake-build-system) > > (outputs '("out" "doc")) > > (arguments > > - '(#:tests? #f ; no tests > > + `(#:tests? #f ; no tests > > #:build-type "Release" ; turn off debugging symbols to save > > space > > #:configure-flags (list > > "-DPORT=GTK" > > You'll need to remove this hunk in order to apply this to 'master', > since I've already made the change above in commit > 4fd12fb00d595b6f6a5d5cc734863f4c4bc5f46c. git pull did that automatically (I love rebasing pulls). > > @@ -295,6 +295,13 @@ (define-public webkitgtk > > (("libWPEBackend-fdo-([\\.0-9]+)\\.so" all > > version) > > (string-append wpebackend-fdo "/lib/" all))) > > #t))) > > + ,@(if (string-prefix? "x68_64" (or (%current-target- > > system) > > + (%current-system))) > > + '() > > + '((add-after 'unpack 'disable-sse2 > > + (lambda _ > > + (substitute* "Source/cmake/DetectSSE2.cmake" > > + (("CHECK_FOR_SSE2\\(\\)") "")))))) > > As a general recommendation, it would be preferable to add the phase > only on the systems that need it (32-bit x86), instead of adding it > on every system except x86_64. The code above will force rebuilds on > every system other than x86_64, whereas if the test was done as I > suggested, rebuilds would only happen on 32-bit x86 systems. I chose this variant, because x86_64 is the only architecture in which we allow sse2 as of right now. Better be safe than allowing for a potential "i786" in the future :P > However, in this particular case it hardly matters, since our libsoup > package currently fails to build on any system that's not x86-based. That sounds awful. Is there a related bug? I've pushed my patch with the spelling error corrected. This is the last webkitgtk-related issue for now, right? Thanks, Liliana