From mboxrd@z Thu Jan  1 00:00:00 1970
From: Brett Gilio <brettg@posteo.net>
Subject: bug#38524: [PATCH] services: dhcp-client: Ignore interfaces that need
 non-free firmware.
Date: Sat, 14 Dec 2019 04:39:33 +0000 (UTC)
Message-ID: <6d2807a3-a796-4c14-b24d-515f3c7fbe52@localhost>
References: <20191213215608.19193-1-brice@waegenei.re>
 <20191213215608.19193-2-brice@waegenei.re>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:56668)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ifzDo-00035o-78
 for bug-guix@gnu.org; Fri, 13 Dec 2019 23:40:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ifzDn-0007Lb-5p
 for bug-guix@gnu.org; Fri, 13 Dec 2019 23:40:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:57123)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ifzDm-0007Jl-Hd
 for bug-guix@gnu.org; Fri, 13 Dec 2019 23:40:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ifzDm-00079L-EV
 for bug-guix@gnu.org; Fri, 13 Dec 2019 23:40:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.38524.B38524.157629839727463@debbugs.gnu.org>
In-Reply-To: <20191213215608.19193-2-brice@waegenei.re>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 38524@debbugs.gnu.org


This LGTM, though I'd add a comment noting this bug report or something so it is known why this behavior was adjusted.

Dec 13, 2019 3:57:14 PM Brice Waegeneire <brice@waegenei.re>:

> * gnu/services/networking.scm (dhcp-client-service-type): Filter interfaces
> that need non-free firmware.
> ---
> gnu/services/networking.scm | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
> index 93d9b6a15e..7a57e33974 100644
> --- a/gnu/services/networking.scm
> +++ b/gnu/services/networking.scm
> @@ -223,14 +223,14 @@ fe80::1%lo0 apps.facebook.com\n")
> (define valid?
> (lambda (interface)
> (and (arp-network-interface? interface)
> - (not (loopback-network-interface? interface)))))
> + (not (loopback-network-interface? interface))
> + ;; XXX: Make sure the interfaces are up so that
> + ;; 'dhclient' can actually send/receive over them.
> + (false-if-exception
> + (set-network-interface-up interface)))))
> (define ifaces
> (filter valid? (all-network-interface-names)))
> 
> - ;; XXX: Make sure the interfaces are up so that 'dhclient' can
> - ;; actually send/receive over them.
> - (for-each set-network-interface-up ifaces)
> -
> (false-if-exception (delete-file #$pid-file))
> (let ((pid (fork+exec-command
> (cons* #$dhclient "-nw"
> -- 
> 2.19.2
>