unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Andy Tai <lichengtai@gmail.com>, 52591@debbugs.gnu.org
Subject: bug#52591: downloading from software archives as default even if version is wrong
Date: Fri, 17 Dec 2021 23:58:20 +0000	[thread overview]
Message-ID: <6c18852ca39e53a40cf6cdf0f3c661354d762907.camel@telenet.be> (raw)
In-Reply-To: <CAJsg1E8UPfxuyErnP_32H0Qr71+eeJsvFNLRWZotw=uTFdDJsg@mail.gmail.com>

Andy Tai schreef op vr 17-12-2021 om 15:40 [-0800]:
> @@ -38,7 +38,7 @@ (define-module (gnu packages mono)
>  (define-public mono
>    (package
>      (name "mono")
> -    (version "4.4.1.0")
> +    (version "4.8.1")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append
> --end of patch--

You forgot to update the sha256 hash. You can use
"guix download https://the-website/mono-4.8.1.tar.bz2" to determine the
hash. Or toggle a single character & look at the hash mismatch line.

Does that work for you?

[...]
> as seen above, somehow the old version was downloaded from a cached
> copy at softwareheritage archives, and it proceeds to build.   This
> should not proceed but fail for wrong checksum.

SWH isn't a cache, its an archive that keeps everything forever.

Guix has no way to determine if upstream is doing unspeakable things to
their tarballs (*) and hence needs to use SWH, or if someone forgot to
change the hash on guix. This has been noticed in the past, without
any ideas on how to somehow teach guix to determine the case.

(*) e.g. in-place modification, which changes the hash

Greetings,
Maxime.





  reply	other threads:[~2021-12-17 23:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17 23:40 bug#52591: downloading from software archives as default even if version is wrong Andy Tai
2021-12-17 23:58 ` Maxime Devos [this message]
2021-12-18  0:06   ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2021-12-18  0:23     ` Andy Tai
2021-12-18  1:51       ` Leo Famulari
2021-12-18  1:57         ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2021-12-18  0:06 ` Leo Famulari
2021-12-18  0:07 ` raingloom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c18852ca39e53a40cf6cdf0f3c661354d762907.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=52591@debbugs.gnu.org \
    --cc=lichengtai@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).