From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id UO8gMYVUJGXdWwEAG6o9tA:P1 (envelope-from ) for ; Mon, 09 Oct 2023 21:29:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UO8gMYVUJGXdWwEAG6o9tA (envelope-from ) for ; Mon, 09 Oct 2023 21:29:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7E1206E1A1 for ; Mon, 9 Oct 2023 21:29:09 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Dzo3Uuzt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696879749; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=8ZDcq76cx6A4PJLeyDp5ifPa8i8QGuKz9+dtYtWPtvI=; b=cKxtF5HH109EKJzt9BNnFkv2eeK4vYjPlki7th/yBGFmZWcnOqqskAslS+ZjfcWHNJ3S58 gE9+njbLxBORwmfVXWAwRxcdI/RHT5CvaiRmOPzMTEZhZQyWfpIFxgn7J+H1gfRwen9/0F cRyaW9wZ/DaxrtKMDSqaTQogbu/kaZzXBO0NRXquCBVwMPgF8IB5p4EwIj4DNe83isCBNT s9pENAAtqYnaakyTrd8d/cnRJ9pOY3Szckv/LraJaFcKOOOK+5wUc0ujMUgvdIDx+3PiRS xG01muSw81spNJRHDmAktJCVWNQyJoP7jGXHaK/d9MR6DdsJHUMUqfRAqtAJbA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696879749; a=rsa-sha256; cv=none; b=MvsHAFj7trShaw1qrqO7B4t270tNi7yYLGPDvNXzIrs8vjawhsZF1oVsVB3qewxkxNyLuk YZccGv7Rtrr9twPK2veXGWguj9D4C/4KKCKhfZWAx2Sxtw9a4Umgc71cQfsisfzeFar3X/ RI6MIm0jZOsIy9PnoFrkVp5dT9Bt2W0LUA8r/JuyHOpccy3Z6mBrfohs6tYRdGk6RYYlYt nFLLV9KCh5WcJMTk2fsZn774VZLlfBN5zpbEYfYjPDb5BkoGi3+jq9wXC99c24FKLEbQnT hfrI4bEzX14Pivb2caSClV4AOTheeQAz6aBIWFvb1eI/oimi1VkQTxf/kPFc0g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Dzo3Uuzt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qpvw3-0005BB-87; Mon, 09 Oct 2023 15:28:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpvvn-0005A8-8s for bug-guix@gnu.org; Mon, 09 Oct 2023 15:28:46 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qpvvl-000078-TD for bug-guix@gnu.org; Mon, 09 Oct 2023 15:28:43 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qpvw6-0000sc-Ds for bug-guix@gnu.org; Mon, 09 Oct 2023 15:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#65924: git searches coreutils and util-linux commands in PATH Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 09 Oct 2023 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65924 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: 65924@debbugs.gnu.org Received: via spool by 65924-submit@debbugs.gnu.org id=B65924.16968797353365 (code B ref 65924); Mon, 09 Oct 2023 19:29:02 +0000 Received: (at 65924) by debbugs.gnu.org; 9 Oct 2023 19:28:55 +0000 Received: from localhost ([127.0.0.1]:33209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpvvy-0000sC-MQ for submit@debbugs.gnu.org; Mon, 09 Oct 2023 15:28:54 -0400 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]:56658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpvvw-0000rw-VQ for 65924@debbugs.gnu.org; Mon, 09 Oct 2023 15:28:53 -0400 Received: by mail-ej1-x641.google.com with SMTP id a640c23a62f3a-9b974955474so831435866b.1 for <65924@debbugs.gnu.org>; Mon, 09 Oct 2023 12:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696879706; x=1697484506; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=8ZDcq76cx6A4PJLeyDp5ifPa8i8QGuKz9+dtYtWPtvI=; b=Dzo3Uuztw+etHAAiC2fCN1i8HsC11/hjJ2jKps+c0vX+bCy/wpVH5sTNBkYfF6sWye XYiimo3/guw7ooO6LgnuYfbH4EfrVwxreVzxNO0NBsKE3lH3HAtRDXcbxaqmf6w85Src XWaFp6+A4TJ14vZOP6htuXKaVbXSJHu2SF2DMvnV7dh7wQiGB54BT25y1AqQH8XL3uGC 2/KnhtYRmwem4P3rXbhxl3FvCUJ1MQHE64O9zag2GvA6A7DRDJCQDn3Joe1bFWKa/5lW Cku3c1grHJ2LRpvxEdXJKh7vgJW5WezZvYtsqpQKcFuE4Y3FO9ZFhkciPT1sJ7FKwItJ keMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696879706; x=1697484506; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8ZDcq76cx6A4PJLeyDp5ifPa8i8QGuKz9+dtYtWPtvI=; b=kIuXiNPbEVv2tdySgFPgosfTvQc9XZQ9yotWsiaQxkidYQ+93B0r23wljmWTApGqKE IOmMJh44c+S7ZPcJGNpL4gGh4IjLVCPvxcmGnVkGmQ27AkhgCXVqXfk9XMqMjwItgsNv dKOMTECg6hjOctHpB+ovBBRSvntxjAP04qse9sbS1d7lmlr9po9R3UVLJeDaGiLmaxvm ptaVWH1BU5wJCj56eOrIh4gpLe8qeQ9lCIpcxs3FJt3wFd0Xg6AG6WL+hva1lBuW3Jxs 5oSn+EJrQTVy4J1Y2h13ImZoz2Ns13ylSDLO/0nplJordIvK0RUec0OQDd4fRXEVFpoT OtyQ== X-Gm-Message-State: AOJu0YyuKMyUh0q66oqIpdiL3GwXEBMtcJWg2fI0CuZY/KxRKK1SzyUv FGtakCuDn9nLnK1D/5+l3DY= X-Google-Smtp-Source: AGHT+IGrjZEioo85N73KcDF0O0NBY5BrBWLhMpfMbd7l+Y+9zm9fFVrlKYYtt/AIyax4rqi9koTPnw== X-Received: by 2002:a17:906:30cc:b0:9a1:c447:3c62 with SMTP id b12-20020a17090630cc00b009a1c4473c62mr14222421ejb.49.1696879706084; Mon, 09 Oct 2023 12:28:26 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id gh18-20020a170906e09200b009786c8249d6sm7211402ejb.175.2023.10.09.12.28.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 12:28:25 -0700 (PDT) Message-ID: <6ab66bf2dda6a5a0c8db6192a367452c2782e1ee.camel@gmail.com> From: Liliana Marie Prikler Date: Mon, 09 Oct 2023 21:28:24 +0200 In-Reply-To: <8734yja98e.fsf@gmail.com> References: <9f9ecf37a04d6a3d788d247d8fb46f7bd6fabad5.1696734901.git.maxim.cournoyer@gmail.com> <442bb34f6ba81b7134c6cbf06d0045debc42bf68.camel@gmail.com> <87il7fdggi.fsf_-_@gmail.com> <1a219a891192b526d3e28fea8ce350c0fd5e3b53.camel@gmail.com> <87pm1nac8d.fsf@gmail.com> <8734yja98e.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -4.84 X-Spam-Score: -4.84 X-Migadu-Queue-Id: 7E1206E1A1 X-TUID: k6dNokfIXKOz Am Montag, dem 09.10.2023 um 15:25 -0400 schrieb Maxim Cournoyer: > Hi Liliana, >=20 > Liliana Marie Prikler writes: >=20 > > Am Montag, dem 09.10.2023 um 14:21 -0400 schrieb Maxim Cournoyer: > > > Hello, > > >=20 > > > Liliana Marie Prikler writes: > > >=20 > > > > [...] > > > > If you need me to reduce it to four letters, yes, LGTM. > > >=20 > > > Explicit is better than implicit.=C2=A0 I've been thinking to documen= t > > > this in our contributing section; e.g. a reviewed commit must > > > have the 'LGTM' from the reviewer.=C2=A0 If a series is LGTM, it need= s > > > to be implicitly mentioned with 'this series LGTM'.=C2=A0 That may > > > sound silly, but I think it'd simplify reviewer/submitters > > > interactions. > > s/implicitly/explicitly/? >=20 > Explicit, indeed. >=20 > > I don't necessarily agree, but it's not a hard disagree either.=C2=A0 > > I'll try to keep that in mind at least when reviewing your patches > > to not cause confusion. >=20 > OK.=C2=A0 One place where this becomes more important is when the send- > email cc hook includes people partially to a series. A LGTM on a > single message in this case could be misinterpreted for the whole > series.=C2=A0 It's best to document the expectations and codify these > often used signals, in my opinion. I personally prefer to comment to all individual patches or use the series starter for "this series LGTM", but to recap; 1 and 2 L'd GTM (with a small caveat for 1) already and we discussed 3 in IRC, so LGTM for the series. Cheers