unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: John Kehayias via Bug reports for GNU Guix <bug-guix@gnu.org>
To: "55443@debbugs.gnu.org" <55443@debbugs.gnu.org>
Subject: bug#55443: [PATCH] gnu: emacs: Fix source snippet.
Date: Wed, 22 Jun 2022 01:53:55 +0000	[thread overview]
Message-ID: <66NagbOIcNT8BqSgaUkgbTgCNH0mfajA1yX3hV3ldCj1tVkUpENd30FfkNhpBxnvqO1uK82E0MLb_3mNM3QdVhji0AwE9gvLllrhNTC0NsY=@protonmail.com> (raw)
In-Reply-To: <87tu9q6lg6.fsf@remworks.net>

[-- Attachment #1: Type: text/plain, Size: 695 bytes --]

Hello,

I believe this bug is due to a change in emacs to where the tramp-default-remote-path was moved from tramp-sh.el to tramp.el: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=695f6792f1524a446d276bf5c5e53bbb4c200909

Due to this the source snippet in emacs that adds guix paths did not work, as you should see by examining the variable: C-h v tramp-remote-path

I've tested this patch builds, sets tramp-remote-path, and alleviates the sudo problem I also experienced (for local tramp). Please test if this fixes it for you. And maybe someone can relay this to the guix-devel thread mentioned in case there is more to be done as per the discussion there.

Thanks,
John


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-emacs-Fix-source-snippet.patch --]
[-- Type: text/x-patch; name=0001-gnu-emacs-Fix-source-snippet.patch, Size: 1171 bytes --]

From 9cf58b23bc169e173c363a8c9107caa90d2a8f71 Mon Sep 17 00:00:00 2001
From: John Kehayias <john.kehayias@protonmail.com>
Date: Tue, 21 Jun 2022 21:22:26 -0400
Subject: [PATCH] gnu: emacs: Fix source snippet.

Fixes <https://issues.guix.gnu.org/55443>.

* gnu/packages/emacs.scm (emacs)[source](snippet): Patch tramp.el rather than
tramp-sh.el as the code to be patched moved.
---
 gnu/packages/emacs.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 31b5c04324..0de4b7a5d5 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -106,7 +106,7 @@ (define-public emacs
                   ;; Make sure Tramp looks for binaries in the right places on
                   ;; remote Guix System machines, where 'getconf PATH' returns
                   ;; something bogus.
-                  (substitute* "net/tramp-sh.el"
+                  (substitute* "net/tramp.el"
                     ;; Patch the line after "(defcustom tramp-remote-path".
                     (("\\(tramp-default-remote-path")
                      (format #f "(tramp-default-remote-path ~s ~s ~s ~s "
-- 
2.36.1


  parent reply	other threads:[~2022-06-22  1:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16  6:27 bug#55443: emacs-28.1: tramp sudo broken Remco van 't Veer
2022-05-19 12:46 ` benoit
2022-05-19 13:57 ` Josselin Poiret via Bug reports for GNU Guix
2022-05-19 14:55   ` Remco van 't Veer
2022-06-22  1:53 ` John Kehayias via Bug reports for GNU Guix [this message]
2022-06-22 14:41   ` bug#55443: [PATCH] gnu: emacs: Fix source snippet John Kehayias via Bug reports for GNU Guix
2022-06-22 19:47   ` Liliana Marie Prikler
2022-06-22 20:06     ` John Kehayias via Bug reports for GNU Guix
2022-06-23  5:26       ` Liliana Marie Prikler
     [not found] ` <handler.55443.D55443.165592726026934.notifdone@debbugs.gnu.org>
2022-06-25 14:57   ` bug#55443: closed (Re: [PATCH] gnu: emacs: Fix source snippet.) Remco van 't Veer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='66NagbOIcNT8BqSgaUkgbTgCNH0mfajA1yX3hV3ldCj1tVkUpENd30FfkNhpBxnvqO1uK82E0MLb_3mNM3QdVhji0AwE9gvLllrhNTC0NsY=@protonmail.com' \
    --to=bug-guix@gnu.org \
    --cc=55443@debbugs.gnu.org \
    --cc=john.kehayias@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).