unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Dariqq <dariqq@posteo.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 73903@debbugs.gnu.org
Subject: bug#73903: [shepherd]: Guix Home's shepherd masks shutdown/reboot on foreign distribution
Date: Tue, 26 Nov 2024 18:49:01 +0000	[thread overview]
Message-ID: <6054002f-17fb-4a5d-832d-30392aac396a@posteo.net> (raw)
In-Reply-To: <87bjy2at2h.fsf@gnu.org>

Hi,

On 26.11.24 16:55, Ludovic Courtès wrote:
> Hi,
> 
> Dariqq <dariqq@posteo.net> skribis:
> 
>>
>> How should this work? should this be a (public?) procedure? Should it
>> rebuild shepherd or just copy the output with trivial-build-system?
> 
> My understanding of this proposal is that there would be a
> “shepherd-foreign” package, which is like “shepherd” but without
> ‘reboot’ and ‘halt’.
> 
> That package could be implemented with ‘trivial-build-system’ or
> ‘copy-build-system’ indeed, and it would symlink all of ‘shepherd’,
> except its ‘sbin’ directory.
> 

Imo it would make sense to have the sbinless shepherd be the default 
shepherd for home-shepherd s.t. the home environment never provides 
shutdown/halt by default. Those are commands are for the system to take 
care of (whether that is the shepherd coming from root-shepherd or the 
init from the foreign system).

On my foreign distro setup i am currently using this (apologies if the 
formatting turns out weird):

--8<---------------cut here---------------start------------->8---
(define shepherd-for-home
   (package
    (inherit shepherd)
    (name "shepherd-for-home")
    (source #f)
    (build-system trivial-build-system)
    (arguments
     (list
      #:modules '((guix build union)
                  (guix build utils))
      #:builder
      #~(begin
          (use-modules (guix build union)
                       (guix build utils))
          (union-build #$output
                       (list #$(this-package-input "shepherd"))
                       #:create-all-directories? #t)
          (delete-file-recursively (string-append #$output "/sbin"))
          (delete-file-recursively (string-append #$output 
"/share/man/man8")))))
    (native-inputs '())
    (inputs (list shepherd))))
--8<---------------cut here---------------end--------------->8---


If we don't want to care about the manpages then the 
(#:create-all-directories? #t) can be omitted in union-build.

>> I just thought of a more elegant solution, but this would be a lot
>> harder to implement properly:
>>
>> - Move the sbin stuff into a seperate output
>> - Home shepherd service only adds the main output to the profile and
>>    shepherd-root-service both
>> - Will need adjustments some packages that currently reference
>>    shutdown/reboot ( -> lots of rebuilds because logind) and the same
>>    change for the shepherd packages in the shepherd module.
> 
> The advantage is that no extra step would be needed when using a foreign
> distro.  But yeah, it’s relatively intrusive, and not my favorite
> solution, FWIW.  Dunno.
> 


If this would be possible without rebuilding I'd really like it because 
it makes clear what part of the shepherd something depends on (service 
manager stuff vs generic init stuff) and avoids an extra package that is 
just shepherd minus sbindir. But the 3300 dependants of logind makes 
this really unattractive.

> WDYT?
> 
> Ludo’.

Dariqq





      reply	other threads:[~2024-11-26 18:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-20 10:12 bug#73903: [shepherd]: Guix Home's shepherd masks shutdown/reboot on foreign distribution Dariqq
2024-11-06 13:52 ` bug#73903: (no subject) Jakob Honal via Bug reports for GNU Guix
2024-11-10 11:51 ` bug#73903: [shepherd]: Guix Home's shepherd masks shutdown/reboot on foreign distribution Ludovic Courtès
2024-11-10 15:57   ` Dariqq
2024-11-20 10:46     ` Ludovic Courtès
2024-11-21 16:21       ` Dariqq
2024-11-26 15:55         ` Ludovic Courtès
2024-11-26 18:49           ` Dariqq [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6054002f-17fb-4a5d-832d-30392aac396a@posteo.net \
    --to=dariqq@posteo.net \
    --cc=73903@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).