From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WLsmET6W3GHAdwEAgWs5BA (envelope-from ) for ; Mon, 10 Jan 2022 21:25:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eKPMDT6W3GF9cAAAauVa8A (envelope-from ) for ; Mon, 10 Jan 2022 21:25:34 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D1DEC3CA4B for ; Mon, 10 Jan 2022 21:25:33 +0100 (CET) Received: from localhost ([::1]:47898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n71EQ-0000nW-Ne for larch@yhetil.org; Mon, 10 Jan 2022 15:25:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n71Dy-0000nF-7O for bug-guix@gnu.org; Mon, 10 Jan 2022 15:25:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60484) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n71Dx-000780-Ue for bug-guix@gnu.org; Mon, 10 Jan 2022 15:25:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n71Dx-0000QI-Rf for bug-guix@gnu.org; Mon, 10 Jan 2022 15:25:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#53127: [PATCH RFC] Turning Rust/Cargo inputs into =?UTF-8?Q?=E2=80=9Cregular=E2=80=9D?= inputs? Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 10 Jan 2022 20:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53127 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 53127-submit@debbugs.gnu.org id=B53127.16418462621572 (code B ref 53127); Mon, 10 Jan 2022 20:25:01 +0000 Received: (at 53127) by debbugs.gnu.org; 10 Jan 2022 20:24:22 +0000 Received: from localhost ([127.0.0.1]:53387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n71DJ-0000PI-L7 for submit@debbugs.gnu.org; Mon, 10 Jan 2022 15:24:21 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:42965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n71DG-0000P1-KN for 53127@debbugs.gnu.org; Mon, 10 Jan 2022 15:24:20 -0500 Received: by mail-wm1-f65.google.com with SMTP id a83-20020a1c9856000000b00344731e044bso594767wme.1 for <53127@debbugs.gnu.org>; Mon, 10 Jan 2022 12:24:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=3kZ5CN4F34N1VidVUPx8BywVew3q/YA/uh6/2QAfdpw=; b=YVitBknIGVFnsYGvbMi/yJa9zquy6PivqmfaqfPADmx+pp7YpMWdct2gt/2Xitsmld BncP2+Mw3qVuHR5b6qI63pjeY0/1xZBN9AKNLPRiBF2bBoqJfHNQMCjw2vyJUhgJ+j8p wgWQvGZbOkwSpfXKbuXEFvR6dOvP+GPlb7Fbxe4fm/kw4vbfvMdpRyzEDaPiIbBmjzwb Xm8HAd/i/dVAxTPr4Ywtj7jcg/u0oW1/udfsaTJ4A5mJqU6OfYVsmEuXLFv4OPvJWI7L U+mwEPZfFk0t591673VYC6/CVyEV3IBJQufryTG5zezgNklB1lmZ1fsIV5LKVzpZoSih HdtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=3kZ5CN4F34N1VidVUPx8BywVew3q/YA/uh6/2QAfdpw=; b=uIG5gnNon6SGFFGPdsVV2KgPZk9K/Qee3tELWTZ3d8k0n7iJhTIJi2n+dgHCwJMkwt hLF0xSNXjwra+YSyttHNK8cf17e2qLk1ZSgf1wJ1dBUiWoA0Q3THxXsNdFCCXoyKEJ9C W1xCjPRz1nanCWFQY8S4lCJiGZwGQe5Kf6KIyiVPSo+Yg7TiGo2pZrtrIxgmUK0el5b3 K6KYMGJzT7dN4q403NYTQgMd7DqkdOOWLf5RGbDaMO2LxIJ2Jh82/kEpWva+dCMnXh2U INlcKgLYze7cA/OZHasiBQWHv61EJD7iuNL8abzvrw16QQL9jABTakaCsrjawBeDK9R7 7jow== X-Gm-Message-State: AOAM531dRb8gEE/7LfzQa8Z8Cw83/J5tv5PQQsje8SEn3/myKz0QJfrv fe8VSBiIpUSPtZb99fw617M= X-Google-Smtp-Source: ABdhPJxoOYWEfo7LTLI0lFSvUhJmxyq8Zruzn4eRheYR7d8/iRT5/UsqTzTKsYKF/+l5qaHa6LJIAA== X-Received: by 2002:a05:600c:21c6:: with SMTP id x6mr4433778wmj.135.1641846252734; Mon, 10 Jan 2022 12:24:12 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id t7sm4533070wrx.48.2022.01.10.12.24.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jan 2022 12:24:12 -0800 (PST) Message-ID: <5d8fcfd860d68aa3f1173744031ff2a55a0adf28.camel@gmail.com> From: Liliana Marie Prikler Date: Mon, 10 Jan 2022 21:24:10 +0100 In-Reply-To: <87zgo4ynk4.fsf@inria.fr> References: <87sfty3yb5.fsf@inria.fr> <87zgo4ynk4.fsf@inria.fr> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 53127@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641846333; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3kZ5CN4F34N1VidVUPx8BywVew3q/YA/uh6/2QAfdpw=; b=kNBpSwodUEsZFwdTn9NZ4OXyw8TlLRUqZX7kN5lTL8RdYXXgcq9hUvuSI+9raDOobykX2C LXTKSp1Ad7TBzYE2tYQc+GiSIR+nrifDm858OGQVvHcaH/mK3nGnFPbfWxiFvGHKBt6Z/8 QMLmBHwwYJNWLT3Yx+OV23V2nNTxI4QgkNBWGkWN1GhmoBzItN35FHV4VDJV7h6bG75env YH6N05JvUqL7vlJOty4tmhqflBBLA6idmvhDcubZsydjfdgo91j6k9IjS5LeouNoyQXWYv jRs7W/yUZ93l1h0HPqG1TOPnN4H5+9M38Gq28Y00DtXgNE20GeZmlSIiEism8w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641846333; a=rsa-sha256; cv=none; b=l5KofEksYuA4qW+ayDXAvjNfvcc8Ez1ephJWYdK5UaDRQ/ge76x/Hj6BUWRoprlqwQP5mC UMxhGMAqqwj7ej7fnqX7jklsHkzbgzEB6G8QEnXOIoL218uSKS2/FwIOqsyT0F1l8y1y2F G++p6BzmBBEdfOCa1IPGBPOiS3Y0tSPj/Fmp3a8kkCvS/ZlYThSk6AeGOLXOtg4cDFb/Vu Od5sXEVSGeDZABRHc0sfOaobmWyvAcJgf0Y3OI137bH/rN4Qq4+FK8wUpA/HFmAnwIUqDE /guXqJMCAfXHp7QxS6YcTXx6q8bQATInEqwEodqIfFfj35h19cm3XQ78lh3kJA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=YVitBknI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=YVitBknI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D1DEC3CA4B X-Spam-Score: -1.01 X-Migadu-Scanner: scn1.migadu.com X-TUID: KIxRTtz542xJ Am Montag, dem 10.01.2022 um 09:58 +0100 schrieb Ludovic Courtès: > Hi! > > Liliana Marie Prikler skribis: > > > I suppose adding (package-source rust-cargo) to inputs to preserve > > the > > old meaning would not make much sense? > > No because you need transitivity (that is, you need sources of the > dependencies, too). > > > If so, what about having a source output and using (list `(,rust- > > cargo > > "source") ...)? > > AFAICS it wouldn’t help solve the problems I mentioned. Even if it held the transitive sources? The only other idea I have is somehow adapting maven-build-system's parent-poms, but I don't know how that'd look like implementation-wise. Also, with most of our Rust packages not even being built, it'd all be parent poms. > > > > > Last, the change to ‘inputs’ would introduce a few cycles at the > > > level.  Those cycles vanish when we lower to bags and > > > derivations.  However, because of these cycles, things like ‘guix > > > refresh -l’ may not work; there might be other unexpected and > > > undesired side effects. > > What about making the change incrementally, so that outer layers > > can start adopting the new style while inner layers are being > > rebootstrapped.  I also think it'd make sense to see how we could > > detect cycles through static analysis. > > Yeah, we could change things incrementally if that helps. > > However, given that ‘guix style’ can automate all the changes, I > think we could just as well change everything at once.  The good > thing is that it allows us that the strategy we choose actually works > at scale, in every case. Ahh, but what if we told ‘guix style’ to automate all the changes incrementally? In other words, we'd tell it to detect cycles in inputs and only commit those changes that it can make without creating one. That'd be similar to the new-style inputs change, which also aborts if even a single input can't be handled. > > Cheers