From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id QFMrKLMU1WV8EAEAqHPOHw:P1 (envelope-from ) for ; Tue, 20 Feb 2024 22:08:03 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id QFMrKLMU1WV8EAEAqHPOHw (envelope-from ) for ; Tue, 20 Feb 2024 22:08:03 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=Fw0rEwjr; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708463283; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=L97cUIIqbG5abmYXY5KIlwJJelxpV6uW11dMvbN0Hrw=; b=pJ24Fw1mrhI3sgGyHpppRlLpyH9uZO5tIV+oX+Bl66b17HCzDkPTprG2XzCN1JFSMaJV1R f19kDDns7QeHc7Po5GU3tdg9oCGXzZhP8b87ZWwwiY7B/H/aj8k5/XSzKCwot22GqBNgxo ZCjFbYeO+BwniPP1Z0b3rKgGh3aRhtF3CkoE4O0APRaWoW+ChvYg81UKJ8rfG2KoGqL0FG nhUluJ6AwPM6IpRE0MIEolok3o2hbsxZojMhBxqBJwwK97dZ7Z3x+MyyhCsLr18+wAEona aHw3GuG5gsCuVSjlCJIC7MAt+b8LmTJTo/I9ScvgysOLFfqWJQfO65q3O5QwRg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=Fw0rEwjr; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708463283; a=rsa-sha256; cv=none; b=SMk5HEyJmJrnut4nSmTv8SL7x2bllcOz5LqmZjzcZhBsYxh03NQyPTjdU+rTZ/Ub1OyR2y 239E7q3mdjo07EvwDFqsKcOvYLceKXesT72dDUyFpX7XuBxJAFE8FZ0oLBIeLaqosavZVM vNK6+8yuBQxKvajdbErkDv/+04lwCAYPvNq63W9l+djOQhewnIvQsSSnhQ68BBUfoyEWT/ NVtgnsn/UMCLvOUUupJEXwioUldkg89CtQbafjGusy05vVSl8LMb44pc+KgRLqshH1cfnq D2gqAGT/ZbmgK5O/3b7VDv4KF4R7XJnH4Y8Qt6O7CMZItnuSLvfnB4VWX4F0HQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7C33A53965 for ; Tue, 20 Feb 2024 22:08:03 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rcXL4-0002Tq-PJ; Tue, 20 Feb 2024 16:07:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcXL3-0002Mj-6I for bug-guix@gnu.org; Tue, 20 Feb 2024 16:07:41 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rcXL2-0007tS-Tp for bug-guix@gnu.org; Tue, 20 Feb 2024 16:07:40 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rcXLO-0004su-08; Tue, 20 Feb 2024 16:08:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#57292: [PATCH v3] gnu: gdm: Enable accessibility settings. References: <87v8qpyocr.fsf@gmail.com> In-Reply-To: <87v8qpyocr.fsf@gmail.com> Resent-From: Dariqq Original-Sender: "Debbugs-submit" Resent-CC: liliana.prikler@gmail.com, maxim.cournoyer@gmail.com, rg@raghavgururajan.name, vivien@planete-kraus.eu, bug-guix@gnu.org Resent-Date: Tue, 20 Feb 2024 21:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57292 X-GNU-PR-Package: guix X-GNU-PR-Keywords: moreinfo To: 57292@debbugs.gnu.org, 59489@debbugs.gnu.org Cc: Dariqq , Liliana Marie Prikler , Maxim Cournoyer , Raghav Gururajan , Vivien Kraus X-Debbugs-Original-Xcc: Liliana Marie Prikler , Maxim Cournoyer , Raghav Gururajan , Vivien Kraus Received: via spool by 57292-submit@debbugs.gnu.org id=B57292.170846327318755 (code B ref 57292); Tue, 20 Feb 2024 21:08:01 +0000 Received: (at 57292) by debbugs.gnu.org; 20 Feb 2024 21:07:53 +0000 Received: from localhost ([127.0.0.1]:46877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcXLF-0004sP-7q for submit@debbugs.gnu.org; Tue, 20 Feb 2024 16:07:53 -0500 Received: from mout02.posteo.de ([185.67.36.66]:43623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcXLB-0004s2-9g for 57292@debbugs.gnu.org; Tue, 20 Feb 2024 16:07:52 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 0BE4A240103 for <57292@debbugs.gnu.org>; Tue, 20 Feb 2024 22:07:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1708463241; bh=onSoXMK5jvmWMMv1snvfoB+qEYjZoeIDX8u3flZxK/Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=Fw0rEwjrVMWeBgP+O8TW0lc9T+dbJD6jBnr+PeitsGjQb0Z9rKxny+KDRJy5eUOHt JD3OO9x57i4Mkgdfm6Af0LH9mVnzUXPZlfTL4RyfSDXbVOzBSUHwvrhe8iQX6gYPup BrMAqRR5omT8GtkS2Y0R/QTshjeltjd74ZS++PTdt9praih/HlibgmRtFN5DwrYuxW Kj6YsawVLv+GcxWJ10BaHMG1LCqdFeRvid9Dmo9nhNVKMqXF0MLMNxHxtv1ubSWifv Kr+2ljeLBeSep9Mq35g9pBN/s6sMQH7q/wgWQYL0fGXhR/tkkgfnZpcq2fS4eaFd/9 E0RWGspKXsQyA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TfX6J1Dcpz6tyZ; Tue, 20 Feb 2024 22:07:19 +0100 (CET) From: Dariqq Date: Tue, 20 Feb 2024 19:58:48 +0000 Message-ID: <57ec3715a20bdaa01f66f32a61dc917b31c03553.1708459127.git.dariqq@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 4.82 X-Spam-Score: 4.82 X-Migadu-Queue-Id: 7C33A53965 X-Migadu-Scanner: mx13.migadu.com X-TUID: MxY1bkeiSpKy gdm needs the "/share" subdirectory of these packages present in XDG_DATA_DIRS such that the accessibility settings work: - at-spi2-core: contains accessibility dbus service. - dconf: To be able to change settings. - gnome-control-center: icon. * gnu/packages/gnome.scm (gdm)[inputs]: Add at-spi2-core, dconf, gnome-control-center. [phases]: Add wrap-accessibility-dependencies phase. Change-Id: Ibfe8f1aee9c8fe0c06f895de121f0f84defe4773 --- Hi everyone, Here is v3 of gdm accessibility issue which adds the wrapper phase we've been discussing. I added the extra inputs under a seperate section in the inputs. If you'd like to keep them in alphabetical order feel free to adjust this. ALso I am not sure if the format of my commit message is ok. I've tested on both master and gnome-team and it works on both. To ennable the screenreader it is enough for orca to be in the system profile (and orca working i.e. on gnome-team branch). dconf is both a native and normal input: Based on the fedora gdm.spec it seems like a build dependency however i was not able to verify this as cross-compiling (for i686-linux-gnu) requries me to bootstrap gcc. At leeast the default tests do not seem to require it. Adding gnome-control-center, which is used for the icon, pulls in python dependencies which breaks cross compiling. Maybe you have some ideas for this. Also some other thing that I notices is that because /var/lib/gdm is mounted as tmpfs this makes the changes in the gdm accessibility settings not persist through reboots which is annoying. These will get stored in /var/lib/gdm/.config/dconf/. gnu/packages/gnome.scm | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 953bd817ed..a967c9cb16 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -77,6 +77,7 @@ ;;; Copyright © 2023 Juliana Sims ;;; Copyright © 2023 Dominik Delgado Steuter ;;; Copyright © 2023 Zhu Zihao +;;; Copyright © 2024 Dariqq ;;; ;;; This file is part of GNU Guix. ;;; @@ -9007,7 +9008,18 @@ (define-public gdm (for-each (lambda (desktop) (symlink desktop (basename desktop))) (find-files - (string-append settings "/etc/xdg")))))))))) + (string-append settings "/etc/xdg"))))))) + ;; GDM needs some additional programs available via XDG_DATA_DIRS, + ;; to make accessibility settings and related services available. + (add-after 'install 'wrap-accessibility-dependencies + (lambda _ + (wrap-program (string-append #$output "/bin/gdm") + `("XDG_DATA_DIRS" ":" prefix + #$(map (lambda (input) + (file-append (this-package-input input) "/share")) + '("at-spi2-core" + "dconf" + "gnome-control-center"))))))))) (native-inputs (list `(,glib "bin") ;for glib-compile-schemas, etc. dconf @@ -9029,7 +9041,12 @@ (define-public gdm iso-codes libcanberra libgudev - linux-pam)) + linux-pam + + ;; accessibility dependencies + at-spi2-core + dconf + gnome-control-center)) (synopsis "Display manager for GNOME") (home-page "https://wiki.gnome.org/Projects/GDM/") (description base-commit: ffcce77ec488e3c89401ad77fafa65fcd9e9f5be -- 2.41.0