From: Dariqq <dariqq@posteo.net>
To: 57292@debbugs.gnu.org, 59489@debbugs.gnu.org
Cc: Dariqq <dariqq@posteo.net>,
Liliana Marie Prikler <liliana.prikler@gmail.com>,
Maxim Cournoyer <maxim.cournoyer@gmail.com>,
Raghav Gururajan <rg@raghavgururajan.name>,
Vivien Kraus <vivien@planete-kraus.eu>
Subject: bug#57292: [PATCH v3] gnu: gdm: Enable accessibility settings.
Date: Tue, 20 Feb 2024 19:58:48 +0000 [thread overview]
Message-ID: <57ec3715a20bdaa01f66f32a61dc917b31c03553.1708459127.git.dariqq@posteo.net> (raw)
In-Reply-To: <87v8qpyocr.fsf@gmail.com>
gdm needs the "/share" subdirectory of these packages present in XDG_DATA_DIRS
such that the accessibility settings work:
- at-spi2-core: contains accessibility dbus service.
- dconf: To be able to change settings.
- gnome-control-center: icon.
* gnu/packages/gnome.scm (gdm)[inputs]: Add at-spi2-core, dconf, gnome-control-center.
[phases]: Add wrap-accessibility-dependencies phase.
Change-Id: Ibfe8f1aee9c8fe0c06f895de121f0f84defe4773
---
Hi everyone,
Here is v3 of gdm accessibility issue which adds the wrapper phase we've been discussing.
I added the extra inputs under a seperate section in the inputs. If you'd like to keep them in alphabetical order feel free to adjust this.
ALso I am not sure if the format of my commit message is ok.
I've tested on both master and gnome-team and it works on both.
To ennable the screenreader it is enough for orca to be in the system profile (and orca working i.e. on gnome-team branch).
dconf is both a native and normal input: Based on the fedora gdm.spec it seems like a build dependency however i was not able to verify this as cross-compiling (for i686-linux-gnu) requries me to bootstrap gcc. At leeast the default tests do not seem to require it.
Adding gnome-control-center, which is used for the icon, pulls in python dependencies which breaks cross compiling. Maybe you have some ideas for this.
Also some other thing that I notices is that because /var/lib/gdm is mounted as tmpfs this makes the changes in the gdm accessibility settings not persist through reboots which is annoying. These will get stored in /var/lib/gdm/.config/dconf/.
gnu/packages/gnome.scm | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 953bd817ed..a967c9cb16 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -77,6 +77,7 @@
;;; Copyright © 2023 Juliana Sims <juli@incana.org>
;;; Copyright © 2023 Dominik Delgado Steuter <d@delgado.nrw>
;;; Copyright © 2023 Zhu Zihao <all_but_last@163.com>
+;;; Copyright © 2024 Dariqq <dariqq@posteo.net>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -9007,7 +9008,18 @@ (define-public gdm
(for-each (lambda (desktop)
(symlink desktop (basename desktop)))
(find-files
- (string-append settings "/etc/xdg"))))))))))
+ (string-append settings "/etc/xdg")))))))
+ ;; GDM needs some additional programs available via XDG_DATA_DIRS,
+ ;; to make accessibility settings and related services available.
+ (add-after 'install 'wrap-accessibility-dependencies
+ (lambda _
+ (wrap-program (string-append #$output "/bin/gdm")
+ `("XDG_DATA_DIRS" ":" prefix
+ #$(map (lambda (input)
+ (file-append (this-package-input input) "/share"))
+ '("at-spi2-core"
+ "dconf"
+ "gnome-control-center")))))))))
(native-inputs
(list `(,glib "bin") ;for glib-compile-schemas, etc.
dconf
@@ -9029,7 +9041,12 @@ (define-public gdm
iso-codes
libcanberra
libgudev
- linux-pam))
+ linux-pam
+
+ ;; accessibility dependencies
+ at-spi2-core
+ dconf
+ gnome-control-center))
(synopsis "Display manager for GNOME")
(home-page "https://wiki.gnome.org/Projects/GDM/")
(description
base-commit: ffcce77ec488e3c89401ad77fafa65fcd9e9f5be
--
2.41.0
next prev parent reply other threads:[~2024-02-20 21:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 2:11 bug#57292: GDM accessibility menu buttons don't do anything Maxim Cournoyer
2022-09-18 19:36 ` Liliana Marie Prikler
2024-01-16 20:49 ` bug#57292: [PATCH] services: gdm: Add packages for accessibility settings Dariqq
2024-01-20 3:12 ` bug#57292: bug#59489: gdm: Accessibility icon missing in log in screen Maxim Cournoyer
2024-01-20 17:09 ` Dariqq
2024-01-22 5:30 ` Maxim Cournoyer
2024-01-22 18:51 ` Dariqq
2024-01-16 21:09 ` bug#57292: GDM accessibility menu buttons don't do anything Dariqq
2024-01-29 21:31 ` bug#57292: [PATCH] WIP: gnu: propagate inputs for gdm and rework gdm-service-type Dariqq
2024-01-30 5:27 ` bug#59489: " Liliana Marie Prikler
2024-02-04 8:53 ` Dariqq
2024-02-04 19:26 ` Liliana Marie Prikler
2024-02-05 16:08 ` Dariqq
2024-02-05 17:55 ` Liliana Marie Prikler
2024-02-10 3:06 ` Maxim Cournoyer
2024-02-12 14:02 ` bug#59489: " Liliana Marie Prikler
2024-02-13 21:25 ` Dariqq
2024-02-16 19:10 ` bug#57292: GDM accessibility menu buttons don't do anything Maxim Cournoyer
2024-02-20 19:58 ` Dariqq [this message]
2024-02-24 6:38 ` bug#59489: [PATCH v3] gnu: gdm: Enable accessibility settings Liliana Marie Prikler
-- strict thread matches above, loose matches on Subject: below --
2022-11-22 20:36 bug#59489: gdm: Accessibility icon missing in log in screen Luis Felipe via Bug reports for GNU Guix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57ec3715a20bdaa01f66f32a61dc917b31c03553.1708459127.git.dariqq@posteo.net \
--to=dariqq@posteo.net \
--cc=57292@debbugs.gnu.org \
--cc=59489@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=maxim.cournoyer@gmail.com \
--cc=rg@raghavgururajan.name \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).