From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cENtOXNZwmHYHgAAgWs5BA (envelope-from ) for ; Tue, 21 Dec 2021 23:47:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qAI0NXNZwmFbSgAAB5/wlQ (envelope-from ) for ; Tue, 21 Dec 2021 22:47:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B2A1311B17 for ; Tue, 21 Dec 2021 23:47:15 +0100 (CET) Received: from localhost ([::1]:41000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mznuc-0002lR-Sa for larch@yhetil.org; Tue, 21 Dec 2021 17:47:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mznuR-0002fi-T1 for bug-guix@gnu.org; Tue, 21 Dec 2021 17:47:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mznuQ-000280-4P for bug-guix@gnu.org; Tue, 21 Dec 2021 17:47:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mznuQ-00084W-3U for bug-guix@gnu.org; Tue, 21 Dec 2021 17:47:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#51968: Missing dependency for Xournal++ Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 21 Dec 2021 22:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51968 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Daniel =?UTF-8?Q?Mei=C3=9Fner?= , Alexander Asteroth Received: via spool by 51968-submit@debbugs.gnu.org id=B51968.164012679330994 (code B ref 51968); Tue, 21 Dec 2021 22:47:02 +0000 Received: (at 51968) by debbugs.gnu.org; 21 Dec 2021 22:46:33 +0000 Received: from localhost ([127.0.0.1]:56086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzntx-00083q-Bl for submit@debbugs.gnu.org; Tue, 21 Dec 2021 17:46:33 -0500 Received: from xavier.telenet-ops.be ([195.130.132.52]:57746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzntu-00083g-Ps for 51968@debbugs.gnu.org; Tue, 21 Dec 2021 17:46:31 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by xavier.telenet-ops.be with bizsmtp id ZAmU2600C4UW6Th01AmUm4; Tue, 21 Dec 2021 23:46:29 +0100 Message-ID: <573f1192b63e39255ac46053a235e94a8015a7cf.camel@telenet.be> From: Maxime Devos Date: Tue, 21 Dec 2021 22:46:28 +0000 In-Reply-To: <87wnjy18um.fsf@ruhr-uni-bochum.de> References: <87fsrsijtk.fsf@ruhr-uni-bochum.de> <87k0gca8lj.fsf@gnu.org> <87a6gzv94l.fsf@ruhr-uni-bochum.de> <87czlvkxd7.fsf@h-brs.de> <875yrj5qxf.fsf@ruhr-uni-bochum.de> <87ee66e3wp.fsf@h-brs.de> <87wnjy18um.fsf@ruhr-uni-bochum.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1640126789; bh=gf43YYkpCpwGssn/SnoSJxMRFzoGZZIdVy69AtqqeqI=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Yq3jSiP2O2bDuEB+hydfCICOQiD7U+dIW/tEDriIe7ienrjBa5A/PzajUZcmi+cYX v+vCZ4xl5ZXhdXbL9GFiO8IBVAvsSciHFUY+n2BEUTzbiXdeQUeF3nUsxPPWybhdre mJq4Gff/8B8XkZmHcTsiZ2UHPsLFTbVz9nooC9RfyI9QtL8fvyQ3l++bXS8LbExT/4 mRTezNK1lMudF/RTemayUYUHhgC+5UAtHesHqyS/W8BatAVyJ9X55J0WAFiNbkc+Uk Bo3UVA4NEqa+f/Lt3eDsCopcF6D/AGJCJAx/zUuba3voficObWpSUHBdHpdOoL0qIn R6inz5OEuL8Bw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 51968@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640126835; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gf43YYkpCpwGssn/SnoSJxMRFzoGZZIdVy69AtqqeqI=; b=mCR7U6FzT5TPpe/uRpDiMq3yc7tup9QQtMit8kVeqlCQii1Rqf6d6HwVYo94EhcUDC7cLJ CIha7Ofhcmi0/n/9xOVCscMKe9Ea5ij8bJRGYAXy+5jcSa1anOdMCEPGJeZEVyDpSTUMrF P1RP/gZcSky3t9QsCmA/lARK/aqA1vDUEpIM2EGy0EMUio5rvHTVVh7hQGDGm+/0o9KL1a UUUNtTz1kZBiF1R0r8N/aCa8EX20n9X6xkvUJ9LvFXGTrUVTOyDIyuXEt2Y+5kXE8ozENK Sj8609Wg1rn/NbO8Me7/2CzHIBA/I43t019tNs5wDuC9iixinuWE9EhGWtrgtw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640126835; a=rsa-sha256; cv=none; b=OjvSW/78EaNWpgkkCExLOjS4uOmxmBGlqI2yDzddE2stQgXVGtc3kpFau7bY/ho8XBTZw6 Mqa8ZflsRcd1WVYpthrmJL/ix1usUPgiYo+CM2T5lUhHAkb5LqDivHY1aWrSiRJLZ00QCy WHs/yeD1/9nIbKGOIZbxG9j2ej2tHlLltyA2XqW7IFyJ9OrI4jtca/NDo4/9vDq7iUQPUh mDbO5bTa8KfZ9KMbL1af2NXsphJxHLhIIqzscrteOP9v0+FCj6aAR3AnixjZVcc1VklEg8 SZpLgR2JElbj3tKHE6JtEn9lBQQomnH0tdV35oyJF1b2wbL3uT3RdLfY2yWJkw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=Yq3jSiP2; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=Yq3jSiP2; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B2A1311B17 X-Spam-Score: -2.03 X-Migadu-Scanner: scn0.migadu.com X-TUID: 248LmMmYTR+E Daniel Meißner schreef op di 21-12-2021 om 12:43 [+0100]: > As you can see: among others the XDG_DATA_DIRS is set which causes > Xournal++ to find its icons.  Plus the GDK_PIXBUF_MODULE_FILE also > resolves the problem that Xournal++ cannot recognize the file format of > its application icon ‘pixmaps/com.github.xournalpp.xournalpp.svg’ which > also happens with ‘guix shell --pure -f xournalpp-fix.scm -- xournalpp’. > > These missing environment variables are probably because the package > definition does not use glib-or-gtk-build-system but cmake-build-system. > WDYT?  Maxime, can you confirm this and how should we fix this? Now I read these two paragraphs, I think what was going wrong with the modify-inputs adding gtk+: that modify-inputs only adds gtk+ to the inputs, it doesn't cause gtk+ to be added to the profile whenever xournalpp is added to the profile. For the latter, you need propagated-inputs, but that's to be avoided due to $REASONS (propagation conflicts, profile building performance, profile pollution, ...). Anyway, a wrap-program setting XDG_DATA_DIRS (and GDK_PIXBUF_MODULE_FILE?) appropriately might be sufficient here (see e.g. the package definition of gedit). Adding XDG_DATA_DIRS as a native-search-path to xournalpp might work as well, but it's a rather generic search path so I'd try to avoid that. Greetings, Maxime.