unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Chet Ramey <chet.ramey@case.edu>
To: "Ludovic Courtès" <ludo@gnu.org>, bug-bash@gnu.org
Cc: 22354@debbugs.gnu.org, chet.ramey@case.edu
Subject: bug#22354: Hash-bang line length
Date: Wed, 13 Jan 2016 11:18:38 -0500	[thread overview]
Message-ID: <569678DE.7020503__17931.8512593911$1452710382$gmane$org@case.edu> (raw)
In-Reply-To: <87lh7t7p4w.fsf@gnu.org>

On 1/13/16 5:25 AM, Ludovic Courtès wrote:
> Hello,
> 
> The ‘READ_SAMPLE_BUF’ macro in execute_cmd.c reads at most 80 bytes from
> the hash-bang line.  This is less than the already-small 128-byte limit
> in the Linux kernel¹ and can quite easily be hit².

That limit is huge compared to other Unixes, btw.

> What about changing it to 128 bytes (as well as the ‘sample’ array) to
> at least match Linux?
> 
> (It might even make sense to make it bigger so that Bash might succeed
> when the kernel simply fails.)

If the kernel returns an errno other than ENOEXEC, bash isn't going to
`succeed'.  This is entirely a cosmetic issue concerning the error message
bash prints when execve fails.

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU    chet@case.edu    http://cnswww.cns.cwru.edu/~chet/

  parent reply	other threads:[~2016-01-13 16:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87lh7t7p4w.fsf@gnu.org>
2016-01-13 13:19 ` bug#22354: Hash-bang line length Greg Wooledge
     [not found] ` <20160113131902.GU27325@eeg.ccf.org>
2016-01-13 13:52   ` Ludovic Courtès
     [not found]   ` <87y4bt60zb.fsf@gnu.org>
2016-01-13 14:04     ` Greg Wooledge
2016-01-13 16:21     ` Chet Ramey
     [not found]     ` <20160113140441.GZ27325@eeg.ccf.org>
2016-01-13 16:23       ` Chet Ramey
     [not found]       ` <56967A06.8040104@case.edu>
2016-01-13 16:39         ` Greg Wooledge
     [not found]     ` <56967976.2080908@case.edu>
2016-01-13 17:41       ` Ludovic Courtès
     [not found]       ` <87vb6x2x7u.fsf@gnu.org>
2016-01-13 20:47         ` Chet Ramey
2016-01-13 16:18 ` Chet Ramey [this message]
2016-01-12  9:14 bug#22354: Test failure when running distcheck from out-of-tree build Taylan Ulrich Bayırlı/Kammer
2016-01-13 10:25 ` bug#22354: Hash-bang line length Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='569678DE.7020503__17931.8512593911$1452710382$gmane$org@case.edu' \
    --to=chet.ramey@case.edu \
    --cc=22354@debbugs.gnu.org \
    --cc=bug-bash@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).