From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UM3yCIzu1WFiIAAAgWs5BA (envelope-from ) for ; Wed, 05 Jan 2022 20:16:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id NCyZAYzu1WHL/gAAG6o9tA (envelope-from ) for ; Wed, 05 Jan 2022 20:16:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A33052E6BF for ; Wed, 5 Jan 2022 20:16:27 +0100 (CET) Received: from localhost ([::1]:52916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5Blq-0002ks-M0 for larch@yhetil.org; Wed, 05 Jan 2022 14:16:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5BkU-0002iW-Qa for bug-guix@gnu.org; Wed, 05 Jan 2022 14:15:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5BkU-0007Xj-6l for bug-guix@gnu.org; Wed, 05 Jan 2022 14:15:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5BkU-00036K-35 for bug-guix@gnu.org; Wed, 05 Jan 2022 14:15:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#34170: bitcoin-core bundles leveldb Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 05 Jan 2022 19:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34170 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Carl Dong , zimoun Received: via spool by 34170-submit@debbugs.gnu.org id=B34170.164141005511851 (code B ref 34170); Wed, 05 Jan 2022 19:15:02 +0000 Received: (at 34170) by debbugs.gnu.org; 5 Jan 2022 19:14:15 +0000 Received: from localhost ([127.0.0.1]:41877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5Bjj-000355-Hx for submit@debbugs.gnu.org; Wed, 05 Jan 2022 14:14:15 -0500 Received: from michel.telenet-ops.be ([195.130.137.88]:59032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5Bjh-00034v-7j for 34170@debbugs.gnu.org; Wed, 05 Jan 2022 14:14:14 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by michel.telenet-ops.be with bizsmtp id f7E92600K4UW6Th067EADp; Wed, 05 Jan 2022 20:14:10 +0100 Message-ID: <563546ec57ff4726bf4138c16be6304c869119ce.camel@telenet.be> From: Maxime Devos Date: Wed, 05 Jan 2022 19:13:57 +0000 In-Reply-To: <26B84833-6F9F-4C5D-8448-715C67C16768@carldong.me> References: <20190122133124.7ca032d7@scratchpost.org> <865ys6m168.fsf@gmail.com> <86lezu8qj4.fsf@gmail.com> <26B84833-6F9F-4C5D-8448-715C67C16768@carldong.me> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-zkNV0HsANboj3EbQlwrb" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1641410050; bh=BgIkWpnkrdzXu+40o8jGCCxWOpta/z48x4D+b8Dq82I=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=GzhDKgNQ5H9IQjrrQJ7CgoJHl3F7befDyEGHd+E5+W1V+Gs/r4aDUPo+aOfIR8VOH r6QIjf8i6Hr+IadJS1O02pGgqqSjDryMfB6EXe/c6FIqRt68ra7shGSyfocggMAaJq JAzKHpbcLOkcdd5i3vQZD2aKVr+EyIG0GVNM1xdq3jBUVd8aO53rZ4jyhsSCfyMYNJ hWbZRWKAXbvnWC5ecFooDsrW7SufNe74aFoytxyCjPpOX81OnShiCC2zCPphJl/OG7 hdZQRpnqV0UyNgETwFRvqbQWO5aDFDPOUD8uId3UZWI6EmbqyqV7gW6Js9JEt9aAzi rBzJyiOfNVnqw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 34170@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641410187; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=BgIkWpnkrdzXu+40o8jGCCxWOpta/z48x4D+b8Dq82I=; b=JPM07XKUJzVV6D/CCmkL9qx9PBH3XTBYdw+2zsWp1XPe0E6b08vlkGxEqh5yrEh7acf0fh msYAwIrzCv57jpCqJnjiFV148PalxTpfg7LoRyJgINBK6B32l5uX7X5GAac+HDnN7bEo3L UvDnl3hfUKIktQYdvZAST21pavtY++W326Uqy4rzkXJWVMpBZ9GSxHChOOOZmk0Qvgw7pW 1td677JN+yRi9oHvXMmRswXx7n58z+PdIdZclSLJ5tuZC/jWtfxEMlYyiw5losKTHVgB3V EgkUo81MGfZbRRWm0Bu7dAPcHgr/Pog995hU2Q2EUzqlTFgwzk3RoxqSTBAe5w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641410187; a=rsa-sha256; cv=none; b=VB6+Z4x6EoBo3WxoHN24Qn7wKKzAyeCfsnuqjuxahsboppM56ZqD3hYUfSDPqLGPSZ9Ew0 GOlF2+C3lyKGGODdszb5wVp2gzvBOeyT8c/ZyLot26p8unD9Z0EsjBIYMK/xexYpkFdFyE uojGDXV4Q1s75Q8fqKEH5soPtCiiKwRXLcFFtYVV3BtWSsck52ciFD2Ag7gcHYAiciMom8 IHuvmlJTKkrCexcLQgXwfwzI1F/FGBjBisktkclTdoV44yxqHQa80eC2u9l6hDtYqHpMJg 41LwW9k4IeFewnrX/C9lZKr8yx4EdA9PHprNysT5vG10AUk4sN2mBQyPG/U4EA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=GzhDKgNQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.20 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=GzhDKgNQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A33052E6BF X-Spam-Score: -3.20 X-Migadu-Scanner: scn0.migadu.com X-TUID: fR4oygl45v15 --=-zkNV0HsANboj3EbQlwrb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Carl Dong schreef op wo 05-01-2022 om 12:40 [-0500]: > Simon, Maxime, Danny, >=20 > Thanks for CCing me on this message! The rationale for bundling > leveldb in Bitcoin Core goes a bit beyond convenience, it is several > things: >=20 > 1. The original reason for sub-treeing is that Bitcoin Core used to > maintain its own version of leveldb with its own fixes > here:=C2=A0https://github.com/bitcoin-core/leveldb-subtree, since then > most of these fixes have been upstreamed as > of:=C2=A0https://github.com/bitcoin/bitcoin/pull/17398 Seems reasonable to me, but the bitcoin project is upstreaming the changes it made and most are already upstream, so I would prefer to use upstream's leveldb. > 2. We also used to support using an external leveldb, however, it > seems that it was fragile to rely on external projects to maintain > ABI compatibility, see the quoted IRC bug report > here:=C2=A0https://github.com/bitcoin/bitcoin/pull/23282. Reasonable mind= s > may disagree on this point, especially coming from Guix where > patching is convenient. The quoted ABI incompatibility bitcoind fails to start with undefined symbol: _ZTIN7leveldb6LoggerE in Debian Sid after leveldb upgraded from 1.22 to 1.23: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D996486 doesn't apply in Guix, because guix uses RUNPATH and multiple library versions can exist in the same store (in different directories in the store). > In addition to the above, Bitcoin Core experienced a hard fork in > 2013 due to database incompatibilities, which has predisposed > maintainers towards a more stringent approach with pinning > dependencies and their configure/build-time flags. > See:=C2=A0https://blog.bitmex.com/bitcoins-consensus-forks/#was-the-2013- > incident-a-hardfork I doubt that Guix has sufficient Bitcoin Core users to cause a hard fork, but yes, this is an understandable reason to bundle things. But any such problem seems easy to resolve (at the guix side): we could simply temporarily switch to an older version of leveldb. If desired, it would also be possible to do something in-between unbundling and using bitcoin's leveldb: define a 'leveldb/bitcoin' variant of the 'leveldb' package (using package/inherit or (package (inherit ...) ...)), add it as input to the 'bitcoin' package and tell and/or patch bitcoin's buid scripts to use that=C2=A0leveldb. As source code, use an appropriate commit from (and add a comment to the definition of bitcoin-core to keep leveldb/bitcoin in-sync). A benefit of this approach (if done properly, with (origin (inherit ...) ...)=C2=A0such that patches of 'leveldb' are inherited) above the status quo, is that is that if for some reason 'leveldb' is patched in Guix, then 'leveldb/bitcoin' receives the patch as well. Another benefit is that the dependency 'googletest' and 'benchmark' of leveldb would remain unbundled. Greetings, Maxime. --=-zkNV0HsANboj3EbQlwrb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYdXt9RccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hu6AQDW+ScMM2tEpvFe43jOShlsOqpP dx6ANkesoO7UUd9PZwD/VNJ4E+LxegBqgypK8t/JFixNJ1YAfCgdb9wkC2XezgU= =mfVJ -----END PGP SIGNATURE----- --=-zkNV0HsANboj3EbQlwrb--