From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eelco Dolstra <eelco.dolstra@logicblox.com>
Subject: bug#18994: [PATCH] Preserve supplementary groups of build users
Date: Wed, 01 Jul 2015 14:59:29 +0200
Message-ID: <5593E431.70200__5320.25670768252$1435782567$gmane$org@logicblox.com>
References: <87ppcxsse0.fsf@gnu.org> <87vbe4w8a4.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39343)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZAJyg-000504-3v
	for bug-guix@gnu.org; Wed, 01 Jul 2015 11:31:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZAJya-0000eZ-Eq
	for bug-guix@gnu.org; Wed, 01 Jul 2015 11:31:10 -0400
Received: from debbugs.gnu.org ([140.186.70.43]:34765)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZAJya-0000e8-C3
	for bug-guix@gnu.org; Wed, 01 Jul 2015 11:31:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZAJyZ-0000wW-SL
	for bug-guix@gnu.org; Wed, 01 Jul 2015 11:31:03 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.18994.B18994.14357646123482@debbugs.gnu.org>
In-Reply-To: <87vbe4w8a4.fsf@gnu.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>, 18994@debbugs.gnu.org
Cc: nix-dev@lists.science.uu.nl

Hi Ludo,

On 01/07/15 11:12, Ludovic Courtès wrote:

>> Currently, the build environment made by the daemon does not preserve
>> supplementary groups of the build users.
>>
>> Thus, even though the standalone Guix system sets /dev/kvm 660, owned by
>> root:kvm, and adds the build users to the kvm group, build users are
>> unable to access it.
> 
> The following patch is an attempt to address this bug (see
> <http://bugs.gnu.org/18994>) by preserving the supplementary groups of
> build users in the build environment.
> 
> In practice, I would expect that supplementary groups would contain only
> one or two groups: the build users group, and possibly the “kvm” group.

Applied, thanks!

-- 
Eelco Dolstra | LogicBlox, Inc. | http://nixos.org/~eelco/