From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matt Wette <matt.wette@gmail.com>
Subject: bug#39172: SElinux guix-daemon.cil file
Date: Tue, 28 Jan 2020 05:45:38 -0800
Message-ID: <523bc412-7451-3d32-6ab5-854fab4063ff@gmail.com>
References: <b637f042-0881-ea44-eb6c-68118cca6b27@gmail.com>
 <87h80qij75.fsf@gnu.org> <87iml6wh3b.fsf@elephly.net>
 <87d0b4fu1m.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:37935)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iwRBt-0001TI-E3
 for bug-guix@gnu.org; Tue, 28 Jan 2020 08:46:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iwRBr-00064n-VC
 for bug-guix@gnu.org; Tue, 28 Jan 2020 08:46:05 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:53748)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iwRBq-00062o-Fi
 for bug-guix@gnu.org; Tue, 28 Jan 2020 08:46:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iwRBp-0008JZ-Jn
 for bug-guix@gnu.org; Tue, 28 Jan 2020 08:46:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.39172.B39172.158021914831940@debbugs.gnu.org>
In-Reply-To: <87d0b4fu1m.fsf@gnu.org>
Content-Language: en-US
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>, Ricardo Wurmus <rekado@elephly.net>
Cc: 39172@debbugs.gnu.org

On 1/27/20 1:50 PM, Ludovic Courtès wrote:
> Hello,
>
> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> Could we also do this in one expression?
>>
>>      (typeattributeset file_type (or guix_profiles_t
>>                                      guix_daemon_conf_t
>>                                      guix_daemon_exec_t
>>                                      guix_daemon_socket_t
>>                                      guix_store_content_t))
>>
>> I also think we need to declare our use of “file_type” first:
>>
>>      (typeattribute file_type)
>>
>> What do you think?
> Matt, does what Ricardo proposes work for you?
>

I can add that and see if it helps.  I am just coming up to speed on this.

There are other changes I may be proposing.
Note that use of

     (block guix_daemon
         ... guix_daemon_conf_t
     )

results in the type guix_daemon.guix_daemon_conf_t.   According to

     https://github.com/SELinuxProject/cil/wiki

the convention is something like the following, with added typealias

      (block guix
        ... daemon_conf
      )

     (typealias guix.daemon_conf guix_daemon_conf_t)