From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iE/RGsihJ2JEUAAAgWs5BA (envelope-from ) for ; Tue, 08 Mar 2022 19:34:48 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GCQQGMihJ2K9MAAA9RJhRA (envelope-from ) for ; Tue, 08 Mar 2022 19:34:48 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E80CD39084 for ; Tue, 8 Mar 2022 19:34:47 +0100 (CET) Received: from localhost ([::1]:36826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nRefV-0001Bm-Qh for larch@yhetil.org; Tue, 08 Mar 2022 13:34:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nReeo-0001Bd-GD for bug-guix@gnu.org; Tue, 08 Mar 2022 13:34:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35758) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nReeo-0005ln-8H for bug-guix@gnu.org; Tue, 08 Mar 2022 13:34:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nReeo-0000rj-5m for bug-guix@gnu.org; Tue, 08 Mar 2022 13:34:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#54292: Commit e8518c43 breaks guix pull on i686 Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 08 Mar 2022 18:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54292 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Diego Nicola Barbato , Liliana Marie Prikler Received: via spool by 54292-submit@debbugs.gnu.org id=B54292.16467643963268 (code B ref 54292); Tue, 08 Mar 2022 18:34:02 +0000 Received: (at 54292) by debbugs.gnu.org; 8 Mar 2022 18:33:16 +0000 Received: from localhost ([127.0.0.1]:57888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRee4-0000qe-18 for submit@debbugs.gnu.org; Tue, 08 Mar 2022 13:33:16 -0500 Received: from wnew2-smtp.messagingengine.com ([64.147.123.27]:53643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRee2-0000qO-11 for 54292@debbugs.gnu.org; Tue, 08 Mar 2022 13:33:15 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id D6E5A2B00289; Tue, 8 Mar 2022 13:33:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 08 Mar 2022 13:33:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= philipmcgrath.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=Vao/iJpio0DyTi 99KuIWgKTmisD/fkqMGa3pY+O1yBY=; b=saoAZIlPs/TW+J1vDscEZWfNjCpp0Y +WMPVi56v0nKPqr5tU8XLjDm7wtx3v1HACF6z2Qw1PpDim31iAgTjfxJl8CLvtTa wOasZa15lobvq2D1yz9NcnsuFtLfYKdY/nDQiKkzcgtSRVfrh01cE9HEqymn3Pxr jKgpt3Xr2ylGxHmmny+7KRu4b5Q11uDQyIudKoD7AN1UTiLk/VjLd9bSpj2M8cnj BIs90pbyZs8PbyxCdaT6V0rYUyTILhu8mm7AsyrZYL6zIic9EgNLYiwwnTmK86LR RQ/xgiiKhkvzwmFEnvd/jQ8nmJquBcjN4nLLhK16DaJAop2BOWyQ1l4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Vao/iJpio0DyTi99K uIWgKTmisD/fkqMGa3pY+O1yBY=; b=VmtPegFPOeJmNTafwciARJr8aXgHr4tRu oC+FAErH7npTUhQADi7Fnjy2UBkn+HC3Tw+CHMVhmwQoUo5eyVTumcnOVY/o+OoK PuZkp8MaR1ga4v+HOPWhvJKMBX6lrOBQXlDrqoW+X2aEvyRbkighPcz18BJWKGxR dFhiyj1CM6IL6O/X/M0XHE9D4zxCElqBE47ckSJ18VqQS/1gqxH7MA+8DDcGmYuX m/J/3kSuvKr4oY3cpdtqbOjEMpAonAAija5afifBVnVsZOHkYHekOJagD1qnzzJD 8FFUaecE/rfydz5J1mA52ip64G+H+Sm3hAxLl1HFBQt2B6UL1Cywg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudduiedgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfgggtsehgtderredttddvnecuhfhrohhmpefrhhhilhhi phcuofgtifhrrghthhcuoehphhhilhhiphesphhhihhlihhpmhgtghhrrghthhdrtghomh eqnecuggftrfgrthhtvghrnhepieeifeehueetuddtgffftdehheettdduveettdfgledu leelkefgudetjeekgffgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepphhhihhlihhpsehphhhilhhiphhmtghgrhgrthhhrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Mar 2022 13:33:06 -0500 (EST) From: Philip McGrath Date: Tue, 08 Mar 2022 13:33:00 -0500 Message-ID: <5216289.ggv9HUQsqW@bastet> In-Reply-To: References: <87sfru0w0h.fsf@GlaDOS.home> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart11751069.cHTpPW8hJg"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 54292@debbugs.gnu.org, liliana.prikler@gmail.com Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646764488; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Vao/iJpio0DyTi99KuIWgKTmisD/fkqMGa3pY+O1yBY=; b=f4F6Jcfxcs81SHDiYUnQ/iHzAEJAaJQV4uRMXcCBrqfA+hiLPCIf+C3+2Lmgi8oBQpY4vR XLzSBfKNHjm/e/aoGW5YGC5ebZ4Flc6oVRMCG8ZsvufGlhKb9fDWz2k5iJ3zimXG6/o1H+ AOFvOavQhOqV30ErO6YH0hNVlVp2DvyOGsw0GJ3R5J8btm3N3VfdHAWgAYEkj6abTs4UWy FqQKjcZ8al/EnJkbM9qRNRimnPYRhieBnYjsRJStv+x2aYK5KqYgv/9asAmcJqkRvEtfaE GcPpyXVcVJGrJ48wgPN1jjzf5ybzYeVBoR2SIGIUGi4z75FMyE38EHcM1ovBqQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646764488; a=rsa-sha256; cv=none; b=B/35INhJChSAV6rgo9fOkxnhKNujIVbMDBg54mqlwWJinxZ74cL3f13ZRtLvC/ZkJ8D6BT NXQ/Y93N/mYjpDvhz8YwktD7sP/wPmnJRyVcP5o9surYqEx7nT8Cxtzim1QmXuUwJMhi8p rpTc9bu0P4C/w3N5zP8fvl9wb9QUwQp7wGg64AfvmBBBzVTegpDG79Rikya8jdq10QFmxJ Da97cOrya5L10X9p3N1Cb2OVWLDDB5bBMF8PAc2T1yoQG3Q4iySj/noefltcXFYNvyihz+ VcTYV5gioGkjmz+xyGQlJ+iydtm+4J5EhQvp5cFyXCdlp7CbU0RlmTMc0kAjuw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=fm1 header.b=saoAZIlP; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=VmtPegFP; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.62 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=fm1 header.b=saoAZIlP; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=VmtPegFP; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E80CD39084 X-Spam-Score: -0.62 X-Migadu-Scanner: scn0.migadu.com X-TUID: s5KAUWd/HiQ0 --nextPart11751069.cHTpPW8hJg Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Philip McGrath Cc: 54292@debbugs.gnu.org, liliana.prikler@gmail.com Subject: Re: Commit e8518c43 breaks guix pull on i686 Date: Tue, 08 Mar 2022 13:33:00 -0500 Message-ID: <5216289.ggv9HUQsqW@bastet> On Tuesday, March 8, 2022 10:32:48 AM EST Liliana Marie Prikler wrote: > > The error appears to be that nix-system->chez-machine was rather poorly > coded and overlooked in review. In particular, i686 should probably > also default to the i386 case. > I must for some reason not have been thinking about the fact that Guix distinguishes among "i[3456]86" when I ported `%nix-arch-to-chez-alist` from the `raco cross` codebase. I can see (at least) two paths forward: 1. `%nix-{arch,os}-to-chez-alist` could become many-to-one rather than one-to-one. Presumably we'd use the first applicable entry when going from Chez to Nix. 2. We could give up on alists and use existing predicates from (guix utils) like `target-x86-32?`, as Liliana had already suggested during review for `chez-upstream-features-for-system`. I liked the alists because they made the bidirectional relationship obvious, but I wonder if there are other potential pitfalls analogous to this one. Maybe someone more familiar with non-x86_64 systems in Guix/Nix than I am should decide. OTOH, while it's definitely a bug that `(nix-system->chez-machine "i686-linux")` currently returns `#f`, it seems like the more immediate problem is from the `maybe-compile` phase of the stex- bootstrap package, where this code: (define machine #$(chez-machine->threaded (nix-system->chez-machine))) assumes, apparently incorrectly, that it's only going to be run when the result of `nix-system->chez-machine` is non-false. In other words, even if we fix the bug in `nix-system->chez-machine` for i686, I think we'd still hit this problem for systems that Chez really doesn't support, e.g. ppc64le or MIPS. I don't know what the most correct way would be to write this code, but I think we could defer the error until someone attempts to build the package for the unsupported system by just writing something like: (define machine #$(and=> (nix-system->chez-machine) chez-machine->threaded)) -Philip --nextPart11751069.cHTpPW8hJg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE9GWrrNY3rqwUFVXPygNjjfo/HHoFAmInoVwACgkQygNjjfo/ HHqM5A//aqhLQOZY03Uf5BxQ+z1jMfGHLcvICSrUlin/R+ZQUYsoHO/JYU0OueeA H0NUEtxmSga8DvrpvmzH3+uc9dzAkbiovRIvABFjG2ZYwwwMA3e2glsHPmWp4w7U Xg+kVvBQbjumE7IS9zgTSFCYUU4PgSjoqcK39lWcvpPv0oBK30bNpqYwLWV75OQ6 EDNxSCUVJ/ucorB8BqZrRg/UZtGrdMf5bAXbNbpUEbciJbxh8nitP79qkAgrmgXB tG8MeLLAUjHKdGVw2KpY30mixBR8IZ+doVJQk9hzNC/DOAWGM32TQNz79YS+WHh8 8tnMTTf++XEu26JbZZbmosaH65sa6Fk4NK+MS1k00ofBhA2C3Cpjo1ujrT3SmRY0 0fhyfw/glZ2WL6pnGTdnmWy0tq2QP2jeKtCPZQlOQ0Ji8QZiAtGyxvN/9K36yn/3 onUZU3J5JwQDRel09xAQzFPLSyecJ3JoRvd6LtKwoV/bY7077WLYhx0f4yhuNna1 o2kaP5MhkiN6V2/6Qs+IhPGnL8pSQ1j2V7VzWgaNlb+lQ+RLD0IjO0SCA1gzeh98 1yAmFLzs3+W8tIJClv3Aaje1/TN3dI3Rz14JWxJi7fNXTpeNtrcFokbWXYYZ36zH K+Z7Dr6DZ0F6XbGTFYwkCM2PTVWhDEBVY7JgVNN9C98W4L9U9qs= =Ck8A -----END PGP SIGNATURE----- --nextPart11751069.cHTpPW8hJg--