Re: [PATCH] gnu: Add dwm.

[Cyril Roelandt <tipecaml@gmail.com>]

On 04/03/2013 10:20 AM, Ludovic Courtès wrote:
>
> Cyril Roelandt<tipecaml@gmail.com>  skribis:
>
>> I had to turn '${CC}' into 'gcc' in the Makefile, because ${CC} was 'cc', and
>> there was no 'cc' command available. Would it make sense to create a symlink
>> when installing gcc ?
>
> Dunno.  It’s the first time we see this, no?
>

I think so. I'm not even sure why ${CC} is expanded to 'cc'.

>> +         (lambda* (#:key outputs #:allow-other-keys)
>> +          (let ((out (assoc-ref outputs "out")))
>> +           (zero?
>> +            (system* "make" "install"
>> +             (string-append "DESTDIR=" out) "PREFIX="))))
>
> “(string-append” should be aligned with "make".
>
> Is it really DESTDIR and not PREFIX that must be set?
>

I don't know. Usually, packages use either 'prefix' (as in "./configure 
--prefix=...") or 'destdir' (as in "make install DESTIR=...), but not 
both. What's the fundamental difference between them ?

>> +    (license "x11")))
>
> Typo: should be ‘x11’ (the variable).

Good catch!

Thanks for your review.


Cyril.