From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Roelandt Subject: Re: [PATCH] gnu: Add cmake. Date: Thu, 21 Mar 2013 19:55:53 +0100 Message-ID: <514B57B9.2060708@gmail.com> References: <1363060349-19250-1-git-send-email-tipecaml@gmail.com> <87k3p9q3sx.fsf@gnu.org> <51428383.90407@gmail.com> <87k3p9ymfq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:50794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIkpo-0007Nz-Ok for bug-guix@gnu.org; Thu, 21 Mar 2013 15:07:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIkpm-0000Fo-TB for bug-guix@gnu.org; Thu, 21 Mar 2013 15:07:32 -0400 In-Reply-To: <87k3p9ymfq.fsf@gnu.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: =?UTF-8?B?THVkb3ZpYyBDb3VydMOocw==?= Cc: bug-guix@gnu.org On 03/15/2013 11:41 AM, Ludovic Courtès wrote: > Cyril Roelandt skribis: > >> On 03/14/2013 06:39 PM, Ludovic Courtès wrote: > > [...] > >>> Ideally all patches should eventually be submitted upstream, but >>> sometimes it’s not desirable, because the changes would too specific or >>> intrusive. State it in the patch if that is the case. >>> >> >> Here, these tests require network connectivity, so I don't think >> upstream will accept the patches. > > Ah OK. Then just specify it in the patch header. > Done, thanks for your review. Cyril.