From: Cyril Roelandt <tipecaml@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: bug-guix@gnu.org
Subject: Re: [PATCH] gnu: Add cmake.
Date: Fri, 15 Mar 2013 03:12:19 +0100 [thread overview]
Message-ID: <51428383.90407@gmail.com> (raw)
In-Reply-To: <87k3p9q3sx.fsf@gnu.org>
On 03/14/2013 06:39 PM, Ludovic Courtès wrote:
> Cyril Roelandt<tipecaml@gmail.com> skribis:
>
>> * gnu/packages/cmake.scm: New file.
>> * gnu/packages/patches/cmake-fix-tests.patch: New file.
>> * Makefile.am: Add them.
>
> Thanks! Can you add a comment at the top of the patch saying what it
> does, why, with a pointer to any relevant mailing list discussion or
> documentation?
>
Sure.
> Ideally all patches should eventually be submitted upstream, but
> sometimes it’s not desirable, because the changes would too specific or
> intrusive. State it in the patch if that is the case.
>
Here, these tests require network connectivity, so I don't think
upstream will accept the patches.
> Other than that, looks good to me, so feel free to push then.
>
> It would be great to have a ‘cmake-build-system’, which would be based
> on ‘gnu-build-system’ but with specific ‘configure’ and ‘test’ phases.
> See guix/build-system/perl.scm and related files for an example. :-)
>
I'll have to try and package a piece of software requiring cmake, then :)
Cyril.
next prev parent reply other threads:[~2013-03-15 2:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 3:52 [PATCH] gnu: Add cmake Cyril Roelandt
2013-03-14 17:39 ` Ludovic Courtès
2013-03-15 2:12 ` Cyril Roelandt [this message]
2013-03-15 10:41 ` Ludovic Courtès
2013-03-21 18:55 ` Cyril Roelandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51428383.90407@gmail.com \
--to=tipecaml@gmail.com \
--cc=bug-guix@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).