unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Morgan.J.Smith@outlook.com, 51258-done@debbugs.gnu.org,
	paxton@riseup.net
Subject: bug#51258: [PATCH v3] gnu: emacs: Handle pdump filenames that contain a fingerprint
Date: Sun, 24 Oct 2021 10:52:30 +0200	[thread overview]
Message-ID: <4e87942686af0a94689f8ed22dedd5d1ea5b7af5.camel@gmail.com> (raw)
In-Reply-To: <BYAPR05MB40231F6A4062C4D8F4170D60C5829@BYAPR05MB4023.namprd05.prod.outlook.com>

Hi,

Am Samstag, den 23.10.2021, 21:00 -0400 schrieb
Morgan.J.Smith@outlook.com:
> From: Morgan Smith <Morgan.J.Smith@outlook.com>
> 
> * gnu/packages/emacs.scm (emacs) [restore-emacs-pdmp]: Change regex
> to handle
> filenames that have a fingerprint in them. Remove #t at the end of
> the
> phase. Don't bother deleting the old files because rename will
> overwrite them
> anyways.
> ---
> 
> find-files does sort its return so my previous 2 patches probably
> work great regardless of the number of pdmps we encounter (which will
> only ever be 1 anyways).
You are completely right, thanks for pointing that out.  I've pushed an
adjusted v2 with updated comments and everything.  I also verified that
emacs-next could be updated with a little hacking around patches that
don't apply.

Thanks!





      reply	other threads:[~2021-10-24  8:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-17 21:20 bug#51258: emacs-next/git-master broken due to pdmp file naming changes Paxton Evans
2021-10-18 23:50 ` bug#51258: [PATCH] gnu: emacs: Handle pdump filenames that contain a fingerprint Morgan.J.Smith
2021-10-19 18:45   ` Liliana Marie Prikler
2021-10-19 19:10 ` bug#51258: [PATCH v2] " Morgan.J.Smith
2021-10-19 19:53   ` Liliana Marie Prikler
2021-10-24  1:00 ` bug#51258: [PATCH v3] " Morgan.J.Smith
2021-10-24  8:52   ` Liliana Marie Prikler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e87942686af0a94689f8ed22dedd5d1ea5b7af5.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=51258-done@debbugs.gnu.org \
    --cc=Morgan.J.Smith@outlook.com \
    --cc=paxton@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).