From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WF+CIJGyhWHJWgEAgWs5BA (envelope-from ) for ; Fri, 05 Nov 2021 23:39:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4NtKHJGyhWFuLAAA1q6Kng (envelope-from ) for ; Fri, 05 Nov 2021 22:39:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4E6D7138D5 for ; Fri, 5 Nov 2021 23:39:13 +0100 (CET) Received: from localhost ([::1]:42968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mj7rc-0008DR-7T for larch@yhetil.org; Fri, 05 Nov 2021 18:39:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mj7rS-0008Ag-Va for bug-guix@gnu.org; Fri, 05 Nov 2021 18:39:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35990) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mj7rS-0001l8-Ng for bug-guix@gnu.org; Fri, 05 Nov 2021 18:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mj7rS-000627-Cy for bug-guix@gnu.org; Fri, 05 Nov 2021 18:39:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#51559: [PATCH] gnu: webkitgtk: Disable SSE2 when not on x86_64. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 05 Nov 2021 22:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51559 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Liliana Marie Prikler , 51559@debbugs.gnu.org Received: via spool by 51559-submit@debbugs.gnu.org id=B51559.163615191123152 (code B ref 51559); Fri, 05 Nov 2021 22:39:02 +0000 Received: (at 51559) by debbugs.gnu.org; 5 Nov 2021 22:38:31 +0000 Received: from localhost ([127.0.0.1]:47536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mj7qx-00061M-Bl for submit@debbugs.gnu.org; Fri, 05 Nov 2021 18:38:31 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:48088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mj7qv-00061D-0q for 51559@debbugs.gnu.org; Fri, 05 Nov 2021 18:38:30 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id EmeS2600F4UW6Th01meS5V; Fri, 05 Nov 2021 23:38:27 +0100 Message-ID: <467878a051a501030ed658800a7d0c7ebfa603b5.camel@telenet.be> From: Maxime Devos Date: Fri, 05 Nov 2021 22:38:26 +0000 In-Reply-To: References: <5acdf0477d3c75319d6f6ef668c6323be7ea680e.camel@gmail.com> <3c36e72879c977e9f1c9fcd485a75d908d2391c5.camel@telenet.be> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1636151907; bh=Bo1BNlaynHz0RRuLqd0m1FHfvhUUM/VUvclLPajH7b0=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Nj+53FDvcHFctSnYyFT7gDlk7+7gAufOGjszbO/y2ecO0kPcyKQUXA+JIl5XIUSRf XN3QTd0fLdNdg2WF0X/CT4DGx1vF7SsGX6VOII+I0+UuyMl0qODexSthaT6yC6oYKb Cd+ZPvRRMpFa57YITfDfE7g5/UH7xgQnHW6ILqks8LjggaWGBW0QYhLWn6pjFk45qG ihPht7gt3h7YTFOlpKhARAmC+qmzbO8gTpjBEMPshkU16vxFLDUHLVUK1PXeXPTM3s IXT6AxAnJFDKrEWu7weEMXeik/r9TJETRR+qn0KVxZ1QjwGjueIhV/DA/oo5H1g2jc QKRDM22D4BxHQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: maxim.cournoyer@gmail.com Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636151953; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Bo1BNlaynHz0RRuLqd0m1FHfvhUUM/VUvclLPajH7b0=; b=ZSg+fv5ryTIVICVgU95TmXDYYErjnwVFQmay7ZEtK/yQDg8GWPN922XRd7QN92YIYNSowh 8tO7kpIbw6wudVNg6qj0TeV5b2nU8IkfS+Gan27rEK3pMM/chAZuZa56QuIOuXq9Gyw4Ik xYAR6HeTtnmor/RQ+DTL9sN4N+uCzIAhgT567RREj1mODXQ3Cf7YW6bIGM8ERDarIwXMyb +xiaRLDK2/HA4J19sBmmfzszUvrYOncwfJQ82rvnDhZGnx4VCzEFmqvAwoxoh/xYcqy1NM Wrc9vcOmCz4npnMVltEWbW5TswDypDYiNqPKcvEFtdcYIE5vP7gRGmIdhslRpQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636151953; a=rsa-sha256; cv=none; b=SnsrV7CaTaPK2HC23NuYCZhp8wFcIsFhI1Uv4zQMEQFVZsWjKWUrfDU+JPAtcnSEqL+0wX +RwGnMROmUp7LxsSaTTiMAOoh8o9QXIZe9ZR+oNv/D2Nu/BTHcUsKbhWBMxXY4gHYfNmxw nhSR4drdJHEC3x1G5YP5MDOnxB/R4SLqIQSe3ygBa83o+F5Z5OvU2RNrPlx/IYaAwgRo5F l/DcN0sxZXVfcoNxl9mfyMAZXijF/4DZg7RshH0K8MPIP5HsjLXzXt2iw3rZdkwbFAFSB9 WsOL2LN6+O26NAog1l3eJGwNHmJ0cYC8D3PcJ05w4lrI3oZr/IztUgoK+lMirA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=Nj+53FDv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: 0.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=Nj+53FDv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 4E6D7138D5 X-Spam-Score: 0.18 X-Migadu-Scanner: scn0.migadu.com X-TUID: /VlRJgwMhPjY Liliana Marie Prikler schreef op vr 05-11-2021 om 23:19 [+0100]: > > > [...] > > > +         (add-after 'unpack 'disable-sse2 > > > +           (lambda* (#:key system #:allow-other-keys) > > > +             (unless (string-prefix? "x86_64" system) > > > > IIUC, when cross-compiling, you need to look at 'target', not > > 'system'.  At least, that's the case if %current-system/%current- > > target-system is used. Not sure about 'system' and 'target'. > Do target and system follow the same rules?  If so, I could write (or > target system), no?  Packages on master sadly follow wildly different > conventions and I picked one at random. Looking at (guix build system gnu), there are three system/target-like arguments: a. system, which is set to (%current-system) b. build, which is set to the GNU triplet equivalent (%current-system) c. target, which is set to (%current-target-system) (#f when compiling natively) So it appears system and target correspond to (%current-system) and (%current-target-system), so (or target system) should work, I think. I prefer ,(target-x86-64?) myself though, because it avoids having to remember that 'target' is not set when compiling natively. I think 'target' should always be set, because compiling natively is ‘merely’ a special case of cross-compiling, and (or target system)/(or (%current-target-system) (%current-system)) seems a bit repetitive to me). That would probably break some package definitions though, and not really related to webkitgtk. Also, that the arch comes first in GNU triplets and nix system strings, seems a bit an implementation detail to me. Not terribly important / YMMV though. Greetings, Maxime.