unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Suhail Singh <suhailsingh247@gmail.com>
Cc: cox.katherine.e+guix@gmail.com, 72045@debbugs.gnu.org, andrew@trop.in
Subject: bug#72045: [PATCH RFC 1/2] gnu: emacs: Compute ABI hash and native version dir without version.
Date: Sat, 13 Jul 2024 19:26:10 +0200	[thread overview]
Message-ID: <4525ce8ef51ad9803a1d29da3c872080015b8b81.camel@gmail.com> (raw)
In-Reply-To: <87r0bx46n1.fsf@gmail.com>

Am Samstag, dem 13.07.2024 um 12:08 -0400 schrieb Suhail Singh:
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> 
> > this is a somewhat experimental patch, which reduces
> > Vcomp_native_version_dir to simply Vcomp_abi_hash.  Note, that this
> > is not enough to address the issues currently noticed with Emacs
> > native compilation, as Vcomp_abi_hash is unstable between 29.3 and
> > 29.4.  These hashes are probably unlikely to stay the same between
> > minor releases even when dropping the version.
> 
> I am confused as to what this change is intended to accomplish in
> that case.  Specifically, while this patch may be _necessary_ to
> allow both grafts and native-compilation to work since it isn't
> _sufficient_ to accomplish that, it may be better to withhold the
> patch till a later time when an appropriate fix for dealing with
> grafts has been found.
It could possibly allow us some flexibility in future changes, but at
the very least it doesn't work right now.  Hence why it's RFC while the
other patch isn't.

Cheers





  reply	other threads:[~2024-07-13 17:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-10 20:06 bug#72045: Emacs graft lookup still fails Liliana Marie Prikler
2024-07-13  5:49 ` bug#72045: [PATCH RFC 1/2] gnu: emacs: Compute ABI hash and native version dir without version Liliana Marie Prikler
2024-07-13  5:53   ` bug#72045: [PATCH 2/2] gnu: emacs-minimal: Ungraft Liliana Marie Prikler
2024-07-13 16:14     ` Suhail Singh
2024-07-13 16:59       ` Liliana Marie Prikler
2024-07-13 16:08   ` bug#72045: [PATCH RFC 1/2] gnu: emacs: Compute ABI hash and native version dir without version Suhail Singh
2024-07-13 17:26     ` Liliana Marie Prikler [this message]
2024-07-13 17:59       ` Suhail Singh
2024-07-13 23:22 ` bug#72045: Emacs graft lookup still fails Suhail Singh
2024-07-14  8:50   ` Liliana Marie Prikler
2024-07-14 16:27     ` Suhail Singh
2024-07-14 16:46       ` Liliana Marie Prikler
2024-07-14 16:56         ` Suhail Singh
2024-07-14 16:59           ` Suhail Singh
2024-07-19  7:35 ` bug#72045: [PATCH v2 1/2] gnu: Add system test for Emacs Liliana Marie Prikler
2024-07-19 15:23   ` Suhail Singh
2024-07-19 15:42     ` Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4525ce8ef51ad9803a1d29da3c872080015b8b81.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=72045@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=suhailsingh247@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).