From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id AKqmLMRseWKeNwAAbAwnHQ (envelope-from ) for ; Mon, 09 May 2022 21:34:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oO3HLMRseWI2WQEA9RJhRA (envelope-from ) for ; Mon, 09 May 2022 21:34:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5173A28771 for ; Mon, 9 May 2022 21:34:27 +0200 (CEST) Received: from localhost ([::1]:37722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no99G-0001EJ-8q for larch@yhetil.org; Mon, 09 May 2022 15:34:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no98s-0001E9-I9 for bug-guix@gnu.org; Mon, 09 May 2022 15:34:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37379) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1no98s-0001jK-9s for bug-guix@gnu.org; Mon, 09 May 2022 15:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1no98s-0005tD-6P for bug-guix@gnu.org; Mon, 09 May 2022 15:34:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#55326: libgit2 1.3.0 includes a time-dependent test Resent-From: Carl Dong Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 09 May 2022 19:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55326 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxime Devos Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 55326-done@debbugs.gnu.org Received: via spool by 55326-done@debbugs.gnu.org id=D55326.165212481022594 (code D ref 55326); Mon, 09 May 2022 19:34:02 +0000 Received: (at 55326-done) by debbugs.gnu.org; 9 May 2022 19:33:30 +0000 Received: from localhost ([127.0.0.1]:59509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no98L-0005sM-SG for submit@debbugs.gnu.org; Mon, 09 May 2022 15:33:30 -0400 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]:48495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no98E-0005s0-UJ for 55326-done@debbugs.gnu.org; Mon, 09 May 2022 15:33:28 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 030BF2B015C0; Mon, 9 May 2022 15:33:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 09 May 2022 15:33:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=carldong.me; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1652124796; x=1652131996; bh=H261b3yXls g6GMs/FHlYbUCqrCsqYFcQBhkgRJLbm3M=; b=LdglGP0MkKN5FyAan9gA0lcrUi IeyZMkZ/qjvk+dOrS4FhzkcFmu0sUGKyETPpJuKi4hnaiTv62HU/pDsBugEjOqa8 8X9UNPMM0S/maG5yUTpl+aDPDfXfSTd+EBoDaYzsT3R1hUNO22yZ48pVfril3RXS iKZlz775vGrKT60SyC9bNY2MKxlMyYWw+oejCLGmDOVOJZdTo13yZtS1lGbIGlY7 l3MWyf5gtRbCXWYEFaeRBmACBNB7q1SjfXSHb6taLFA411Sbdj9RVBZXYfXibKS0 U2OSNKmOGlQ2rQehvWkEfiDzHeIVtHMIOKVR4JLgSvy5aIRrGOZgsdQ7AQ4g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652124796; x= 1652131996; bh=H261b3yXlsg6GMs/FHlYbUCqrCsqYFcQBhkgRJLbm3M=; b=Y 4lDeF46wHbWrcSH0fQKHRCnjvK0X0C7LLKaPNCr0jM/fAivVe6ET/hJTGOwWRrWL 3ggWpnXjjyVrAns6K6NXLKAL8OXufv4zJ12LLK9z1JkwKmVDAtJD9dXUOeL/iBvF O9pAwnhTeOit0RGHayHKz+K+U9RPoce2nXSXbK9p/ZvtciWp7dKaVoUoR6V36ENU Qt9QawhfHxvcPPyNxM6e7GmQ3YnERwAtCnUBt7S4emZm4diVZj2ksOLTKb/z49dk GLzUeJhvMzZodqDGj8DgwyCvVLG76cOA2DSiZ3SUYZ/K5lkgk6WKC5NJGASl2F4v iug5zLeKxuswn4ml9OrcA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeelgddufeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffktgggufffjgevvfhfofesghdtmherhhdtjeenucfhrhhomhepvegrrhhl ucffohhnghcuoegtohhnthgrtghtsegtrghrlhguohhnghdrmhgvqeenucggtffrrghtth gvrhhnpedvffektedujeekgffhvdejhfdvhfehffejteeikedujeevgfdvteetieelveej leenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomheptghonhhtrggtthestggrrhhlughonhhgrdhm vg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 9 May 2022 15:33:16 -0400 (EDT) From: Carl Dong Message-Id: <43A362D3-1DDE-405C-B852-E506B7A0233A@carldong.me> Content-Type: multipart/signed; boundary="Apple-Mail=_3C4DD2B9-9E46-4369-926F-3FE44B180196"; protocol="application/pgp-signature"; micalg=pgp-sha256 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Date: Mon, 9 May 2022 15:33:14 -0400 In-Reply-To: References: <87zgjrwx7z.fsf@inria.fr> <8735hjvfnb.fsf@gnu.org> X-Mailer: Apple Mail (2.3696.80.82.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652124868; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=H261b3yXlsg6GMs/FHlYbUCqrCsqYFcQBhkgRJLbm3M=; b=aUOvpbd/PJVgvsfiLVqcrMbOW2tHfLwCXw3+YIZYc4dejUzaXbh5CtVz2QUCfKb/RWhYQn VI8jrzTp0VcT8hwASsecYBpCWuozfGXdu8Vzt0JJQ8UWR1qgPWFAPE/tN1Lg4mHlBwIP6t aEOYOxoLFD1QIwqLhV/rJRtHjOFkCvNWs9kn45aS1EvTeP9uictnB2jH8d0MJ293tHnzjk 52oyUmpxpDoSLI3zM4ykYj/2VIGI4t/w16+hpNOtLdpPb6KEyJCodzkd+mMgh50rKa/oZ3 Jis5Q6lmcccRXlwrqw6fyIqycKPD6HIDGLM4lAaFQ30RnQEM2PAcJ0i10QwuVA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652124868; a=rsa-sha256; cv=none; b=MwFrEH1u/z90Ox/kjqm3rheEGj9xrCfNxNzXq+r4UYJnaiLl/uQSDvaJKGjtHj5n1OZacj m5syxFERD38reqVSMoT7+zjAzrNYIvFbutNlt+Q2RCdI3VV3tHhrTBZBaNpN3RWRcS3eqy eRHjNAotOqaHDYgvv4ApjOankdTm+Ib0O71qmyOiecn5HbouOrrbpJTKhbAiWdjQjv1201 0zbeFLbpRMwKiCxAqlRjL99CpxZHLNxVrOclTU0VST+q6aKswBLbhDNWnZggZwurxjeEdr /oiX88u+pLs2V+xLmBxIz6n617KmNYux1u0FUKVfUnh9ALjZIkTqFblDZ2mh+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=carldong.me header.s=fm1 header.b=LdglGP0M; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="Y 4lDeF4"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.40 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=carldong.me header.s=fm1 header.b=LdglGP0M; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="Y 4lDeF4"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5173A28771 X-Spam-Score: -2.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: AVl+nqVtQNDM --Apple-Mail=_3C4DD2B9-9E46-4369-926F-3FE44B180196 Content-Type: multipart/alternative; boundary="Apple-Mail=_D7592687-8461-4A42-9FF5-9E6C577A27A5" --Apple-Mail=_D7592687-8461-4A42-9FF5-9E6C577A27A5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 I opened a pull request upstream that just removes the specific test for = =E2=80=9CHEAD@{10 years ago}". Since that functionality is well-covered = by subsequent tests. See here for the PR: https://github.com/libgit2/libgit2/pull/6299 = > Though maybe by that time, we have complete time namespaces =E2=80=A6 One would hope! Cheers, Carl Dong > On May 9, 2022, at 3:25 AM, Maxime Devos = wrote: >=20 > Ludovic Court=C3=A8s schreef op ma 09-05-2022 om 00:11 [+0200]: >> Fixed: >>=20 >> e48b5484afde93294c4ed7215e88ed450842b2e5 (master) >> f5fe0082abe4547f3fb9f29d8351473cfb3a387b (staging) >=20 > It's still time-dependent though: >=20 >> + (substitute* "tests/refs/revparse.c" >> + (("10 years ago") >> + "100 years ago")))))) >=20 > wouldn't it now fail after ~100 or ~1000 years? > Though maybe by that time, we have complete time namespaces ... >=20 > Greetings, > Maxime. --Apple-Mail=_D7592687-8461-4A42-9FF5-9E6C577A27A5 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 I = opened a pull request upstream that just removes the specific test for = =E2=80=9CHEAD@{10 years ago}". Since that functionality is well-covered = by subsequent tests.

See here for the PR: https://github.com/libgit2/libgit2/pull/6299

Though maybe by = that time, we have complete time namespaces =E2=80=A6
On= e would hope!

Cheers,
Carl Dong

On May 9, 2022, at 3:25 AM, Maxime Devos <maximedevos@telenet.be> wrote:

Ludovic Court=C3=A8s schreef op ma = 09-05-2022 om 00:11 [+0200]:
Fixed:

  = e48b5484afde93294c4ed7215e88ed450842b2e5 (master)
  = f5fe0082abe4547f3fb9f29d8351473cfb3a387b (staging)

It's still time-dependent = though:

+ =             &n= bsp;    (substitute* "tests/refs/revparse.c"
+ =             &n= bsp;      (("10 years ago")
+ =             &n= bsp;       "100 years ago"))))))

wouldn't it now fail after ~100 = or ~1000 years?
Though maybe by that time, we have = complete time namespaces ...

Greetings,
Maxime.

= --Apple-Mail=_D7592687-8461-4A42-9FF5-9E6C577A27A5-- --Apple-Mail=_3C4DD2B9-9E46-4369-926F-3FE44B180196 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEECc3SW1JEo3Z49u6oDMUhUxl5kaUFAmJ5bHoACgkQDMUhUxl5 kaW2+xAAhM5rXbTN5TECIrCol1tO4rX7UF4dOn5ewX438564n86uY93H+2/1GBFo vYISxBCh2rW1fylNba3iD/SDNmg6G8hP/fLkhDKtPDLsnneNqXNm7i6Cng1UiHW7 DDAufVL2n7uPEEZOX6TJWOUMgjeEKdHzs22GUVS4VEzfiGcnjq5niWiqNYQia97h FJvQGSyvyxNZVYqs2H9HE1rqwAhQrnlO/Cyb+eZDNvHw1VuO7OXOV8dAzLq/255V WfOLW3cS4D2o4+4adSSZn1p2rS42NstcDnRWEMx+zHb7X9tEsYW+5i/sPSWZRVd0 fXYccu/pCdgqB8iSZwHBb+Ny44en+6EPP4GHoUmj+DP4a6GjjLqL2j+VSeJhC90V txOxLYgoMQFyNqLnAqIHXWtg00uJ4ObwVL+9Pix/nVQxthv3NxC+5XyANcaNNOh8 zlFwCv0P14j/EwlnQaSSDyjKQvCEoNIEYOByJrA0/FwB9gEHuJ7+IZlFTfPvbuKa FnYZOMzNoehX0kqMKlX+t2m9KRjlqgyc7nuyXpXAEalmvHJFpEUfW6qqIpC0DNF9 XVDzdw34ENo35F2VHa4EhYYLiqgU11nDO/f7jjHSmQxSXYG/zIK8AzCT5LZ4F1OB lomZhG4FZc62svPOy3PMCap3nDSiVLot4HTi6HQx5R1S0eEVMxg= =IvBL -----END PGP SIGNATURE----- --Apple-Mail=_3C4DD2B9-9E46-4369-926F-3FE44B180196--