unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Carl Dong <contact@carldong.me>
To: Maxime Devos <maximedevos@telenet.be>
Cc: "Ludovic Courtès" <ludo@gnu.org>, 55326-done@debbugs.gnu.org
Subject: bug#55326: libgit2 1.3.0 includes a time-dependent test
Date: Mon, 9 May 2022 15:33:14 -0400	[thread overview]
Message-ID: <43A362D3-1DDE-405C-B852-E506B7A0233A@carldong.me> (raw)
In-Reply-To: <b7088e36f25e87e9d9430c661fcb71c957e26bcf.camel@telenet.be>


[-- Attachment #1.1: Type: text/plain, Size: 1008 bytes --]

I opened a pull request upstream that just removes the specific test for “HEAD@{10 years ago}". Since that functionality is well-covered by subsequent tests.

See here for the PR: https://github.com/libgit2/libgit2/pull/6299 <https://github.com/libgit2/libgit2/pull/6299>

> Though maybe by that time, we have complete time namespaces …
One would hope!

Cheers,
Carl Dong

> On May 9, 2022, at 3:25 AM, Maxime Devos <maximedevos@telenet.be> wrote:
> 
> Ludovic Courtès schreef op ma 09-05-2022 om 00:11 [+0200]:
>> Fixed:
>> 
>>   e48b5484afde93294c4ed7215e88ed450842b2e5 (master)
>>   f5fe0082abe4547f3fb9f29d8351473cfb3a387b (staging)
> 
> It's still time-dependent though:
> 
>> +                  (substitute* "tests/refs/revparse.c"
>> +                    (("10 years ago")
>> +                     "100 years ago"))))))
> 
> wouldn't it now fail after ~100 or ~1000 years?
> Though maybe by that time, we have complete time namespaces ...
> 
> Greetings,
> Maxime.


[-- Attachment #1.2: Type: text/html, Size: 2312 bytes --]

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2022-05-09 19:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-08 21:06 bug#55326: libgit2 1.3.0 includes a time-dependent test Ludovic Courtès
2022-05-08 22:11 ` Ludovic Courtès
2022-05-09  7:25   ` Maxime Devos
2022-05-09  8:49     ` Ludovic Courtès
2022-05-09 10:10       ` Maxime Devos
2022-05-10 15:50         ` Ludovic Courtès
2022-05-09 19:33     ` Carl Dong [this message]
2022-05-10 15:48       ` Ludovic Courtès
2022-06-03 17:58 ` Maxime Devos
2022-06-08 16:16   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43A362D3-1DDE-405C-B852-E506B7A0233A@carldong.me \
    --to=contact@carldong.me \
    --cc=55326-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).